[Test gen] Remove duplicate checks if file is equal to some string

compiler/tests-common/tests/org/jetbrains/kotlin/generators/impl/TestGeneratorImpl.kt

@@ -101,10 +101,10 @@ private class TestGeneratorImplInstance(
         val generatedCode = generate()
 
         val testSourceFile = File(testSourceFilePath)
-        val changed =
-            GeneratorsFileUtil.isFileContentChangedIgnoringLineSeparators(testSourceFile, generatedCode)
-        if (!dryRun) {
+        val changed = if (!dryRun) {
             GeneratorsFileUtil.writeFileIfContentChanged(testSourceFile, generatedCode, false)
+        } else {
+            GeneratorsFileUtil.isFileContentChangedIgnoringLineSeparators(testSourceFile, generatedCode)
         }
         return TestGenerator.GenerationResult(changed, testSourceFilePath)
     }

generators/main/GeneratorsFileUtil.kt

@@ -24,11 +24,11 @@ object GeneratorsFileUtil {
     @JvmStatic
     @JvmOverloads
     @Throws(IOException::class)
-    fun writeFileIfContentChanged(file: File, newText: String, logNotChanged: Boolean = true, forbidGenerationOnTeamcity: Boolean = true) {
+    fun writeFileIfContentChanged(file: File, newText: String, logNotChanged: Boolean = true, forbidGenerationOnTeamcity: Boolean = true): Boolean {
         val parentFile = file.parentFile
         if (!parentFile.exists()) {
             if (forbidGenerationOnTeamcity) {
-                if (failOnTeamCity("Create dir `${parentFile.path}`")) return
+                if (failOnTeamCity("Create dir `${parentFile.path}`")) return false
             }
             if (parentFile.mkdirs()) {
                 println("Directory created: " + parentFile.absolutePath)
@@ -40,10 +40,10 @@ object GeneratorsFileUtil {
             if (logNotChanged) {
                 println("Not changed: " + file.absolutePath)
             }
-            return
+            return false
         }
         if (forbidGenerationOnTeamcity) {
-            if (failOnTeamCity("Write file `${file.toPath()}`")) return
+            if (failOnTeamCity("Write file `${file.toPath()}`")) return false
         }
         val useTempFile = !SystemInfo.isWindows
         val targetFile = file.toPath()
@@ -54,6 +54,7 @@ object GeneratorsFileUtil {
             tempFile.moveTo(targetFile, overwrite = true)
         }
         println("File written: ${targetFile.toAbsolutePath()}")
+        return true
     }
 
     private fun failOnTeamCity(message: String): Boolean {

generators/test-generator/tests/org/jetbrains/kotlin/generators/NewTestGeneratorImpl.kt

@@ -112,10 +112,10 @@ class NewTestGeneratorImpl(
             val generatedCode = generate()
 
             val testSourceFile = File(testSourceFilePath)
-            val changed =
-                GeneratorsFileUtil.isFileContentChangedIgnoringLineSeparators(testSourceFile, generatedCode)
-            if (!dryRun) {
+            val changed = if (!dryRun) {
                 GeneratorsFileUtil.writeFileIfContentChanged(testSourceFile, generatedCode, false)
+            } else {
+                GeneratorsFileUtil.isFileContentChangedIgnoringLineSeparators(testSourceFile, generatedCode)
             }
             return GenerationResult(changed, testSourceFilePath)
         }