Dropped some TODOs

#KT-2564 Obsolete. Looks like, it's fixed in dcddd04.
This commit is contained in:
Zalim Bashorov
2014-02-05 16:41:10 +04:00
parent ffa2a84170
commit 33360c2528
4 changed files with 51 additions and 56 deletions
@@ -169,13 +169,13 @@ public class MockCompileContext implements CompileContextEx {
throw new UnsupportedOperationException("org.jetbrains.jet.plugin.compilerMessages.MockCompileContext#requestRebuildNextTime");
}
// TODO mark with override when updating to IDEA 132.527+
@Override
public boolean isRebuildRequested() {
throw new UnsupportedOperationException("org.jetbrains.jet.plugin.compilerMessages.MockCompileContext.isRebuildRequested");
}
// TODO mark with override when updating to IDEA 132.527+
@Nullable
@Override
public String getRebuildReason() {
throw new UnsupportedOperationException("org.jetbrains.jet.plugin.compilerMessages.MockCompileContext.getRebuildReason");
}
@@ -153,10 +153,8 @@ public final class MiscTest extends AbstractExpressionTest {
fooBoxIsValue("OK");
}
//TODO: see http://youtrack.jetbrains.com/issue/KT-2564
@SuppressWarnings("UnusedDeclaration")
public void TODO_testPackageLevelVarInRoot() throws Exception {
runFunctionOutputTest("packageLevelVarInRoot.kt", Namer.getRootPackageName(), "box", "OK");
public void testPackageLevelVarInRoot() throws Exception {
runFunctionOutputTest("packageLevelVarInRoot.kt", Namer.getRootPackageName(), TEST_FUNCTION, "OK");
}
public void testLazyPropertyGetterNotCalledOnStart() throws Exception {
+46 -46
View File
@@ -97,50 +97,50 @@ class PreconditionsTest() {
}
}
// TODO: uncomment when KT-1540 is resolved.
// test fun passingAssert() {
// assert(true)
// var called = false
// assert(true) { called = true; "some message" }
//
// assertFalse(called)
// }
//
//
// test fun failingAssert() {
// val error = fails {
// assert(false)
// }
// if(error is IllegalStateException) {
// assertNull(error.getMessage())
// } else {
// fail("Invalid exception type: "+error)
// }
// }
//
// test fun passingAssertWithMessage() {
// assert(true, "Hello")
// }
//
// test fun failingAssertWithMessage() {
// val error = fails {
// assert(false, "Hello")
// }
// if(error is IllegalStateException) {
// assertEquals("Hello", error.getMessage())
// } else {
// fail("Invalid exception type: "+error)
// }
// }
//
// test fun failingAssertWithLazyMessage() {
// val error = fails {
// assert(false) {"Hello"}
// }
// if(error is IllegalStateException) {
// assertEquals("Hello", error.getMessage())
// } else {
// fail("Invalid exception type: "+error)
// }
// }
test fun passingAssert() {
assert(true)
var called = false
assert(true) { called = true; "some message" }
assertFalse(called)
}
test fun failingAssert() {
val assertDefaultMessage = "Assertion failed"
val error = fails {
assert(false)
}
if(error is AssertionError) {
assertEquals(assertDefaultMessage, error.getMessage())
} else {
fail("Invalid exception type: "+error)
}
}
test fun passingAssertWithMessage() {
assert(true, "Hello")
}
test fun failingAssertWithMessage() {
val error = fails {
assert(false, "Hello")
}
if(error is AssertionError) {
assertEquals("Hello", error.getMessage())
} else {
fail("Invalid exception type: "+error)
}
}
test fun failingAssertWithLazyMessage() {
val error = fails {
assert(false) {"Hello"}
}
if(error is AssertionError) {
assertEquals("Hello", error.getMessage())
} else {
fail("Invalid exception type: "+error)
}
}
}
@@ -9,10 +9,8 @@ class StandardCollectionTest() : TestCase() {
fun testDisabled() {
}
/*
fun testAny() {
// TODO requires KT-924 to be implemented
val data: Iterable<String> = kotlin.util.arrayList("foo", "bar")
val data: Iterable<String> = listOf("foo", "bar")
assertTrue {
data.any{it.startsWith("f")}
@@ -21,5 +19,4 @@ class StandardCollectionTest() : TestCase() {
data.any{it.startsWith("x")}
}
}
*/
}