Move: Use KtNamedDeclaration as referrer when reporting a conflict

EA-103817 Fixed
This commit is contained in:
Alexey Sedunov
2017-06-27 15:17:14 +03:00
parent 58addf72ff
commit 2e8b374ce8
7 changed files with 35 additions and 1 deletions
@@ -380,7 +380,7 @@ class MoveConflictChecker(
val targetVisibility = visibility.normalize()
if (targetVisibility == Visibilities.PUBLIC) return true
val referrer = ref.element.getStrictParentOfType<KtDeclaration>()
val referrer = ref.element.getStrictParentOfType<KtNamedDeclaration>()
val referrerDescriptor = referrer?.resolveToDescriptor() ?: return true
if (!isVisibleIn(referrerDescriptor)) return true
@@ -0,0 +1,4 @@
package source
private class X
@@ -0,0 +1,9 @@
package target
import source.X
class Test {
init {
X()
}
}
@@ -0,0 +1,9 @@
package source
private class X
class <caret>Test {
init {
X()
}
}
@@ -0,0 +1 @@
Class Test uses class X which will be inaccessible after move
@@ -0,0 +1,5 @@
{
"mainFile": "source/Foo.kt",
"type": "MOVE_KOTLIN_TOP_LEVEL_DECLARATIONS",
"targetPackage": "target"
}
@@ -504,6 +504,12 @@ public class MoveTestGenerated extends AbstractMoveTest {
doTest(fileName);
}
@TestMetadata("kotlin/moveTopLevelDeclarations/misc/classWithInitializer/delegateInObject.test")
public void testKotlin_moveTopLevelDeclarations_misc_classWithInitializer_DelegateInObject() throws Exception {
String fileName = KotlinTestUtils.navigationMetadata("idea/testData/refactoring/move/kotlin/moveTopLevelDeclarations/misc/classWithInitializer/delegateInObject.test");
doTest(fileName);
}
@TestMetadata("kotlin/moveTopLevelDeclarations/misc/companionExtensionMemberRef/companionExtensionMemberRef.test")
public void testKotlin_moveTopLevelDeclarations_misc_companionExtensionMemberRef_CompanionExtensionMemberRef() throws Exception {
String fileName = KotlinTestUtils.navigationMetadata("idea/testData/refactoring/move/kotlin/moveTopLevelDeclarations/misc/companionExtensionMemberRef/companionExtensionMemberRef.test");