azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Naming convention inspection for test functions

Browse Source 
#KT-21547 Fixed
This commit is contained in:
Dmitry Jemerov
2017-12-29 17:08:01 +01:00
parent 37d2ff2d4d
commit 1c7d97289b
3 changed files with 34 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/resources/inspectionDescriptions/TestFunctionName.html
+5
View File
@@ -0,0 +1,5 @@
<html>
<body>
Reports test function names that do not follow the recommended naming conventions.
</body>
</html>
idea/src/META-INF/plugin.xml
+8
View File
@@ -2392,6 +2392,14 @@
displayName="Function naming convention"
level="WEAK WARNING"/>
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.TestFunctionNameInspection"
language="kotlin"
groupPath="Kotlin"
groupName="Naming conventions"
enabledByDefault="true"
displayName="Test function naming convention"
level="WEAK WARNING"/>
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.PropertyNameInspection"
language="kotlin"
groupPath="Kotlin"
idea/src/org/jetbrains/kotlin/idea/inspections/NamingConventionInspections.kt
+21 -1
View File
@@ -127,7 +127,27 @@ class FunctionNameInspection : NamingConventionInspection(
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
return object : KtVisitorVoid() {
override fun visitNamedFunction(function: KtNamedFunction) {
if (TestUtils.isInTestSourceContent(function) && function.nameIdentifier?.text?.startsWith("`") == true) {
if (TestUtils.isInTestSourceContent(function)) {
return
}
verifyName(function, holder)
}
}
}
}
class TestFunctionNameInspection : NamingConventionInspection(
"Test function",
"[a-z][A-Za-z_\\d]*",
START_LOWER
) {
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
return object : KtVisitorVoid() {
override fun visitNamedFunction(function: KtNamedFunction) {
if (!TestUtils.isInTestSourceContent(function)) {
return
}
if (function.nameIdentifier?.text?.startsWith("`") == true) {
return
}
verifyName(function, holder)