azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Inspections: Explicit "get"

Browse Source
This commit is contained in:
Alexey Sedunov
2014-03-19 16:20:55 +04:00
parent a0bc6a7b39
commit 1bbec14cc0
7 changed files with 87 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/resources/inspectionDescriptions/ExplicitGet.html
+5
View File
@@ -0,0 +1,5 @@
<html>
<body>
This inspection reports any explicit calls of 'get' which can be replaced by indexing operator []
</body>
</html>
idea/src/META-INF/plugin.xml
+7
View File
@@ -623,6 +623,13 @@
<className>org.jetbrains.jet.plugin.intentions.ConvertNegatedExpressionWithDemorgansLawIntention</className>
<category>Kotlin</category>
</intentionAction>
<localInspection implementationClass="org.jetbrains.jet.plugin.inspections.ExplicitGetInspection"
displayName="Explicit 'get'"
groupName="Kotlin"
enabledByDefault="true"
level="WARNING"
/>
<intentionAction>
<className>org.jetbrains.jet.plugin.intentions.SwapBinaryExpression</className>
idea/src/org/jetbrains/jet/plugin/inspections/ExplicitGetInspection.kt
+22
View File
@@ -0,0 +1,22 @@
/*
* Copyright 2010-2014 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.jetbrains.jet.plugin.inspections
import org.jetbrains.jet.lang.psi.*
import org.jetbrains.jet.plugin.intentions.attributeCallReplacements.ReplaceGetIntention
public class ExplicitGetInspection : IntentionBasedInspection<JetDotQualifiedExpression>(ReplaceGetIntention())
idea/testData/codeInsight/inspections/replaceGet/expected.xml
+10
View File
@@ -0,0 +1,10 @@
<problems>
<problem>
<file>main.kt</file>
<line>3</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/src/main.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get'</problem_class>
<description>Replace 'get' call with index operator</description>
</problem>
</problems>
idea/testData/codeInsight/inspections/replaceGet/options.test
+1
View File
@@ -0,0 +1 @@
// INSPECTION_CLASS: org.jetbrains.jet.plugin.inspections.ExplicitGetInspection
idea/testData/codeInsight/inspections/replaceGet/src/main.kt
+4
View File
@@ -0,0 +1,4 @@
fun foo() {
val a = Array<Int>(10) { it }
println(a.get(5))
}
idea/tests/org/jetbrains/jet/plugin/codeInsight/JetInspectionTestGenerated.java
+38
View File
@@ -0,0 +1,38 @@
/*
* Copyright 2010-2014 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.jetbrains.jet.plugin.codeInsight;
import org.jetbrains.jet.JetTestUtils;
import org.jetbrains.jet.test.TestMetadata;
import java.io.File;
import java.util.regex.Pattern;
/** This class is generated by {@link org.jetbrains.jet.generators.tests.TestsPackage}. DO NOT MODIFY MANUALLY */
@SuppressWarnings("all")
@TestMetadata("idea/testData/codeInsight/inspections")
public class JetInspectionTestGenerated extends AbstractJetInspectionTest {
public void testAllFilesPresentInInspections() throws Exception {
JetTestUtils.assertAllTestsPresentByMetadata(this.getClass(), "org.jetbrains.jet.generators.tests.TestsPackage", new File("idea/testData/codeInsight/inspections"), Pattern.compile("^([^\\.]+)$"), false);
}
@TestMetadata("replaceGet")
public void testReplaceGet() throws Exception {
doTest("idea/testData/codeInsight/inspections/replaceGet");
}
}