Remove no longer meaningful utils from JavaResolverUtils

This commit is contained in:
Pavel V. Talanov
2014-12-18 19:52:33 +03:00
parent 24f1635d2c
commit 15add4bd64
3 changed files with 2 additions and 41 deletions
@@ -16,7 +16,6 @@
package org.jetbrains.jet.lang.resolve.java;
import com.intellij.psi.PsiClass;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.jetbrains.jet.lang.descriptors.DeclarationDescriptor;
@@ -24,7 +23,6 @@ import org.jetbrains.jet.lang.descriptors.SourceElement;
import org.jetbrains.jet.lang.descriptors.TypeParameterDescriptor;
import org.jetbrains.jet.lang.descriptors.impl.TypeParameterDescriptorImpl;
import org.jetbrains.jet.lang.resolve.java.structure.*;
import org.jetbrains.jet.lang.resolve.java.structure.impl.JavaClassImpl;
import org.jetbrains.jet.lang.types.TypeConstructor;
import org.jetbrains.jet.lang.types.TypeProjection;
import org.jetbrains.jet.lang.types.TypeProjectionImpl;
@@ -32,27 +30,10 @@ import org.jetbrains.jet.lang.types.TypeSubstitutor;
import java.util.*;
import static org.jetbrains.jet.lang.resolve.java.JvmAnnotationNames.KOTLIN_CLASS;
import static org.jetbrains.jet.lang.resolve.java.JvmAnnotationNames.KOTLIN_PACKAGE;
public class JavaResolverUtils {
private JavaResolverUtils() {
}
public static boolean isCompiledKotlinClass(@NotNull PsiClass psiClass) {
JavaClass javaClass = new JavaClassImpl(psiClass);
return javaClass.getOriginKind() == JavaClass.OriginKind.COMPILED && javaClass.findAnnotation(KOTLIN_CLASS) != null;
}
public static boolean isCompiledKotlinPackageClass(@NotNull PsiClass psiClass) {
JavaClass javaClass = new JavaClassImpl(psiClass);
return javaClass.getOriginKind() == JavaClass.OriginKind.COMPILED && javaClass.findAnnotation(KOTLIN_PACKAGE) != null;
}
public static boolean isCompiledKotlinClassOrPackageClass(@NotNull PsiClass psiClass) {
return isCompiledKotlinClass(psiClass) || isCompiledKotlinPackageClass(psiClass);
}
/**
* @see com.intellij.psi.util.TypeConversionUtil#erasure(com.intellij.psi.PsiType)
*/
@@ -18,9 +18,7 @@ package org.jetbrains.jet.plugin;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.util.Iconable;
import com.intellij.psi.PsiClass;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiMember;
import com.intellij.ui.RowIcon;
import com.intellij.util.PlatformIcons;
import org.jetbrains.annotations.NotNull;
@@ -28,7 +26,6 @@ import org.jetbrains.annotations.Nullable;
import org.jetbrains.jet.lang.descriptors.*;
import org.jetbrains.jet.lang.descriptors.impl.LocalVariableDescriptor;
import org.jetbrains.jet.lang.psi.JetElement;
import org.jetbrains.jet.lang.resolve.java.JavaResolverUtils;
import javax.swing.*;
@@ -41,7 +38,7 @@ public final class JetDescriptorIconProvider {
@NotNull
public static Icon getIcon(@NotNull DeclarationDescriptor descriptor, @Nullable PsiElement declaration, @Iconable.IconFlags int flags) {
if (declaration != null && !isKotlinDeclaration(declaration)) {
if (declaration != null && !(declaration instanceof JetElement)) {
return declaration.getIcon(flags);
}
@@ -142,20 +139,4 @@ public final class JetDescriptorIconProvider {
LOG.warn("No icon for descriptor: " + descriptor);
return null;
}
private static boolean isKotlinDeclaration(@NotNull PsiElement declaration) {
if (declaration instanceof JetElement) {
return true;
}
else if (declaration instanceof PsiClass) {
return JavaResolverUtils.isCompiledKotlinClassOrPackageClass((PsiClass) declaration);
}
else if (declaration instanceof PsiMember) {
PsiClass containingClass = ((PsiMember) declaration).getContainingClass();
return containingClass != null && JavaResolverUtils.isCompiledKotlinClassOrPackageClass(containingClass);
}
else {
return false;
}
}
}
@@ -135,8 +135,7 @@ public class LookupElementFactory(
): LookupElement {
if (descriptor is ClassifierDescriptor &&
declaration is PsiClass &&
declaration !is KotlinLightClass &&
!JavaResolverUtils.isCompiledKotlinClass(declaration)) {
declaration !is KotlinLightClass) {
// for java classes we create special lookup elements
// because they must be equal to ones created in TypesCompletion
// otherwise we may have duplicates