azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

KTIJ-27841 [AA] Introduce intermediate ElementsToShortenCollector.importBreaksExistingReferences

Browse Source 
This clarifies the semantics a little bit
This commit is contained in:
Roman Golyshev
2024-01-10 21:05:47 +01:00
committed by teamcity
parent 702be98927
commit 0e244b3fbf
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/components/KtFirReferenceShortener.kt
+12 -1
View File
@@ -822,7 +822,7 @@ private class ElementsToShortenCollector(
if (option == ShortenStrategy.SHORTEN_IF_ALREADY_IMPORTED) return null
val importAllInParent = option == ShortenStrategy.SHORTEN_AND_STAR_IMPORT
if (importAffectsUsagesOfClassesWithSameName(qualifierClassId, qualifierElement.containingKtFile, importAllInParent)) return null
if (importBreaksExistingReferences(qualifierClassId, qualifierElement.containingKtFile, importAllInParent)) return null
// Find class with the same name that's already available in this file.
val availableClassifier = shorteningContext.findFirstClassifierInScopesByName(positionScopes, qualifierClassId.shortClassName)
@@ -918,6 +918,17 @@ private class ElementsToShortenCollector(
}
}
/**
* Returns `true` if adding [classToImport] import to the [file] might alter or break the
* resolve of existing references in the file.
*
* N.B.: At the moment it might have both false positives and false negatives, since it does not
* check all possible references.
*/
private fun importBreaksExistingReferences(classToImport: ClassId, file: KtFile, importAllInParent: Boolean): Boolean {
return importAffectsUsagesOfClassesWithSameName(classToImport, file, importAllInParent)
}
private fun importedClassifierOverwritesAvailableClassifier(
availableClassifier: AvailableSymbol<FirClassifierSymbol<*>>,
importAllInParent: Boolean