Search implementations for properties from constructor parameters

compiler/jet.as.java.psi/src/org/jetbrains/jet/asJava/LightClassUtil.java

@@ -133,27 +133,11 @@ public class LightClassUtil {
         PsiMethod getterWrapper = getter != null ? getLightClassAccessorMethod(getter) : null;
         PsiMethod setterWrapper = setter != null ? getLightClassAccessorMethod(setter) : null;
 
-        if (getterWrapper == null || setterWrapper == null) {
-            List<PsiMethod> wrappers = getPsiMethodWrappers(property, true);
-            assert wrappers.size() <= 2 : "Maximum two wrappers are expected to be generated for property";
+        return extractPropertyAccessors(property, getterWrapper, setterWrapper);
+    }
 
-            for (PsiMethod wrapper : wrappers) {
-                if (wrapper.getName().startsWith(JvmAbi.SETTER_PREFIX)) {
-                    assert setterWrapper == null : String.format(
-                            "Setter accessor isn't expected to be reassigned (old: %s, new: %s)", setterWrapper, wrapper);
-
-                    setterWrapper = wrapper;
-                }
-                else {
-                    assert getterWrapper == null : String.format(
-                            "Getter accessor isn't expected to be reassigned (old: %s, new: %s)", getterWrapper, wrapper);
-
-                    getterWrapper = wrapper;
-                }
-            }
-        }
-
-        return new PropertyAccessorsPsiMethods(getterWrapper, setterWrapper);
+    public static PropertyAccessorsPsiMethods getLightClassPropertyMethods(@NotNull JetParameter parameter) {
+        return extractPropertyAccessors(parameter, null, null);
     }
 
     @Nullable
@@ -212,6 +196,10 @@ public class LightClassUtil {
 
     @Nullable
     private static PsiClass getWrappingClass(@NotNull JetDeclaration declaration) {
+        if (declaration instanceof JetParameter && declaration.getParent().getParent() instanceof JetClass) {
+            return getPsiClass((JetClassOrObject) declaration.getParent().getParent());
+        }
+
         if (declaration instanceof JetPropertyAccessor) {
             PsiElement propertyParent = declaration.getParent();
             assert propertyParent instanceof JetProperty : "JetProperty is expected to be parent of accessor";
@@ -246,6 +234,38 @@ public class LightClassUtil {
         return null;
     }
 
+    private static PropertyAccessorsPsiMethods extractPropertyAccessors(
+            @NotNull JetDeclaration jetDeclaration,
+            @Nullable PsiMethod specialGetter, @Nullable PsiMethod specialSetter)
+    {
+        PsiMethod getterWrapper = specialGetter;
+        PsiMethod setterWrapper = specialSetter;
+
+        if (getterWrapper == null || setterWrapper == null) {
+            // If some getter or setter isn't found yet try to get it from wrappers for general declaration
+
+            List<PsiMethod> wrappers = getPsiMethodWrappers(jetDeclaration, true);
+            assert wrappers.size() <= 2 : "Maximum two wrappers are expected to be generated for declaration: " + jetDeclaration.getText();
+
+            for (PsiMethod wrapper : wrappers) {
+                if (wrapper.getName().startsWith(JvmAbi.SETTER_PREFIX)) {
+                    assert setterWrapper == null : String.format(
+                            "Setter accessor isn't expected to be reassigned (old: %s, new: %s)", setterWrapper, wrapper);
+
+                    setterWrapper = wrapper;
+                }
+                else {
+                    assert getterWrapper == null : String.format(
+                            "Getter accessor isn't expected to be reassigned (old: %s, new: %s)", getterWrapper, wrapper);
+
+                    getterWrapper = wrapper;
+                }
+            }
+        }
+
+        return new PropertyAccessorsPsiMethods(getterWrapper, setterWrapper);
+    }
+
     public static class PropertyAccessorsPsiMethods implements Iterable<PsiMethod> {
         private final PsiMethod getter;
         private final PsiMethod setter;

idea/src/org/jetbrains/jet/plugin/search/KotlinDefinitionsSearcher.java

@@ -29,10 +29,7 @@ import com.intellij.util.Processor;
 import com.intellij.util.containers.ContainerUtil;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.jet.asJava.LightClassUtil;
-import org.jetbrains.jet.lang.psi.JetClass;
-import org.jetbrains.jet.lang.psi.JetNamedFunction;
-import org.jetbrains.jet.lang.psi.JetProperty;
-import org.jetbrains.jet.lang.psi.JetPropertyAccessor;
+import org.jetbrains.jet.lang.psi.*;
 
 public class KotlinDefinitionsSearcher extends QueryExecutorBase<PsiElement, PsiElement> {
     @Override
@@ -48,6 +45,13 @@ public class KotlinDefinitionsSearcher extends QueryExecutorBase<PsiElement, Psi
         if (queryParameters instanceof JetProperty) {
             processPropertyImplementations((JetProperty) queryParameters, consumer);
         }
+
+        if (queryParameters instanceof JetParameter) {
+            JetParameter parameter = (JetParameter) queryParameters;
+            if (parameter.getValOrVarNode() != null && queryParameters.getParent().getParent() instanceof JetClass) {
+                processPropertyImplementations(parameter, consumer);
+            }
+        }
     }
 
     private static void processClassImplementations(final JetClass queryParameters, Processor<PsiElement> consumer) {
@@ -75,6 +79,18 @@ public class KotlinDefinitionsSearcher extends QueryExecutorBase<PsiElement, Psi
         }
     }
 
+    private static void processPropertyImplementations(@NotNull final JetParameter parameter, @NotNull Processor<PsiElement> consumer) {
+        LightClassUtil.PropertyAccessorsPsiMethods accessorsPsiMethods = ApplicationManager.getApplication().runReadAction(
+                new Computable<LightClassUtil.PropertyAccessorsPsiMethods>() {
+                    @Override
+                    public LightClassUtil.PropertyAccessorsPsiMethods compute() {
+                        return LightClassUtil.getLightClassPropertyMethods(parameter);
+                    }
+                });
+
+        processPropertyImplementationsMethods(accessorsPsiMethods, consumer);
+    }
+
     private static void processPropertyImplementations(@NotNull final JetProperty property, @NotNull Processor<PsiElement> consumer) {
         LightClassUtil.PropertyAccessorsPsiMethods accessorsPsiMethods = ApplicationManager.getApplication().runReadAction(
                 new Computable<LightClassUtil.PropertyAccessorsPsiMethods>() {
@@ -84,11 +100,15 @@ public class KotlinDefinitionsSearcher extends QueryExecutorBase<PsiElement, Psi
                     }
                 });
 
-        for (PsiMethod method : accessorsPsiMethods) {
+        processPropertyImplementationsMethods(accessorsPsiMethods, consumer);
+    }
+
+    private static void processPropertyImplementationsMethods(LightClassUtil.PropertyAccessorsPsiMethods accessors, @NotNull Processor<PsiElement> consumer) {
+        for (PsiMethod method : accessors) {
             PsiMethod[] implementations = MethodImplementationsSearch.getMethodImplementations(method);
             for (PsiMethod implementation : implementations) {
                 PsiElement mirrorElement = implementation instanceof PsiCompiledElement ? ((PsiCompiledElement) implementation).getMirror() : null;
-                if (mirrorElement instanceof JetProperty) {
+                if (mirrorElement instanceof JetProperty || mirrorElement instanceof JetParameter) {
                     consumer.process(mirrorElement);
                 }
                 else if (mirrorElement instanceof JetPropertyAccessor && mirrorElement.getParent() instanceof JetProperty) {

idea/testData/javaFacade/wrapConstructorField.kt

@@ -0,0 +1 @@
+class Test(var <caret>field: Int)

idea/testData/javaFacade/wrapConstructorParameter.kt

@@ -0,0 +1 @@
+class Test(var field: Int, <caret>parameter: Int)

idea/testData/javaFacade/wrapFunctionParameter.kt

@@ -0,0 +1 @@
+fun testFun(<caret>parameter: Int) = 0

idea/tests/org/jetbrains/jet/plugin/javaFacade/JetJavaFacadeTest.java

@@ -122,6 +122,18 @@ public class JetJavaFacadeTest extends LightCodeInsightFixtureTestCase {
         doTestWrapPropertyAccessor(true);
     }
 
+    public void testWrapConstructorField() {
+        doTestWrapParameter(true, true);
+    }
+
+    public void testWrapConstructorParameter() {
+        doTestWrapParameter(false, false);
+    }
+
+    public void testWrapFunctionParameter() {
+        doTestWrapParameter(false, false);
+    }
+
     public void testEa38770() {
         myFixture.configureByFile(getTestName(true) + ".kt");
 
@@ -197,6 +209,16 @@ public class JetJavaFacadeTest extends LightCodeInsightFixtureTestCase {
         checkDeclarationMethodWrapped(shouldBeWrapped, jetFunction, psiMethod);
     }
 
+    private void doTestWrapParameter(boolean shouldWrapGetter, boolean shouldWrapSetter) {
+        JetParameter jetParameter = getPreparedElement(JetParameter.class);
+
+        // Should not fail!
+        LightClassUtil.PropertyAccessorsPsiMethods propertyAccessors = LightClassUtil.getLightClassPropertyMethods(jetParameter);
+
+        checkDeclarationMethodWrapped(shouldWrapGetter, jetParameter, propertyAccessors.getGetter());
+        checkDeclarationMethodWrapped(shouldWrapSetter, jetParameter, propertyAccessors.getSetter());
+    }
+
     private void doTestWrapProperty(boolean shouldWrapGetter, boolean shouldWrapSetter) {
         JetProperty jetProperty = getPreparedElement(JetProperty.class);