[mpp] Migrate checks of commonMain.dependsOn to the new infra

libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/diagnostics/KotlinToolingDiagnostics.kt

@@ -23,4 +23,8 @@ object KotlinToolingDiagnostics {
             "The following deprecated Kotlin/Native targets were used in the project: ${usedTargetIds.joinToString()}"
         )
     }
+
+    object CommonMainWithDependsOnDiagnostic : ToolingDiagnosticFactory(WARNING) {
+        operator fun invoke() = build("commonMain can't declare dependsOn on other source sets")
+    }
 }

libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/diagnostics/checkers/CommonMainWithDependsOnChecker.kt

@@ -0,0 +1,25 @@
+/*
+ * Copyright 2010-2023 JetBrains s.r.o. and Kotlin Programming Language contributors.
+ * Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
+ */
+
+package org.jetbrains.kotlin.gradle.plugin.diagnostics.checkers
+
+import org.jetbrains.kotlin.gradle.plugin.KotlinSourceSet
+import org.jetbrains.kotlin.gradle.plugin.diagnostics.KotlinToolingDiagnostics
+import org.jetbrains.kotlin.gradle.plugin.diagnostics.KotlinToolingDiagnosticsCollector
+import org.jetbrains.kotlin.gradle.plugin.diagnostics.KotlinGradleProjectChecker
+import org.jetbrains.kotlin.gradle.plugin.diagnostics.KotlinGradleProjectCheckerContext
+import org.jetbrains.kotlin.gradle.plugin.sources.internal
+
+internal object CommonMainWithDependsOnChecker : KotlinGradleProjectChecker {
+    override fun KotlinGradleProjectCheckerContext.runChecks(collector: KotlinToolingDiagnosticsCollector) {
+        multiplatformExtension?.sourceSets?.all {
+            if (it.name == KotlinSourceSet.COMMON_MAIN_SOURCE_SET_NAME) {
+                it.internal.dependsOn.forAll {
+                    collector.reportOncePerGradleProject(project, KotlinToolingDiagnostics.CommonMainWithDependsOnDiagnostic())
+                }
+            }
+        }
+    }
+}