azalea/sagemcom
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduce duplicate code

Browse Source 
Clean up DNS interface logic
This commit is contained in:
up-n-atom
2023-08-17 18:08:29 -04:00
committed by GitHub
parent d97f9c4ce2
commit c2f77297f0
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xmo-cli.py
+6 -9
View File
@@ -95,16 +95,13 @@ async def set_dns_servers(client: SagemcomClient, dns_servers: tuple[IPv4Address
for i, dns_server in enumerate(dns_servers, start=1): for i, dns_server in enumerate(dns_servers, start=1):
try: try:
await client.set_value_by_xpath(f"Device/DNS/Relay/Forwardings/Forwarding[@uid={i}]/DNSServer", dns_server) await client.set_value_by_xpath(f"Device/DNS/Relay/Forwardings/Forwarding[@uid={i}]/DNSServer", dns_server)
iface = 'Device/IP/Interfaces/Interface[IP_DATA]'
if dns_server.is_private: if dns_server.is_private:
await client.set_value_by_xpath( iface = 'Device/IP/Interfaces/Interface[IP_BR_LAN]
f"Device/DNS/Relay/Forwardings/Forwarding[@uid={i}]/Interface", await client.set_value_by_xpath(
'Device/IP/Interfaces/Interface[IP_BR_LAN]' f"Device/DNS/Relay/Forwardings/Forwarding[@uid={i}]/Interface",
) iface
elif dns_server.is_global: )
await client.set_value_by_xpath(
f"Device/DNS/Relay/Forwardings/Forwarding[@uid={i}]/Interface",
'Device/IP/Interfaces/Interface[IP_DATA]'
)
except Exception as e: except Exception as e:
click.echo(e, err=True) click.echo(e, err=True)
break break