72def186a3
The change is needed for the parallel resolution (^KT-55750), so we can resolve the declaration under a lock that is specific to this declaration. Previously, if LL FIR was resolving some FirClass, LL FIR resolved all its children too, and it had no control over what parts of the FIR tree were modified. The same applied to the designation path, sometimes the classes on the designation path might be unexpectedly (and without lock) modified. This commit introduces LLFirResolveTarget, which specifies which exact declarations should be resolved during the lazy resolution of the declaration. All elements outside the declarations specified for resolve in LLFirResolveTarget, should not be modified. The logic of lazy transformers is the following: - Go to target declaration collecting all scopes from the file and containing classes - Resolve only declarations that are specified by the LLFirResolveTarget, performing the resolve under a separate lock for each declaration ^KT-56543 ^KT-57619 Fixed
364 lines
6.1 KiB
Kotlin
Vendored
364 lines
6.1 KiB
Kotlin
Vendored
package uninitialized_reassigned_variables
|
|
|
|
fun doSmth(<!UNUSED_PARAMETER!>s<!>: String) {}
|
|
fun doSmth(<!UNUSED_PARAMETER!>i<!>: Int) {}
|
|
|
|
// ------------------------------------------------
|
|
// uninitialized variables
|
|
|
|
fun t1(b : Boolean) {
|
|
val v : Int
|
|
if (<!UNINITIALIZED_VARIABLE!>v<!> == 0) {}
|
|
|
|
var u: String
|
|
if (b) {
|
|
u = "s"
|
|
}
|
|
doSmth(<!UNINITIALIZED_VARIABLE!>u<!>)
|
|
|
|
var r: String
|
|
if (b) {
|
|
r = "s"
|
|
}
|
|
else {
|
|
r = "tg"
|
|
}
|
|
doSmth(r)
|
|
|
|
var t: String
|
|
if (b)
|
|
doSmth(<!UNINITIALIZED_VARIABLE!>t<!>)
|
|
else
|
|
t = "ss"
|
|
doSmth(t) //repeat for t
|
|
|
|
val i = 3
|
|
doSmth(i)
|
|
if (b) {
|
|
return;
|
|
}
|
|
doSmth(i)
|
|
if (<!USELESS_IS_CHECK!>i is Int<!>) {
|
|
return;
|
|
}
|
|
}
|
|
|
|
fun t2() {
|
|
val s = "ss"
|
|
|
|
for (i in 0..2) {
|
|
doSmth(s)
|
|
}
|
|
}
|
|
|
|
class A() {}
|
|
|
|
fun t4(<!UNUSED_PARAMETER!>a<!>: A) {
|
|
<!UNUSED_VALUE!><!VAL_REASSIGNMENT!>a<!> =<!> A()
|
|
}
|
|
|
|
// ------------------------------------------------
|
|
// reassigned vals
|
|
|
|
fun t1() {
|
|
val <!UNUSED_VARIABLE!>a<!> : Int = 1
|
|
<!UNUSED_VALUE!><!VAL_REASSIGNMENT!>a<!> =<!> 2
|
|
|
|
var <!ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE!>b<!> : Int = 1
|
|
<!UNUSED_VALUE!>b =<!> 3
|
|
}
|
|
|
|
enum class ProtocolState {
|
|
WAITING {
|
|
override fun signal() = ProtocolState.TALKING
|
|
},
|
|
|
|
TALKING {
|
|
override fun signal() = ProtocolState.WAITING
|
|
};
|
|
|
|
abstract fun signal() : ProtocolState
|
|
}
|
|
|
|
fun t3() {
|
|
val x: ProtocolState = ProtocolState.WAITING
|
|
<!VAL_REASSIGNMENT!>x<!> = x.signal()
|
|
x = x.signal() //repeat for x
|
|
}
|
|
|
|
fun t4() {
|
|
val x = 1
|
|
<!VAL_REASSIGNMENT!>x<!> += 2
|
|
val y = 3
|
|
<!VAL_REASSIGNMENT!>y<!> *= 4
|
|
var z = 5
|
|
z -= y
|
|
}
|
|
|
|
fun t5() {
|
|
for (i in 0..2) {
|
|
<!VAL_REASSIGNMENT!>i<!> += 1
|
|
fun t5() {
|
|
i += 3
|
|
}
|
|
}
|
|
}
|
|
|
|
fun t6() {
|
|
val i = 0
|
|
fun t5() {
|
|
<!VAL_REASSIGNMENT!>i<!> += 3
|
|
}
|
|
}
|
|
|
|
fun t7() {
|
|
for (i in 0..2) {
|
|
fun t5() {
|
|
<!VAL_REASSIGNMENT!>i<!> = 3
|
|
}
|
|
}
|
|
}
|
|
|
|
// ------------------------------------------------
|
|
// backing fields
|
|
|
|
var x = 10
|
|
val y = 10
|
|
val z = 10
|
|
|
|
class AnonymousInitializers(var a: String, val b: String) {
|
|
init {
|
|
a = "30"
|
|
a = "s"
|
|
|
|
<!VAL_REASSIGNMENT!>b<!> = "3"
|
|
b = "tt" //repeat for b
|
|
}
|
|
|
|
val i: Int
|
|
init {
|
|
i = 121
|
|
}
|
|
|
|
init {
|
|
x = 11
|
|
<!VAL_REASSIGNMENT!>z<!> = 10
|
|
}
|
|
|
|
val j: Int
|
|
get() = 20
|
|
|
|
init {
|
|
<!VAL_REASSIGNMENT!>i<!> = 13
|
|
<!VAL_REASSIGNMENT!>j<!> = 34
|
|
}
|
|
|
|
val k: String
|
|
init {
|
|
if (1 < 3) {
|
|
k = "a"
|
|
}
|
|
else {
|
|
k = "b"
|
|
}
|
|
}
|
|
|
|
val l: String
|
|
init {
|
|
if (1 < 3) {
|
|
l = "a"
|
|
}
|
|
else {
|
|
l = "b"
|
|
}
|
|
}
|
|
|
|
<!MUST_BE_INITIALIZED_OR_BE_ABSTRACT!>val o: String<!>
|
|
init {
|
|
if (1 < 3) {
|
|
o = "a"
|
|
}
|
|
}
|
|
|
|
var m: Int = 30
|
|
|
|
init {
|
|
m = 400
|
|
}
|
|
|
|
val n: Int
|
|
|
|
init {
|
|
while (<!UNINITIALIZED_VARIABLE!>n<!> == 0) {
|
|
}
|
|
n = 10
|
|
while (n == 0) {
|
|
}
|
|
}
|
|
|
|
var p = 1
|
|
init {
|
|
p++
|
|
}
|
|
}
|
|
|
|
fun reassignFunParams(<!UNUSED_PARAMETER!>a<!>: Int) {
|
|
<!UNUSED_VALUE!><!VAL_REASSIGNMENT!>a<!> =<!> 1
|
|
}
|
|
|
|
open class Open(<!UNUSED_PARAMETER!>a<!>: Int, <!UNUSED_PARAMETER!>w<!>: Int) {}
|
|
|
|
class LocalValsVsProperties(val a: Int, w: Int) : Open(a, w) {
|
|
val x : Int
|
|
<!MUST_BE_INITIALIZED_OR_BE_ABSTRACT!>val y : Int<!>
|
|
init {
|
|
x = 1
|
|
val <!UNUSED_VARIABLE!>b<!> = x
|
|
}
|
|
val b = a
|
|
|
|
fun foo() {
|
|
val r : Int
|
|
doSmth(x)
|
|
doSmth(y)
|
|
doSmth(<!UNINITIALIZED_VARIABLE!>r<!>)
|
|
doSmth(a)
|
|
}
|
|
var xx = w
|
|
var yy : Int
|
|
init {
|
|
<!VAL_REASSIGNMENT!>w<!> += 1
|
|
yy = w
|
|
}
|
|
}
|
|
|
|
class Outer() {
|
|
val a : Int
|
|
var b : Int
|
|
|
|
init {
|
|
a = 1
|
|
b = 1
|
|
}
|
|
|
|
inner class Inner() {
|
|
init {
|
|
<!VAL_REASSIGNMENT!>a<!>++
|
|
b++
|
|
}
|
|
}
|
|
|
|
fun foo() {
|
|
<!VAL_REASSIGNMENT!>a<!>++
|
|
b++
|
|
}
|
|
}
|
|
|
|
class ForwardAccessToBackingField() { //kt-147
|
|
val a = <!DEBUG_INFO_MISSING_UNRESOLVED, TYPECHECKER_HAS_RUN_INTO_RECURSIVE_PROBLEM_ERROR!>a<!> // error
|
|
val b = <!UNINITIALIZED_VARIABLE!>c<!> // error
|
|
val c = 1
|
|
}
|
|
|
|
class ClassObject() {
|
|
companion object {
|
|
val x : Int
|
|
|
|
init {
|
|
x = 1
|
|
}
|
|
|
|
|
|
fun foo() {
|
|
val a : Int
|
|
doSmth(<!UNINITIALIZED_VARIABLE!>a<!>)
|
|
}
|
|
}
|
|
}
|
|
|
|
fun foo() {
|
|
val <!UNUSED_VARIABLE!>a<!> = object {
|
|
val x : Int
|
|
<!MUST_BE_INITIALIZED_OR_BE_ABSTRACT!>val y : Int<!>
|
|
val z : Int
|
|
init {
|
|
x = 1
|
|
z = 3
|
|
}
|
|
fun foo() {
|
|
y = 10
|
|
<!VAL_REASSIGNMENT!>z<!> = 13
|
|
}
|
|
}
|
|
}
|
|
|
|
class TestObjectExpression() {
|
|
<!MUST_BE_INITIALIZED_OR_BE_ABSTRACT!>val a : Int<!>
|
|
fun foo() {
|
|
val <!UNUSED_VARIABLE!>a<!> = object {
|
|
val x : Int
|
|
<!MUST_BE_INITIALIZED_OR_BE_ABSTRACT!>val y : Int<!>
|
|
init {
|
|
if (true)
|
|
x = 12
|
|
else
|
|
x = 1
|
|
}
|
|
fun inner1() {
|
|
y = 101
|
|
<!VAL_REASSIGNMENT!>a<!> = 231
|
|
}
|
|
fun inner2() {
|
|
y = 101
|
|
a = 231
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
|
|
object TestObjectDeclaration {
|
|
val x : Int
|
|
<!MUST_BE_INITIALIZED_OR_BE_ABSTRACT!>val y : Int<!>
|
|
init {
|
|
x = 1
|
|
}
|
|
|
|
fun foo() {
|
|
<!VAL_REASSIGNMENT!>y<!> = 10
|
|
val i: Int
|
|
if (1 < 3) {
|
|
i = 10
|
|
}
|
|
doSmth(<!UNINITIALIZED_VARIABLE!>i<!>)
|
|
}
|
|
}
|
|
|
|
fun func() {
|
|
val b = 1
|
|
val <!UNUSED_VARIABLE!>a<!> = object {
|
|
val x = b
|
|
init {
|
|
<!VAL_REASSIGNMENT!>b<!> = 4
|
|
}
|
|
}
|
|
}
|
|
|
|
// ------------------------------------------------
|
|
// dot qualifiers
|
|
class M() {
|
|
val x = 11
|
|
var y = 12
|
|
}
|
|
|
|
fun test(m : M) {
|
|
<!VAL_REASSIGNMENT!>m.x<!> = 23
|
|
m.y = 23
|
|
}
|
|
|
|
fun test1(m : M) {
|
|
<!VAL_REASSIGNMENT!>m.x<!>++
|
|
m.y--
|
|
}
|