Tianyu Geng
c7272f6986
Currently DFA does not set "definitely equal to null" for access to variables that got assigned `null`. For example, FIR should mark the following line as SENSELESS_COMPARISON due to `s = null` above. https://github.com/JetBrains/kotlin/blob/d1531f9cdd5852352c0133198706125dc63b6007/compiler/testData/diagnostics/tests/smartCasts/alwaysNull.fir.kt#L6 The problem is at https://github.com/JetBrains/kotlin/blob/7e9f27436a77de1c76e3705da7aa1fbe8938336b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/dfa/FirDataFlowAnalyzer.kt#L1104 For null assignment, ideally the type should be `Nothing?`. This is addressed in a followup commit instead.
31 lines
685 B
Kotlin
Vendored
31 lines
685 B
Kotlin
Vendored
// FIR_IDENTICAL
|
|
// FILE: KotlinFile.kt
|
|
abstract class KotlinClass : JavaInterface3 {
|
|
override fun getSomething(): String = ""
|
|
}
|
|
|
|
fun foo(k: KotlinClass) {
|
|
useString(k.getSomething())
|
|
useString(k.something)
|
|
if (<!SENSELESS_COMPARISON!>k.something == null<!>) return
|
|
|
|
k.setSomething("")
|
|
k.something = ""
|
|
}
|
|
|
|
fun useString(i: String) {}
|
|
|
|
// FILE: JavaInterface1.java
|
|
public interface JavaInterface1 {
|
|
String getSomething();
|
|
}
|
|
|
|
// FILE: JavaInterface2.java
|
|
public interface JavaInterface2 {
|
|
String getSomething();
|
|
void setSomething(String value);
|
|
}
|
|
|
|
// FILE: JavaInterface3.java
|
|
public interface JavaInterface3 extends JavaInterface1, JavaInterface2 {}
|