Tianyu Geng
c7272f6986
Currently DFA does not set "definitely equal to null" for access to variables that got assigned `null`. For example, FIR should mark the following line as SENSELESS_COMPARISON due to `s = null` above. https://github.com/JetBrains/kotlin/blob/d1531f9cdd5852352c0133198706125dc63b6007/compiler/testData/diagnostics/tests/smartCasts/alwaysNull.fir.kt#L6 The problem is at https://github.com/JetBrains/kotlin/blob/7e9f27436a77de1c76e3705da7aa1fbe8938336b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/dfa/FirDataFlowAnalyzer.kt#L1104 For null assignment, ideally the type should be `Nothing?`. This is addressed in a followup commit instead.
32 lines
910 B
Kotlin
Vendored
32 lines
910 B
Kotlin
Vendored
// !DIAGNOSTICS: -DEBUG_INFO_SMARTCAST
|
|
fun bar(x: Int) = x + 1
|
|
|
|
fun foo() {
|
|
val x: Int? = null
|
|
|
|
if (x != null) {
|
|
bar(x)
|
|
if (<!SENSELESS_COMPARISON!>x != null<!>) {
|
|
bar(x)
|
|
if (1 < 2) bar(x)
|
|
if (1 > 2) bar(x)
|
|
}
|
|
if (<!SENSELESS_COMPARISON!>x == null<!>) {
|
|
bar(x)
|
|
}
|
|
if (<!SENSELESS_COMPARISON!>x == null<!>) bar(x) else bar(x)
|
|
bar(bar(x))
|
|
} else if (<!SENSELESS_COMPARISON!>x == null<!>) {
|
|
bar(<!ARGUMENT_TYPE_MISMATCH!>x<!>)
|
|
if (<!SENSELESS_COMPARISON!>x != null<!>) {
|
|
bar(x)
|
|
if (<!SENSELESS_COMPARISON!>x == null<!>) bar(x)
|
|
if (<!SENSELESS_COMPARISON!>x == null<!>) bar(x) else bar(x)
|
|
bar(bar(x) + bar(x))
|
|
} else if (<!SENSELESS_COMPARISON!>x == null<!>) {
|
|
bar(<!ARGUMENT_TYPE_MISMATCH!>x<!>)
|
|
}
|
|
}
|
|
|
|
}
|