Brian Norman
0e2b3ce845
Entering a `finally` block can happen from many different places:
through an exception, a jump, or normal exit from the `try` block. When
in the `finally` block, all DFA flows must be merged to have correct
smart casting. However, after the `finally` block, if exiting normally
or because of a jump, the combined flow from within the `finally` block
should not be used, but rather an alternate flow which combines the
correct flows from before the `finally` block.
```
try {
str as String // Potential cast exception
} finally {
str.length // Shouldn`t be resolved
}
str.length // Should be resolved
```
When building DFA flows, track the start of possible alternate flows,
and continue building them until they end. Both of these situations are
now marked on CFGNodes via interfaces.
When building the default DFA flow, and the source node is the end node
of alternate flows, attempt to use the alternate flow with the same edge
label instead of the default flow of the source node.
#KT-56888 Fixed
106 lines
2.1 KiB
Kotlin
Vendored
106 lines
2.1 KiB
Kotlin
Vendored
// !DIAGNOSTICS: -UNUSED_VARIABLE -UNUSED_VALUE -VARIABLE_WITH_REDUNDANT_INITIALIZER
|
|
// SKIP_TXT
|
|
// Related issue: KT-28370
|
|
|
|
class ExcA : Exception()
|
|
class ExcB : Exception()
|
|
|
|
fun test1() {
|
|
var x: String? = null
|
|
x = ""
|
|
|
|
try {
|
|
x = null
|
|
} catch (e: Exception) {
|
|
x<!UNSAFE_CALL!>.<!>length // smartcast shouldn't be allowed (OOME could happen after `x = null`)
|
|
throw e
|
|
}
|
|
finally {
|
|
// smartcast shouldn't be allowed, `x = null` could've happened
|
|
x<!UNSAFE_CALL!>.<!>length
|
|
}
|
|
// smartcast shouldn't be allowed, `x = null` could've happened
|
|
x<!UNSAFE_CALL!>.<!>length
|
|
}
|
|
|
|
// With old DFA of try/catch info about unsound smartcasts after try
|
|
// removes only if there is at least one catch branch that not returns Nothing
|
|
fun test2() {
|
|
var x: String? = null
|
|
x = ""
|
|
|
|
try {
|
|
x = null
|
|
} catch (e: Exception) {
|
|
x<!UNSAFE_CALL!>.<!>length
|
|
}
|
|
finally {
|
|
x<!UNSAFE_CALL!>.<!>length
|
|
}
|
|
x<!UNSAFE_CALL!>.<!>length
|
|
}
|
|
|
|
fun test3() {
|
|
var t2: Boolean? = true
|
|
if (t2 != null) { // or `t2 is Boolean`
|
|
try {
|
|
throw Exception()
|
|
} catch (e: Exception) {
|
|
t2 = null
|
|
}
|
|
t2<!UNSAFE_CALL!>.<!>not() // wrong smartcast, NPE
|
|
}
|
|
}
|
|
|
|
fun test4() {
|
|
var t2: Boolean? = true
|
|
if (t2 != null) { // or `t2 is Boolean`
|
|
try {
|
|
t2 = null
|
|
} finally { }
|
|
t2<!UNSAFE_CALL!>.<!>not() // wrong smartcast, NPE
|
|
}
|
|
}
|
|
|
|
fun test5() {
|
|
var s1: String? = null
|
|
var s2: String? = null
|
|
s1 = ""
|
|
s2 = ""
|
|
try {
|
|
TODO()
|
|
}
|
|
catch (e: ExcA) {
|
|
s1 = ""
|
|
}
|
|
catch (e: ExcB) {
|
|
s2 = null
|
|
return
|
|
}
|
|
finally {
|
|
s1.length
|
|
s2<!UNSAFE_CALL!>.<!>length
|
|
}
|
|
s1.length
|
|
s2.length
|
|
}
|
|
|
|
fun test6(s1: String?, s2: String?) {
|
|
var s: String? = null
|
|
s = ""
|
|
try {
|
|
s = null
|
|
requireNotNull(s1)
|
|
}
|
|
catch (e: Exception) {
|
|
return
|
|
}
|
|
finally {
|
|
s<!UNSAFE_CALL!>.<!>length
|
|
requireNotNull(s2)
|
|
}
|
|
s<!UNSAFE_CALL!>.<!>length
|
|
s1.length
|
|
s2.length
|
|
}
|