Dmitrii Gridin
72def186a3
The change is needed for the parallel resolution (^KT-55750), so we can resolve the declaration under a lock that is specific to this declaration. Previously, if LL FIR was resolving some FirClass, LL FIR resolved all its children too, and it had no control over what parts of the FIR tree were modified. The same applied to the designation path, sometimes the classes on the designation path might be unexpectedly (and without lock) modified. This commit introduces LLFirResolveTarget, which specifies which exact declarations should be resolved during the lazy resolution of the declaration. All elements outside the declarations specified for resolve in LLFirResolveTarget, should not be modified. The logic of lazy transformers is the following: - Go to target declaration collecting all scopes from the file and containing classes - Resolve only declarations that are specified by the LLFirResolveTarget, performing the resolve under a separate lock for each declaration ^KT-56543 ^KT-57619 Fixed
53 lines
901 B
Kotlin
Vendored
53 lines
901 B
Kotlin
Vendored
//KT-2330 Check visibility of getters and setters correspondingly
|
|
package a
|
|
|
|
class P {
|
|
var x : Int = 0
|
|
private set
|
|
|
|
var y : Int = 0
|
|
|
|
val other = P();
|
|
|
|
init {
|
|
x = 23
|
|
other.x = 4
|
|
}
|
|
|
|
val testInGetter : Int
|
|
get() {
|
|
x = 33
|
|
return 3
|
|
}
|
|
}
|
|
|
|
fun foo() {
|
|
val p = P()
|
|
<!INVISIBLE_SETTER!>p.x<!> = 34 //should be an error here
|
|
p.y = 23
|
|
|
|
fun inner() {
|
|
<!INVISIBLE_SETTER!>p.x<!> = 44
|
|
}
|
|
}
|
|
|
|
class R {
|
|
val p = P();
|
|
init {
|
|
<!INVISIBLE_SETTER!>p.x<!> = 42
|
|
}
|
|
|
|
val testInGetterInOtherClass : Int
|
|
get() {
|
|
<!INVISIBLE_SETTER!>p.x<!> = 33
|
|
return 3
|
|
}
|
|
}
|
|
|
|
fun test() {
|
|
val <!UNUSED_VARIABLE!>o<!> = object {
|
|
fun run() {
|
|
<!UNRESOLVED_REFERENCE!>p<!>.<!DEBUG_INFO_MISSING_UNRESOLVED, VARIABLE_EXPECTED!>x<!> = 43
|
|
}
|
|
}
|
|
} |