72def186a3
The change is needed for the parallel resolution (^KT-55750), so we can resolve the declaration under a lock that is specific to this declaration. Previously, if LL FIR was resolving some FirClass, LL FIR resolved all its children too, and it had no control over what parts of the FIR tree were modified. The same applied to the designation path, sometimes the classes on the designation path might be unexpectedly (and without lock) modified. This commit introduces LLFirResolveTarget, which specifies which exact declarations should be resolved during the lazy resolution of the declaration. All elements outside the declarations specified for resolve in LLFirResolveTarget, should not be modified. The logic of lazy transformers is the following: - Go to target declaration collecting all scopes from the file and containing classes - Resolve only declarations that are specified by the LLFirResolveTarget, performing the resolve under a separate lock for each declaration ^KT-56543 ^KT-57619 Fixed
185 lines
4.1 KiB
Kotlin
Vendored
185 lines
4.1 KiB
Kotlin
Vendored
// !DUMP_CFG
|
|
// CONTAINS ERRORS
|
|
|
|
interface A {
|
|
fun foo()
|
|
fun getA(): A
|
|
}
|
|
|
|
interface MyData{
|
|
val s: Int
|
|
|
|
fun fs(): Int
|
|
}
|
|
|
|
interface Q {
|
|
val data: MyData?
|
|
|
|
fun fdata(): MyData?
|
|
}
|
|
|
|
class QImpl(override val data: MyData?) : Q {
|
|
override fun fdata(): MyData? = null
|
|
}
|
|
|
|
class QImplMutable(override var data: MyData?) : Q {
|
|
override fun fdata(): MyData? = null
|
|
}
|
|
|
|
class QImplWithCustomGetter : Q {
|
|
override val data: MyData?
|
|
get() = null
|
|
|
|
override fun fdata(): MyData? = null
|
|
}
|
|
|
|
// -------------------------------------------------------------------
|
|
|
|
fun test_1(x: A?) {
|
|
if (x != null) {
|
|
x.foo()
|
|
} else {
|
|
x<!UNSAFE_CALL!>.<!>foo()
|
|
}
|
|
x<!UNSAFE_CALL!>.<!>foo()
|
|
}
|
|
|
|
fun test_2(x: A?) {
|
|
if (x == null) {
|
|
x<!UNSAFE_CALL!>.<!>foo()
|
|
} else {
|
|
x.foo()
|
|
}
|
|
x<!UNSAFE_CALL!>.<!>foo()
|
|
}
|
|
|
|
fun test_3(x: A?) {
|
|
x ?: return
|
|
x.foo()
|
|
}
|
|
|
|
fun test_4(x: A?) {
|
|
if (x?.getA() == null) return
|
|
x.foo()
|
|
}
|
|
|
|
fun test_5(q: Q?) {
|
|
// `q.data` is a property that has an open getter, so we can NOT smartcast it to non-nullable MyData.
|
|
if (q?.data?.s?.inc() != null) {
|
|
q.data // good
|
|
<!SMARTCAST_IMPOSSIBLE!>q.data<!>.s // should be bad
|
|
<!SMARTCAST_IMPOSSIBLE!>q.data<!>.s.inc() // should be bad
|
|
}
|
|
}
|
|
|
|
fun test_6(q: Q?) {
|
|
// `q.data` is a property that has an open getter, so we can NOT smartcast it to non-nullable MyData.
|
|
q?.data?.s?.inc() ?: return
|
|
q.data // good
|
|
<!SMARTCAST_IMPOSSIBLE!>q.data<!>.s // should be bad
|
|
<!SMARTCAST_IMPOSSIBLE!>q.data<!>.s.inc() // should be bad
|
|
}
|
|
|
|
fun test_7(q: Q?) {
|
|
if (q?.fdata()?.fs()?.inc() != null) {
|
|
q.fdata() // good
|
|
q.fdata()<!UNSAFE_CALL!>.<!>fs() // bad
|
|
q.fdata()<!UNSAFE_CALL!>.<!>fs().inc() // bad
|
|
}
|
|
}
|
|
|
|
fun test_8(b: Boolean?) {
|
|
if (b == true) {
|
|
b.not()
|
|
}
|
|
}
|
|
|
|
fun test_9(a: Int, b: Int?) {
|
|
if (a == b) {
|
|
b.inc()
|
|
}
|
|
b<!UNSAFE_CALL!>.<!>inc()
|
|
|
|
if (<!IMPLICIT_BOXING_IN_IDENTITY_EQUALS!>a === b<!>) {
|
|
b.inc()
|
|
}
|
|
b<!UNSAFE_CALL!>.<!>inc()
|
|
|
|
if (b == a) {
|
|
b.inc()
|
|
}
|
|
b<!UNSAFE_CALL!>.<!>inc()
|
|
|
|
if (<!IMPLICIT_BOXING_IN_IDENTITY_EQUALS!>b === a<!>) {
|
|
b.inc()
|
|
}
|
|
b<!UNSAFE_CALL!>.<!>inc()
|
|
}
|
|
|
|
fun test_10(a: Int?, b: Int?) {
|
|
if (a == b) {
|
|
b<!UNSAFE_CALL!>.<!>inc()
|
|
}
|
|
b<!UNSAFE_CALL!>.<!>inc()
|
|
|
|
if (<!FORBIDDEN_IDENTITY_EQUALS_WARNING!>a === b<!>) {
|
|
b<!UNSAFE_CALL!>.<!>inc()
|
|
}
|
|
b<!UNSAFE_CALL!>.<!>inc()
|
|
|
|
if (b == a) {
|
|
b<!UNSAFE_CALL!>.<!>inc()
|
|
}
|
|
b<!UNSAFE_CALL!>.<!>inc()
|
|
|
|
if (<!FORBIDDEN_IDENTITY_EQUALS_WARNING!>b === a<!>) {
|
|
b<!UNSAFE_CALL!>.<!>inc()
|
|
}
|
|
b<!UNSAFE_CALL!>.<!>inc()
|
|
}
|
|
|
|
fun test_11(q: QImpl?, q2: QImpl) {
|
|
// `q.data` is a property with the default getter, so we CAN smartcast it to non-nullable MyData.
|
|
if (q?.data?.s?.inc() != null) {
|
|
q.data
|
|
q.data.s
|
|
q.data.s.inc()
|
|
|
|
// Smartcasting of `q.data` should have no effect on `q2.data`.
|
|
// Issue: Smartcasting of QImpl.data affects all instances
|
|
q2.data
|
|
q2.data<!UNSAFE_CALL!>.<!>s // should be bad
|
|
q2.data<!UNSAFE_CALL!>.<!>s.inc() // should be bad
|
|
|
|
if (q2.data != null) {
|
|
q2.data.s
|
|
q2.data.s.inc()
|
|
}
|
|
}
|
|
}
|
|
|
|
fun test_12(q: QImplWithCustomGetter?) {
|
|
// `q.data` is a property that has an open getter, so we can NOT smartcast it to non-nullable MyData.
|
|
if (q?.data?.s?.inc() != null) {
|
|
q.data // good
|
|
<!SMARTCAST_IMPOSSIBLE!>q.data<!>.s // should be bad
|
|
<!SMARTCAST_IMPOSSIBLE!>q.data<!>.s.inc() // should be bad
|
|
}
|
|
}
|
|
|
|
fun test_13(q: QImplMutable?) {
|
|
// `q.data` is a property that is mutable, so we can NOT smartcast it to non-nullable MyData.
|
|
if (q?.data?.s?.inc() != null) {
|
|
q.data // good
|
|
<!SMARTCAST_IMPOSSIBLE!>q.data<!>.s // should be bad
|
|
<!SMARTCAST_IMPOSSIBLE!>q.data<!>.s.inc() // should be bad
|
|
}
|
|
}
|
|
|
|
fun test_14(q: Q) {
|
|
// `q.data` is a property that has an open getter
|
|
if (q.data == null) {
|
|
q.data<!UNSAFE_CALL!>.<!>s // should be UNSAFE_CALL and NOT SMARTCAST_IMPOSSIBLE
|
|
}
|
|
}
|