7bb81ef157
Added checker for FirEqualityOperatorCall. It's surfaced as one of the following diagnostics depending on the PSI structure and types under comparison: * INCOMPATIBLE_TYPES(_WARNING) * EQUALITY_NOT_APPLICABLE(_WARNING) * INCOMPATIBLE_ENUM_COMPARISON_ERROR Comparing with FE1.0, the current implementation is more conservative and only highlights error if the types are known to follow certain contracts with `equals` method. Otherwise, the checker reports warnings instead. However, the current checker is more strict in the following situations: 1. it now rejects incompatible enum types like `Enum<E1>` and `Enum<E2>`, which was previously accepted 2. it now rejects incompatible class types like `Class<String>` and `Class<Int>`, which was previously accepted 3. the check now takes smart cast into consideration, so `if (x is String) x == 3` is now rejected
146 lines
3.1 KiB
Kotlin
Vendored
146 lines
3.1 KiB
Kotlin
Vendored
// !LANGUAGE: -ProhibitComparisonOfIncompatibleEnums
|
|
|
|
enum class E1 {
|
|
A, B
|
|
}
|
|
|
|
enum class E2 {
|
|
A, B
|
|
}
|
|
|
|
fun foo1(e1: E1, e2: E2) {
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>e1 == e2<!>
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>e1 != e2<!>
|
|
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>e1 == E2.A<!>
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>E1.B == e2<!>
|
|
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>E1.A == E2.B<!>
|
|
|
|
e1 == E1.A
|
|
E1.A == e1
|
|
e2 == E2.B
|
|
E2.B == e2
|
|
}
|
|
|
|
fun foo2(e1: E1, e2: E2) {
|
|
when (e1) {
|
|
E1.A -> {}
|
|
<!INCOMPATIBLE_TYPES_WARNING!>E2.A<!> -> {}
|
|
<!INCOMPATIBLE_TYPES_WARNING!>E2.B<!> -> {}
|
|
e1 -> {}
|
|
<!INCOMPATIBLE_TYPES_WARNING!>e2<!> -> {}
|
|
else -> {}
|
|
}
|
|
}
|
|
|
|
fun foo3(e1: Enum<E1>, e2: Enum<E2>, e: Enum<*>) {
|
|
e1 == e
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>e1 == e2<!>
|
|
|
|
e1 == E1.A
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>e1 == E2.A<!>
|
|
|
|
when (e1) {
|
|
e1 -> {}
|
|
<!INCOMPATIBLE_TYPES_WARNING!>e2<!> -> {}
|
|
e -> {}
|
|
E1.A -> {}
|
|
<!INCOMPATIBLE_TYPES_WARNING!>E2.A<!> -> {}
|
|
else -> {}
|
|
}
|
|
|
|
when (e) {
|
|
e -> {}
|
|
e2 -> {}
|
|
E1.A -> {}
|
|
E2.A -> {}
|
|
else -> {}
|
|
}
|
|
}
|
|
|
|
interface MyInterface
|
|
open class MyOpenClass
|
|
|
|
fun foo4(e1: E1, i: MyInterface, c: MyOpenClass) {
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>e1 == i<!>
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>i == e1<!>
|
|
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>e1 == c<!>
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>c == e1<!>
|
|
|
|
when (e1) {
|
|
<!INCOMPATIBLE_TYPES_WARNING!>i<!> -> {}
|
|
<!INCOMPATIBLE_TYPES_WARNING!>c<!> -> {}
|
|
else -> {}
|
|
}
|
|
}
|
|
|
|
enum class E3 : MyInterface { X, Y }
|
|
|
|
fun foo5(i: MyInterface, a: Any) {
|
|
E3.X == E3.Y
|
|
E3.X == i
|
|
E3.X == a
|
|
}
|
|
|
|
fun foo6(e1: E1?, e2: E2) {
|
|
E1.A == null
|
|
null == E1.A
|
|
e1 == null
|
|
null == e1
|
|
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>e1 == E2.A<!>
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>E2.A == e1<!>
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>e1 == e2<!>
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>e2 == e1<!>
|
|
|
|
e2 == null
|
|
null == e2
|
|
E1.A == null
|
|
null == E1.A
|
|
}
|
|
|
|
fun foo7(e1: E1?, e2: E2?) {
|
|
e1 == e2 // There should be an IDE-inspection for such cases
|
|
}
|
|
|
|
fun <T> foo8(e1: E1?, e2: E2, t: T) {
|
|
e1 == t
|
|
t == e1
|
|
|
|
e2 == t
|
|
t == e2
|
|
|
|
E1.A == t
|
|
t == E1.A
|
|
}
|
|
|
|
fun <T, K> foo9(e1: E1?, e2: E2, t: T, k: K) where T : MyInterface, T : MyOpenClass, K : MyInterface {
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>e1 == t<!>
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>t == e1<!>
|
|
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>e2 == t<!>
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>t == e2<!>
|
|
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>E1.A == t<!>
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>t == E1.A<!>
|
|
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>E3.X == t<!>
|
|
|
|
E3.X == k
|
|
k == E3.X
|
|
}
|
|
|
|
interface Inv<T>
|
|
|
|
enum class E4 : Inv<Int> { A }
|
|
|
|
fun foo10(e4: E4, invString: Inv<String>) {
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>e4 == invString<!>
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>invString == e4<!>
|
|
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>E4.A == invString<!>
|
|
<!EQUALITY_NOT_APPLICABLE_WARNING!>invString == E4.A<!>
|
|
}
|