Tianyu Geng
c7272f6986
Currently DFA does not set "definitely equal to null" for access to variables that got assigned `null`. For example, FIR should mark the following line as SENSELESS_COMPARISON due to `s = null` above. https://github.com/JetBrains/kotlin/blob/d1531f9cdd5852352c0133198706125dc63b6007/compiler/testData/diagnostics/tests/smartCasts/alwaysNull.fir.kt#L6 The problem is at https://github.com/JetBrains/kotlin/blob/7e9f27436a77de1c76e3705da7aa1fbe8938336b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/dfa/FirDataFlowAnalyzer.kt#L1104 For null assignment, ideally the type should be `Nothing?`. This is addressed in a followup commit instead.
18 lines
441 B
Kotlin
Vendored
18 lines
441 B
Kotlin
Vendored
fun String.next(): String {
|
|
return "abc"
|
|
}
|
|
|
|
fun list(start: String) {
|
|
var e: Any? = start
|
|
if (<!SENSELESS_COMPARISON!>e==null<!>) return
|
|
while (e is String) {
|
|
// Smart cast due to the loop condition
|
|
if (e.length == 0)
|
|
break
|
|
// We still have smart cast here despite of a break
|
|
e = e.next()
|
|
}
|
|
// e can never be null but we do not know it
|
|
e<!UNSAFE_CALL!>.<!>hashCode()
|
|
}
|