Denis Zharkov
5e449fdc02
The case that it's worth to optimize is functions with a lot of variables. After debugging it's recovered that control-flow works nearly O(n * m) where n is pseudocode size and m is a number of variables: the algorithm performs O(n) copies of hashmap of size O(m) Persistent maps should help because we don't need to perform a copy of them, so the expected performance after the change is applied is O(n log m) We've tried pcollections and javaslang, and the latter one has demonstrated better results See results before and after optimizations before: https://github.com/dzharkov/kotlin-compiler-benchmarks/blob/3da7ba45a704969653d70b50995f730e968540d8/reports/benchmarks-many-vars-2017-03-14.txt after with pcollections: https://github.com/dzharkov/kotlin-compiler-benchmarks/blob/3da7ba45a704969653d70b50995f730e968540d8/reports/benchmarks-many-vars-persistent-optimizations-2017-03-17.txt after with javaslang: https://github.com/dzharkov/kotlin-compiler-benchmarks/blob/d22a871b175b291fb337b51ef6465ba70bbfd96c/reports/benchmarks-many-vars-javaslang-2017-04-07.txt
105 lines
4.4 KiB
Java
105 lines
4.4 KiB
Java
/*
|
|
* Copyright 2010-2015 JetBrains s.r.o.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package org.jetbrains.kotlin.cfg;
|
|
|
|
import com.google.common.collect.Lists;
|
|
import com.intellij.openapi.util.text.StringUtil;
|
|
import javaslang.Tuple2;
|
|
import org.jetbrains.annotations.NotNull;
|
|
import org.jetbrains.kotlin.cfg.pseudocode.PseudocodeImpl;
|
|
import org.jetbrains.kotlin.cfg.pseudocode.instructions.Instruction;
|
|
import org.jetbrains.kotlin.cfg.pseudocodeTraverser.Edges;
|
|
import org.jetbrains.kotlin.descriptors.VariableDescriptor;
|
|
import org.jetbrains.kotlin.resolve.BindingContext;
|
|
|
|
import java.util.Collections;
|
|
import java.util.List;
|
|
import java.util.Map;
|
|
|
|
public abstract class AbstractDataFlowTest extends AbstractPseudocodeTest {
|
|
|
|
@Override
|
|
public void dumpInstructions(
|
|
@NotNull PseudocodeImpl pseudocode,
|
|
@NotNull StringBuilder out,
|
|
@NotNull BindingContext bindingContext
|
|
) {
|
|
PseudocodeVariablesData pseudocodeVariablesData = new PseudocodeVariablesData(pseudocode.getRootPseudocode(), bindingContext);
|
|
Map<Instruction, Edges<InitControlFlowInfo>> variableInitializers =
|
|
pseudocodeVariablesData.getVariableInitializers();
|
|
Map<Instruction, Edges<UseControlFlowInfo>> useStatusData =
|
|
pseudocodeVariablesData.getVariableUseStatusData();
|
|
String initPrefix = " INIT:";
|
|
String usePrefix = " USE:";
|
|
int initializersColumnWidth = countDataColumnWidth(initPrefix, pseudocode.getInstructionsIncludingDeadCode(), variableInitializers);
|
|
|
|
dumpInstructions(pseudocode, out, (instruction, next, prev) -> {
|
|
StringBuilder result = new StringBuilder();
|
|
Edges<InitControlFlowInfo> initializersEdges = variableInitializers.get(instruction);
|
|
Edges<InitControlFlowInfo> previousInitializersEdges = variableInitializers.get(prev);
|
|
String initializersData = "";
|
|
if (initializersEdges != null && !initializersEdges.equals(previousInitializersEdges)) {
|
|
initializersData = dumpEdgesData(initPrefix, initializersEdges);
|
|
}
|
|
result.append(String.format("%1$-" + initializersColumnWidth + "s", initializersData));
|
|
|
|
Edges<UseControlFlowInfo> useStatusEdges = useStatusData.get(instruction);
|
|
Edges<UseControlFlowInfo> nextUseStatusEdges = useStatusData.get(next);
|
|
if (useStatusEdges != null && !useStatusEdges.equals(nextUseStatusEdges)) {
|
|
result.append(dumpEdgesData(usePrefix, useStatusEdges));
|
|
}
|
|
return result.toString();
|
|
});
|
|
}
|
|
|
|
private static int countDataColumnWidth(
|
|
@NotNull String prefix,
|
|
@NotNull List<Instruction> instructions,
|
|
@NotNull Map<Instruction, Edges<InitControlFlowInfo>> data
|
|
) {
|
|
int maxWidth = 0;
|
|
for (Instruction instruction : instructions) {
|
|
Edges<InitControlFlowInfo> edges = data.get(instruction);
|
|
if (edges == null) continue;
|
|
int length = dumpEdgesData(prefix, edges).length();
|
|
if (maxWidth < length) {
|
|
maxWidth = length;
|
|
}
|
|
}
|
|
|
|
return maxWidth;
|
|
}
|
|
|
|
@NotNull
|
|
private static <S, I extends ControlFlowInfo<?, S>> String dumpEdgesData(String prefix, @NotNull Edges<I> edges) {
|
|
return prefix +
|
|
" in: " + renderVariableMap(edges.getIncoming()) +
|
|
" out: " + renderVariableMap(edges.getOutgoing());
|
|
}
|
|
|
|
private static <S> String renderVariableMap(javaslang.collection.Map<VariableDescriptor, S> map) {
|
|
List<String> result = Lists.newArrayList();
|
|
for (Tuple2<VariableDescriptor, S> entry : map) {
|
|
VariableDescriptor variable = entry._1;
|
|
S state = entry._2;
|
|
result.add(variable.getName() + "=" + state);
|
|
}
|
|
Collections.sort(result);
|
|
return "{" + StringUtil.join(result, ", ") + "}";
|
|
}
|
|
}
|