Tianyu Geng
c7272f6986
Currently DFA does not set "definitely equal to null" for access to variables that got assigned `null`. For example, FIR should mark the following line as SENSELESS_COMPARISON due to `s = null` above. https://github.com/JetBrains/kotlin/blob/d1531f9cdd5852352c0133198706125dc63b6007/compiler/testData/diagnostics/tests/smartCasts/alwaysNull.fir.kt#L6 The problem is at https://github.com/JetBrains/kotlin/blob/7e9f27436a77de1c76e3705da7aa1fbe8938336b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/dfa/FirDataFlowAnalyzer.kt#L1104 For null assignment, ideally the type should be `Nothing?`. This is addressed in a followup commit instead.
52 lines
1.0 KiB
Kotlin
Vendored
52 lines
1.0 KiB
Kotlin
Vendored
// !DIAGNOSTICS: -UNUSED_EXPRESSION -UNUSED_VARIABLE -UNUSED_PARAMETER -ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE -UNUSED_VALUE
|
|
|
|
fun <T : CharSequence> bar1(x: T) {}
|
|
fun bar2(x: CharSequence) {}
|
|
fun bar3(x: String) {}
|
|
|
|
fun <T : CharSequence?> foo(x: T) {
|
|
var y1: CharSequence = ""
|
|
var y2: String = ""
|
|
if (x != null) {
|
|
if (<!SENSELESS_COMPARISON!>x != null<!>) {}
|
|
|
|
y1 = x
|
|
y2 = <!ASSIGNMENT_TYPE_MISMATCH!>x<!>
|
|
|
|
bar1(x)
|
|
bar1<CharSequence>(x)
|
|
bar2(x)
|
|
bar3(<!ARGUMENT_TYPE_MISMATCH!>x<!>)
|
|
}
|
|
|
|
if (x is String) {
|
|
y1 = x
|
|
y2 = x
|
|
|
|
bar1(x)
|
|
bar2(x)
|
|
bar3(x)
|
|
}
|
|
|
|
if (x is CharSequence) {
|
|
y1 = x
|
|
y2 = <!ASSIGNMENT_TYPE_MISMATCH!>x<!>
|
|
|
|
bar1(x)
|
|
bar2(x)
|
|
bar3(<!ARGUMENT_TYPE_MISMATCH!>x<!>)
|
|
}
|
|
|
|
if (1 == 1) {
|
|
val y = x!!
|
|
bar1(x)
|
|
bar1<CharSequence>(x)
|
|
bar2(x)
|
|
bar3(<!ARGUMENT_TYPE_MISMATCH!>x<!>)
|
|
|
|
bar1(y)
|
|
bar2(y)
|
|
bar3(<!ARGUMENT_TYPE_MISMATCH!>y<!>)
|
|
}
|
|
}
|