Tianyu Geng
c7272f6986
Currently DFA does not set "definitely equal to null" for access to variables that got assigned `null`. For example, FIR should mark the following line as SENSELESS_COMPARISON due to `s = null` above. https://github.com/JetBrains/kotlin/blob/d1531f9cdd5852352c0133198706125dc63b6007/compiler/testData/diagnostics/tests/smartCasts/alwaysNull.fir.kt#L6 The problem is at https://github.com/JetBrains/kotlin/blob/7e9f27436a77de1c76e3705da7aa1fbe8938336b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/dfa/FirDataFlowAnalyzer.kt#L1104 For null assignment, ideally the type should be `Nothing?`. This is addressed in a followup commit instead.
15 lines
406 B
Kotlin
Vendored
15 lines
406 B
Kotlin
Vendored
// FIR_IDENTICAL
|
|
//KT-1680 Warn if non-null variable is compared to null
|
|
package kt1680
|
|
|
|
fun foo() {
|
|
val x = 1
|
|
if (<!SENSELESS_COMPARISON!>x != null<!>) {} // <-- need a warning here!
|
|
if (<!SENSELESS_COMPARISON!>x == null<!>) {}
|
|
if (<!SENSELESS_COMPARISON!>null != x<!>) {}
|
|
if (<!SENSELESS_COMPARISON!>null == x<!>) {}
|
|
|
|
val y : Int? = 1
|
|
if (y != null) {}
|
|
if (y == null) {}
|
|
} |