kotlin-fork

Author SHA1 Message Date

Author	SHA1	Message	Date
Mark Punzalan	64141b8b38	[JVM IR] Fix issue where fields are not being set to their default values within initializer blocks. The issue occurs in code like this: ``` class C { var b = true init { b = false // Missing PUTFIELD for this statement } } ``` Added a new statement origin for field initialization (at declaration) instead of relying on `origin == null` in ExpressionCodegen to determine whether to generate the initializations. This was unintentionally broken in `d68a1898d0`.	2020-02-17 23:04:11 +03:00
Mark Punzalan	e91a16556c	JVM_IR: Do not add redundant field initializers. Initializers are "set field" expressions and are considered redundant when they are: 1. In the primary constructor; and 2. Set the field to `0`, `false`, or `null`; and 3. Have a `null` origin. I.e., not in an initializer block or constructor body, and therefore the field could not have been set by a prior expression.	2019-02-05 08:44:33 +01:00

Mark Punzalan

64141b8b38

[JVM IR] Fix issue where fields are not being set to their default

values within initializer blocks.

The issue occurs in code like this:
```
class C {
  var b = true
  init {
    b = false   // Missing PUTFIELD for this statement
  }
}
```

Added a new statement origin for field initialization (at declaration)
instead of relying on `origin == null` in ExpressionCodegen to determine
whether to generate the initializations.

This was unintentionally broken in
d68a1898d0.

2020-02-17 23:04:11 +03:00

Mark Punzalan

e91a16556c

JVM_IR: Do not add redundant field initializers.

Initializers are "set field" expressions and are considered redundant
when they are:
1. In the primary constructor; and
2. Set the field to `0`, `false`, or `null`; and
3. Have a `null` origin. I.e., not in an initializer block or
constructor body, and therefore the field could not have been set by a
prior expression.

2019-02-05 08:44:33 +01:00

2 Commits