Commit Graph

21687 Commits

Author SHA1 Message Date
Nikolay Krasko fe9c5cac45 Fix TypedHandlerTest in 193
Unify TypedHandlerTest.kt with the KotlinLightCodeInsightTestCase
2019-11-07 20:23:29 +03:00
Nikolay Krasko c053bd213a Don't assert order of todo items to fix platform update to 193 2019-11-07 20:23:29 +03:00
Nikolay Krasko 2aa251fd0c Remove deprecated API from InlayScratchFileRenderer 2019-11-07 20:23:28 +03:00
Vladimir Ilmov 9fb95e776e [HIGHLIGHT] Specific keyword rules for val,var highlighting.
'Kotlin keyword' rule configured as fallback rule for all Kotlin keywords:
- Created 'var'/'val' rules with fallback to 'Kotlin keyword'
- BUILTIN_ANNOTATION rule fallback changed from Java to 'Kotlin keyword'

 #KT-13344 Fixed
2019-11-07 18:48:59 +03:00
Toshiaki Kameyama 39db76b2ab "Indent raw string" intention: do not suggest in const
#KT-34784 Fixed
2019-11-07 14:57:56 +03:00
Leonid Startsev 24688f3503 Do not disable 'redundant visibility modifier' inspection completely in Explicit API mode.
Instead, disable it only for effectively public declarations.

Add tests for this IDE inspection.
2019-11-06 19:54:00 +03:00
Leonid Startsev ebb7e434c8 Explicit Api mode: Renamings after design discussions
Change CLI flag to -Xexplicit-api=strict|warning. 'Disable' state and 'mode' suffix are left out as implementation details.

Change intention title to 'make X public explicitly'

Do not report 'no explicit visibility' on property accessors

Set DECLARATION_SIGNATURE as a range for report

Rename internal diagnostic from _MIGRATION to _WARNING
2019-11-06 19:53:59 +03:00
Leonid Startsev 7fada51c42 Add quickfix for setting explicit public visibility for diagnostic reported in API mode 2019-11-06 19:53:59 +03:00
Leonid Startsev 2b708093c0 Add explicit return type check for API mode
It will use the same SpecifyTypeExplicitlyIntention as in other places; to reuse check logic, some parts of code were moved from corresponding inspection (PublicApiImplicitTypeInspection) into ApiModeDeclarationChecker.

Also disable RedundantVisibilityModifierInspection when API mode is on.
2019-11-06 19:53:58 +03:00
Nikolay Krasko 3c7b0e6ccc Fix gradle runtime dependency issue for completion-ranking-kotlin library
Execution failed for task ':idea:idea-test-framework:test'.
> Could not resolve all files for configuration ':idea:idea-test-framework:testRuntimeClasspath'.
   > Could not find org.jetbrains.intellij.deps.completion:completion-ranking-kotlin:0.0.2.
...
        Required by:
            project :idea:idea-test-framework > project :idea

It looks like when resolving this dependency gradle doesn't check the list of repositories in :idea module.
2019-11-05 20:13:30 +03:00
Nikolay Krasko 5ca3698d13 Remute JoinLinesTestGenerated tests in 193 (KT-34408) 2019-11-05 20:13:30 +03:00
Nikolay Krasko 651a70ae54 Remute MultiLineStringIndentTestGenerated tests in 193 (KT-34566) 2019-11-05 20:13:30 +03:00
Nikolay Krasko c50e60f90f More mutes for 193 branch
One more test for KT-34689.
2019-11-05 20:13:30 +03:00
Alexander Podkhalyuzin e3c6a1fbd8 Updating progress for optimize imports
#KT-33905 Fixed
2019-11-05 18:10:06 +03:00
Alexander Podkhalyuzin d2ae39489f SmartPointers in Smart Completion for anonymous object generation
#KT-32615 Fixed
2019-11-05 17:51:34 +03:00
Dmitry Gridin d321f4626f Formatter: fix line break before OperationReference in elvis
#KT-22362 Fixed
2019-11-05 20:13:11 +07:00
Dmitry Gridin 247619c565 Formatter: fix line break between label and property
#KT-22273 Fixed
2019-11-05 20:13:11 +07:00
Dmitry Gridin 7f1935b82e formatter: cleanup code 2019-11-05 20:13:11 +07:00
Dmitry Gridin 0098588a6b NodeIndentStrategy: remove code duplication 2019-11-05 20:13:11 +07:00
Dmitry Gridin 196dd25637 ProjectCodeStyleImporter: fix deprecated elements 2019-11-05 20:13:11 +07:00
Dmitriy Novozhilov c58ca27b2e [FIR] Introduce ResolutionMode as data for body resolve instead of Any? 2019-11-05 15:22:23 +03:00
Alexander Podkhalyuzin 722f7ff056 Now using Kotlin setting instead of Java one 2019-11-05 11:57:08 +03:00
victor.petukhov 62d204f4d6 Support trailing comma
^KT-34743 Fixed
2019-11-01 19:40:20 +03:00
Vyacheslav Gerasimov 3b088818a5 Build: Add sources and javadocs to Kotlin Plugin publication 2019-11-01 16:22:42 +03:00
Vyacheslav Gerasimov 579645bcfa Build: Publish ide-common as separate artifact in KotlinPlugin publication
#KT-34452
2019-11-01 16:22:42 +03:00
Vyacheslav Gerasimov 7401a7c63f Build: Fix dependencies of ide-common
#KT-34452
2019-11-01 16:22:42 +03:00
Nikolay Krasko a3ae629f53 Fix bunch file in 193 2019-11-01 12:25:44 +03:00
Nikolay Krasko ffafd96f1b Fix url for developers builds (KT-34246)
#KT-34246 Fixed
2019-11-01 12:25:44 +03:00
Andrey Uskov e909b63d30 Revert "Fix GradleConfiguratorTest"
This reverts commit 5360a7a3
2019-10-31 21:40:44 +03:00
Andrey Uskov fd2b75e39b Fixed import of MPP project with single Android target
#KT-34639 Fixed
2019-10-31 21:39:18 +03:00
Andrey Uskov 5c3b00cd0c Improve performance of import in Android Studio
Improve performance of dependency tree calculation when module per
source set mode is disabled.
#KT-34663 Fixed
2019-10-31 21:39:16 +03:00
Kirill Shmakov 72591e34b3 Support android_x64/86 in cinterop definitions 2019-10-31 18:35:06 +03:00
Alexander Podkhalyuzin 4c21b234b1 Fixed compilation in 191 2019-10-31 17:31:09 +03:00
Alexander Podkhalyuzin 7b8fbb5fea Fixed freezes with add unambiguous imports on the fly
We still had backup way to recalculate things for the case when fix
is not available. So if error is not importable, or we have second
error, which will be outdated after adding first import, we could get
freezes. 2019.2 and 2019.1 have different APIs, so it's implemented in
different way.

#KT-30863 Fixed
2019-10-31 17:25:29 +03:00
Alexander Podkhalyuzin 24d620657b Java doesn't have extension methods, so we don't need to look
for imports for qualified references

#KT-26162 Fixed
2019-10-31 16:00:44 +03:00
Dmitry Gridin f641e2a139 RedundantRequireNotNullCallInspection: should use BodyResolveMode.PARTIAL_WITH_CFA instead of BodyResolveMode.PARTIAL
#KT-34672 Fixed
2019-10-31 19:24:37 +07:00
Dmitry Gridin 04c8c888ee KotlinLightCodeInsightFixtureTestCase: remove deprecated call for 193 2019-10-31 19:24:36 +07:00
Dmitry Gridin 17429d333e Create expect/actual should move cursor to target declaration
#KT-34411 Fixed
2019-10-31 19:24:36 +07:00
Toshiaki Kameyama d75b938089 Formatter: don't format elvis operator in string template
#KT-34049 Fixed
2019-10-31 18:34:42 +07:00
Roman Golyshev bcee8ce04b KT-34692: Invoke ScratchAction::update without invokeLater
- `invokeLater` is bad here, since `AnAction::update` must update action look immediately, not later in the future
- Because of `invokeLater`, `RunScratchAction` wasn't properly rendered in the context menu
- `invokeLater` was added in the a24da280ca to fix EA-210180
  - EA-210180 is not reproducible; however, the main reason of the exception is that `AnAction::update` was called not from EDT, but from regular thread updating "Run From Here" (>>) gutter actions
  - all exception under EA-210180 are from 1.3.50; my guess is that those exceptions were caused by changes in scratch editor implementation details and will not appear again; if they will, we will need to investigate them
- ^KT-34692 Fixed
2019-10-31 14:22:06 +03:00
Roman Golyshev 28ec74648e Use ML completion extension point from 193 platform
- completion-ranking-kotlin jar used to be in the IDEA itself; thanks to new extension it can reside in the plugin from now on
- ML completion is turned off by default
- use `implementation` dependency because `completion-ranking-kotlin` is required during runtime
2019-10-31 13:37:38 +03:00
Nikolay Krasko b3e733ea4f 193: More mutes in 193 (SurroundWithTestGenerated, KT-34689, KT-34542, KT-34672) 2019-10-31 11:11:50 +03:00
Nikolay Krasko f7c775a080 193: Mute tests for find usages in libraries in 193 (KT-34542) 2019-10-31 11:11:50 +03:00
Nikolay Krasko 7e5316b9f1 Fix completion test for Java in 193
It looks like java completion doesn't use () anymore.
2019-10-31 11:11:50 +03:00
Nikolay Krasko 42312c3060 Fix GradleConfiguratorTest.testProjectWithModule in 193 2019-10-31 11:11:49 +03:00
Nikolay Krasko 0d2e790b32 Fix IdeaModuleInfoTest.testSdkForScript in 193
There's automatic jdk 7 registration starting from 193.
2019-10-31 11:11:49 +03:00
Nikolay Krasko c9793e4bf4 Fix IdeaModuleInfo tests in 193 2019-10-31 11:11:49 +03:00
Nikolay Krasko 201859be92 Mute RedundantRequireNotNullCall tests in 193 (KT-34672) 2019-10-31 11:11:49 +03:00
Nikolay Krasko bed2e21a1a Mute CoroutineNonBlockingontextDetectionTest tests in 193 (KT-34659) 2019-10-31 11:11:49 +03:00
Nikolay Krasko 1811b79503 Mute custom navigation tests (KT-34542) 2019-10-31 11:11:48 +03:00