Commit Graph

1111 Commits

Author SHA1 Message Date
Dereck Bridie 94970e2d1e Intention to replace a = b with b.also { a = it }
^KT-22420 Fixed
2020-09-03 15:11:36 +02:00
Enterman d09b20f11d Inspection to replace !string.isBlank() with string.isNotBlank()
#KT-40769 Fixed
2020-09-03 14:20:35 +02:00
Toshiaki Kameyama 8ce9b2d061 KT-34572 Convert to block body action improperly works with suppress annotations (#2969)
* Convert to block body: place @Suppress annotation before return expression

#KT-34572 Fixed

* Convert to block body: place annotations before return expression
2020-08-20 11:15:00 +03:00
Yunir Salimzyanov 27b2e16141 Cleanup as36 patchset files (KTI-315) 2020-08-19 19:40:00 +03:00
Toshiaki Kameyama 8ba5548a0f "Eliminate argument of 'when'": do not suggest if 'when' is used as expression and it has no 'else' branch (#2898)
#KT-35526 Fixed
2020-08-19 12:24:58 +03:00
Toshiaki Kameyama 89cc5777ce Put parameters on line: don't suggest if parameters has end-of-line comments
#KT-35214 Fixed
2020-08-13 19:53:46 +03:00
Toshiaki Kameyama b1e8238ea2 "Convert reference to lambda" intention: handle extension function reference with extension function call
#KT-35558 Fixed
2020-08-13 19:48:07 +03:00
Toshiaki Kameyama 9ff7539ff0 "Merge 'if's" intention: do not remove nested comments
#KT-33258 Fixed
#KT-39552 Fixed
2020-08-13 19:43:39 +03:00
Toshiaki Kameyama 5e91ffb156 Move to class body: don't suggest on data class
#KT-40558 Fixed
2020-08-12 16:10:33 +03:00
Toshiaki Kameyama c91858d470 Convert member to extension: do not suggest for delegated properties
#KT-35128 Fixed
2020-07-30 17:32:31 +03:00
Mikhail Zarechenskiy a6e58edfb9 Update test data, unmute test
Now behavior is the same as in OI for these cases.
 The behavior was changed in 100a6f70ca
2020-07-17 07:47:15 +03:00
Toshiaki Kameyama 0392fe75fc Convert to block body: specify non-nullable type when body expression is platform type and overriden method is non-nullable type
#KT-12222 Fixed
2020-06-30 22:47:13 +07:00
Toshiaki Kameyama 7ea1700b78 Convert lambda to reference: support generic function call
#KT-14578 Fixed
#KT-14395 Fixed
2020-06-26 20:30:39 +03:00
Toshiaki Kameyama e822e871f5 KT-39532 Support intention to convert reference to lambda and vice versa for adapted references (#3495)
* Convert lambda to reference: support a function which has default parameters/unit return type/suspendability

#KT-39532 Fixed
2020-06-26 14:21:17 +03:00
Toshiaki Kameyama 2fd3af73eb Convert reference to lambda: fix it works correctly when referenced function has default argument
#KT-17222 Fixed
#KT-24138 Fixed
#KT-39532
2020-06-26 10:20:29 +03:00
Toshiaki Kameyama 6b2c87020b Replace explicit parameter with 'it': do not suggest when lambda is directly under "when" or "if"
Relates to #KT-35320
2020-06-24 14:55:30 +02:00
Toshiaki Kameyama e4a1c8dcef Anonymous function to lambda: add lambda parameter if type parameter is used, even if parameter is unused
#KT-39393 Fixed
2020-06-05 17:32:35 +03:00
Roman Golyshev 7d662bf5d1 Change testData for IntentionsTestGenerated to avoid using javax and sql packages
- Those packages are missing in the mockJdk 1.8 in intellij repository,
and it leads to those tests failing in kotlin-ide repository
2020-06-05 16:03:51 +03:00
Toshiaki Kameyama 46ab338ea6 "Convert anonymous function to lambda expression" intention: add necessary lambda type parameter
#KT-37748 Fixed
2020-06-04 23:38:29 +03:00
Toshiaki Kameyama 343af60cb4 Add intention to expand boolean expression
#KT-38597 Fixed
2020-06-02 23:52:06 +03:00
Yunir Salimzyanov 3b9000cc0c Cleanup 191 extension files (KTI-240) 2020-06-01 18:43:10 +03:00
Toshiaki Kameyama 45d60baeb0 Add import for member: don't suggest if a class with the same name has been imported
#KT-38492 Fixed
2020-06-01 21:42:04 +09:00
Toshiaki Kameyama 329f0227ec Remove explicit type specification: do not suggest for suspend function type
#KT-38310 Fixed
2020-06-01 21:42:04 +09:00
Toshiaki Kameyama 5b927d798c Replace explicit parameter with it: don't suggest if overload resolution ambiguity error occurs
#KT-20795 Fixed
2020-06-01 21:42:03 +09:00
Toshiaki Kameyama 69a2697598 Convert lambda to reference: add type parameter to outer call expression if needed
#KT-37744 Fixed
2020-06-01 21:42:03 +09:00
Toshiaki Kameyama a4239afcb3 Convert to anonymous function: do not suggest for suspend functions
#KT-37842 Fixed
2020-06-01 21:42:03 +09:00
Toshiaki Kameyama 8f3392d635 Convert lambda to reference: fix it works correctly in anonymous object
#KT-31682 Fixed
2020-06-01 21:42:02 +09:00
Toshiaki Kameyama b9fab1123d Convert lambda to reference: fix it works correctly for labeled expression
#KT-37214 Fixed
2020-06-01 21:42:02 +09:00
Yan Zhulanow ef698a5747 Fix "PSI/index mismatch" in case of @ParameterName on non-functional types (KT-34524) 2020-05-27 02:38:41 +09:00
Toshiaki Kameyama 581f83421a Unnecessary parentheses in function call with lambda: don't report for function named 'suspend'
#KT-22878 Fixed
2020-05-27 02:38:40 +09:00
Toshiaki Kameyama 777995a3a0 Add braces: don't insert extra line break and move the following comment
#KT-36194 Fixed
2020-05-27 02:38:40 +09:00
Toshiaki Kameyama 81d01a8f8e "To ordinary string literal": don't add unnecessary escapes to characters in template expression
#KT-36406 Fixed
2020-05-27 02:38:40 +09:00
Toshiaki Kameyama f7a69d4aa7 Convert lambda to reference: suggest on lambda argument for suspend function parameter
#KT-34378 Fixed
2020-05-27 02:38:39 +09:00
Toshiaki Kameyama 9b6b25f069 Convert lambda to reference: suggest on lambda argument for extension function parameter
#KT-22014 Fixed
#KT-22015 Fixed
2020-05-27 02:38:39 +09:00
Toshiaki Kameyama a2f55e8b7c Remove redundant calls of the conversion method: report for unsigned types
#KT-30263 Fixed
2020-05-27 02:38:39 +09:00
Dmitry Gridin 50506658c0 fix some tests for as36 2020-05-08 19:13:28 +07:00
Dmitry Gridin 11a3482970 tests: apply official code style
#KT-38632 Fixed
2020-05-07 12:36:44 +00:00
Toshiaki Kameyama 77b6881032 Replace 'when' with 'if': do not suggest if 'when' is used as expression and it has no 'else' branch
#KT-35329 Fixed
2020-04-15 22:47:30 +02:00
Toshiaki Kameyama b4c62cdb52 Introduce "Add missing 'class' keyword" intention
#KT-14884 Fixed
2020-04-15 14:53:52 +02:00
Toshiaki Kameyama 9b3c3ae4ba "Replace 'invoke' with direct call" intention: do not add unnecessary parenthesis
#KT-37967 Fixed
2020-04-15 09:59:23 +02:00
Toshiaki Kameyama 2f29b38b19 "Replace 'invoke' with direct call" intention: fix false positive when function is not operator
#KT-37977 Fixed
2020-04-15 09:16:50 +02:00
Dmitry Gridin 585177bcf7 Formatter: fix indent for multiline expression in string template
#KT-35359 Fixed
2020-04-14 13:54:12 +00:00
Toshiaki Kameyama a96b359a09 "Remove braces from 'if' statement": do not suggest when lambda is directly under 'if'
#KT-35994 Fixed
2020-04-02 12:52:11 +03:00
Toshiaki Kameyama 30366148bf Convert to block body: adjust line indent
#KT-22368 Fixed
2020-04-02 12:48:05 +03:00
Toshiaki Kameyama c344b85d4e Convert parameter <-> receiver intention: do not add label to 'this' if not needed
#KT-17615 Fixed
#KT-30028 Fixed
#KT-32809 Fixed
#KT-28085 Fixed
#KT-37508 Fixed

Convert receiver to parameter:

#KT-37508 Fixed
2020-04-01 13:26:55 +03:00
Toshiaki Kameyama 34cfe7dfdb "Add missing component" intention: fix it works correctly if entries is empty
#KT-36094 Fixed
2020-04-01 00:42:43 +03:00
Toshiaki Kameyama 6a1923a477 "Convert to anonymous object" intention: suggest for kotlin fun interface
#KT-37749 Fixed
2020-03-31 12:17:16 +03:00
Roman Golyshev f656cd2889 KT-37781 Add FUN_KEYWORD to MODIFIERS_ORDER
- This way it is inserted before visibility modifiers
- ^KT-37781 Fixed
2020-03-26 19:37:10 +03:00
Vladimir Dolzhenko 344dbeffe8 Fix IntentionTestGenerated$IntroduceImportAlias.testConflictPackage
Fix test data as find usages can handle import aliases

Relates to #KT-18619
2020-03-22 15:30:49 +01:00
Dmitry Gridin 95b77f6386 AddJvmOverloadsIntention: disable for annotation classes
#KT-36482 Fixed
2020-03-18 13:51:56 +00:00