Alexander Udalov
965e3ebab2
Do not serialize SOURCE-retained annotations
...
Also, fix the value of "hasAnnotations" flag to reflect if there are any
_non-source_ annotations on a declaration.
Unfortunately, after this change
IncrementalJsCompilerRunnerTestGenerated$PureKotlin.testAnnotations
starts to fail because of the following problem. The problem is that
annotations on property accessors are not serialized yet on JS (see
KT-14529), yet property proto message has setterFlags field which has
the hasAnnotations flag. Upon the full rebuild of the code in that test,
we correctly write hasAnnotations = true, but annotations themselves are
not serialized. After an incremental build, we deserialize property
setter descriptor, observe its Annotations object which happens to be an
instance of NonEmptyDeserializedAnnotationsWithPossibleTargets. Now,
because annotations itself are not serialized, that Annotations object
has no annotations, yet its isEmpty always returns false (see the code).
Everything worked correctly before the change because in
DescriptorSerializer.hasAnnotations, we used Annotations.isEmpty and the
result was the same in the full rebuild and in the incremental scenario.
But now we're actually loading annotations, to determine their
retention, and that's why the setterFlags are becoming different here
and the test fails
#KT-23360 Fixed
2018-04-23 18:42:33 +02:00
Nikolay Krasko
c6f8c868ce
Minor: remove unused FIND_FILE_USAGES directive
2018-04-23 16:41:13 +03:00
Nicolay Mitropolsky
06e65e5f48
182: removing Spring from Kotlin-Ultimate
...
because all necessary functionality is already in IDEA-Ultimate
2018-04-21 11:25:49 +03:00
Pavel V. Talanov
521357a22d
Add tests for KT-20824, KT-23745, KT-23124, KT-20605, KT-23760
...
#KT-20824 Fixed
#KT-23745 Fixed
#KT-23124 Fixed
#KT-20605 Fixed
#KT-23760 Fixed
2018-04-20 20:00:12 +02:00
Pavel V. Talanov
94fe170b7b
MPP: analyze platform sources with expectedBy common sources
...
This allows to emulate current compiler behaviour
Introduce CombinedModuleInfo which is a combination of several other modules intended to be analyzed together
2018-04-20 20:00:11 +02:00
Pavel V. Talanov
94dfcba5c5
Minor: adjust quick fix test data to avoid "conflicting overloads"
2018-04-20 20:00:07 +02:00
Pavel V. Talanov
3949fc70c9
Adjust test data for previously ignored tests
2018-04-20 20:00:05 +02:00
Pavel V. Talanov
5ddb7c71d1
Mpp resolve: fix actual/expect declaration lookup
...
Previously we would look fo expect declaration in common dependencies
as opposed to looking inside the module exclusively
2018-04-20 20:00:04 +02:00
Pavel V. Talanov
cdb49511e6
Mpp highlighting test: make generated, adjust test data
...
Note: this spawns new test cases which were ignored previously
2018-04-20 20:00:02 +02:00
Mikhail Glukhikh
c69dd98c86
Build fix: quick-fix tests (forgotten actions)
2018-04-20 20:55:27 +03:00
Nikolay Krasko
b6699d7522
Postpone analyze and remove direct working with BindingContext in folding
...
#KT-5206 Fixed
2018-04-20 14:37:01 +03:00
Aaron Nwabuoku
3a83983bfc
Support code folding for standard library collection factory functions (KT-5206)
...
#KT-5206 Fixed
2018-04-20 14:37:01 +03:00
Alexey Sedunov
53a4baac8b
Safe Delete: Do not replace SafeDeleteOverrideAnnotation for Java methods
...
#KT-23613 Fixed
2018-04-19 19:06:48 +03:00
Claus Holst
84f0b327b1
KT-17608 Kotlin plugin says missing apply() call for SharedPreferences.Editor in With expression ( #1164 )
2018-04-19 16:29:27 +03:00
Zalim Bashorov
09d5a0cb89
Fix usages of IGNORE_BACKEND_WITHOUT_CHECK
2018-04-19 13:17:28 +03:00
Toshiaki Kameyama
fee74273aa
Invert if condition intention: do not remove line breaks #KT-11740 Fixed
2018-04-19 10:00:46 +03:00
Toshiaki Kameyama
03902030ed
Add intentions to put arguments / parameters on one line #KT-23266 Fixed
2018-04-18 20:45:31 +03:00
Toshiaki Kameyama
3992f0215c
"map.put() to assignment": handle case with labeled return inside
...
So #KT-23194 Fixed
2018-04-18 18:50:15 +03:00
Toshiaki Kameyama
a8d0e8995d
Don't suggest to move type to separate file for sealed classes
...
So #KT-23321 Fixed
2018-04-18 18:41:23 +03:00
Mikhail Glukhikh
ef3ba5f0b1
Test local inspections on the fly via highlighting
...
Fixes problem with INFORMATION highlight type in batch mode (IDEA 181).
It's no more required to report INFORMATIONs in unit tests in batch.
2018-04-18 16:14:43 +03:00
Toshiaki Kameyama
ff63ba4dc1
Add inspection: redundant internal in local anonymous object / class
...
So #KT-23617 Fixed
2018-04-18 11:17:52 +03:00
Mikhail Glukhikh
1d3ba5641d
"Main should return Unit": report on identifier, delete block body type
2018-04-18 11:16:03 +03:00
Toshiaki Kameyama
1cd438c3f7
Add inspection "main should return Unit" #KT-16085 Fixed
2018-04-18 10:59:23 +03:00
Vyacheslav Gerasimov
4299455dc1
as32: Update to AS 3.2 C10
2018-04-13 21:33:03 +03:00
Alexey Sedunov
62f654b3d2
Introduce Variable: Avoid explicit types for expression of anonymous type
...
#KT-12078 Fixed
2018-04-13 20:23:07 +03:00
Alexey Sedunov
c7e72af170
Override/Implement Members: Copy @Experimental-annotated annotations
...
#KT-22922 Fixed
2018-04-13 20:23:06 +03:00
Alexey Sedunov
c1d8ba9c2b
Parameter Info: Do not render nullability annotations
...
#KT-23408 Fixed
2018-04-13 20:23:06 +03:00
Alexey Sedunov
e5b915661a
Rename: Do not suggest camel names for backquoted non-identifiers
...
#KT-22888 Fixed
2018-04-13 20:23:05 +03:00
Alexey Sedunov
ea66e1e3f7
Copy: Fix exception on copying KtFile to non-KtFile
...
#KT-22669 Fixed
2018-04-13 20:23:05 +03:00
Alexey Sedunov
bf106d01b8
Find Usages: Restrict search scope of private top-level declarations
...
#KT-7622 Fixed
2018-04-13 20:23:04 +03:00
Toshiaki Kameyama
90be6235f7
Expand Selection on opening curly brace should select the entire block right away #KT-18769 Fixed
2018-04-13 13:23:42 +03:00
kenji tomita
decf9939fe
MoveLambdaOutsideParentheses: intention -> inspection #KT-21413 Fixed
2018-04-12 11:03:40 +03:00
Toshiaki Kameyama
52d72ab920
Fix AE exception in "Convert too long character literal to string"
...
So #KT-23608 Fixed
2018-04-11 17:00:38 +03:00
Toshiaki Kameyama
1cbaab1531
Preserve annotation arguments in "Add use-site target" intention
...
So #KT-23634 Fixed
2018-04-11 17:00:38 +03:00
Toshiaki Kameyama
a5aad22fe7
Don't report "Redundant Companion reference" on accessing nested object
...
So #KT-23620 Fixed
2018-04-11 17:00:37 +03:00
Toshiaki Kameyama
94c5344fd1
Check explicit type specification in "Might be const" inspection
...
So #KT-23303 Fixed
2018-04-11 17:00:37 +03:00
Felix Guo
9539212180
Take Java source file into account in "Add annotation target"
...
So #KT-22860 Fixed
2018-04-11 17:00:37 +03:00
Alexey Sedunov
25d19b45e9
181: Safe Delete: Do not delegate class search to Java
...
This fixes tests failing in IDEA 181
2018-04-11 16:28:37 +03:00
Vyacheslav Gerasimov
207247347e
181: Fix test data for android lint based tests
2018-04-11 16:28:37 +03:00
Alexey Sedunov
ffc059a0a1
181: Misc: Update Move test data
2018-04-11 16:28:36 +03:00
Vyacheslav Gerasimov
ae338566c2
181: Fix test data for android lint based tests
2018-04-11 16:28:35 +03:00
Vyacheslav Gerasimov
06efb037fd
as31: Fix test data for testAddArrayOfTypeForJavaAnnotation
2018-04-11 16:28:20 +03:00
Vyacheslav Gerasimov
4c498b004f
as31: Fix test data for android lint based tests for AS 3.0
2018-04-11 16:28:19 +03:00
Vyacheslav Gerasimov
11ee744340
as31: Drop custom Kotlin Android lint, register quickfixes with extension point
2018-04-11 16:28:16 +03:00
Vyacheslav Gerasimov
8d3f71a04f
172: Revert "Quick Fixes: Support cross-language "Create from Usage" with Kotlin target"
...
This reverts commit 908bf71
2018-04-11 16:28:09 +03:00
Nikolay Krasko
2d2b296f79
172: Revert "Update file structure tests as FileStructurePopup api was changed in 173"
...
This reverts commit 5244d48fde8e373b046a8ccb602a280b946f8d41.
2018-04-11 16:28:01 +03:00
Nikolay Krasko
1010c1285a
172: Revert "RecursiveMethodCallMarkerInfo and SuspendCallMarkerInfo forced to target Leaf-elements"
...
This reverts commit c78ec71e17c09ddb1094e44c84d9a1b92a3b509f.
2018-04-11 16:28:00 +03:00
Nikolay Krasko
a7d705b5d8
172: Revert "Fix inAnnotation test in 173 branch"
...
This reverts commit 955842f2009a2c5aa9ac955340696bd7e1a2651d.
2018-04-11 16:27:58 +03:00
Nikolay Krasko
afc37b9fed
172: Revert "Data Inflow: Support grouping by leaf expressions"
...
This reverts commit d5af2db2f259c7d55d38be73b9a5136e3aefd580.
2018-04-11 16:27:58 +03:00
Nikolay Krasko
236191bb89
172: Revert "Data Inflow: Support grouping by expression nullability"
...
This reverts commit e608f1ca159d55df39c8f33704220f360d54ba92.
2018-04-11 16:27:57 +03:00