Commit Graph

523 Commits

Author SHA1 Message Date
Toshiaki Kameyama ba5e643cb2 Redundant qualifier name: fix false positive with same name variable
#KT-39200 Fixed
2020-06-19 12:08:36 +07:00
Toshiaki Kameyama 148f49d54a UselessCallOnCollectionInspection: fix false positive when lambda last statement is function call that returns generic type
#KT-38267 Fixed
2020-06-03 20:42:42 +03:00
Toshiaki Kameyama 6cb0190fad FoldInitializerAndIfToElvis: should not add new line for multiline initializer
#KT-35805 Fixed
2020-06-03 12:35:50 +03:00
Toshiaki Kameyama afd544cbab Introduce "Redundant 'asSequence' call" inspections
#KT-35893 Fixed
2020-06-02 22:17:54 +03:00
Yan Zhulanow 741ebeb7b8 Mark semicolons after nullable types redundant, despite of '!' after (KT-38240) 2020-06-01 21:42:04 +09:00
Toshiaki Kameyama 4cf83d9526 Redundant semicolon: don't report when semicolon is between type and '!'
#KT-38240 Fixed
2020-06-01 21:42:04 +09:00
Toshiaki Kameyama 5efbbdea57 Lift assignment out: do not report when assignment variables are different
#KT-38649 Fixed
2020-06-01 21:42:03 +09:00
Toshiaki Kameyama 3272b8fc2c CanSealedSubClassBeObjectInspection: don't report if sub-class has classModifier
#KT-38790 Fixed
2020-06-01 21:42:02 +09:00
Toshiaki Kameyama 2a36a8acac JavaMapForEachInspection: don't report if argument is not single
#KT-39151 Fixed
2020-06-01 21:42:02 +09:00
Dmitry Gridin c78fd4aaca TrailingCommaInspection: should suggest fixes for call-site without warnings
#KT-39131 Fixed
2020-05-27 11:24:09 +00:00
Toshiaki Kameyama 7c0af78b08 UnnecessaryVariableInspection: fix false positive in lambda
#KT-32565 Fixed
2020-05-27 02:38:42 +09:00
Yan Zhulanow b756e18962 Never treat @JsExport-annotated declarations as not-used instead of @JsName 2020-05-27 02:38:41 +09:00
Toshiaki Kameyama 4638a97bbc "Call on collection type may be reduced": fix false positive with mapNotNull, generic lambda block and new inference
#KT-32801 Fixed
2020-05-27 02:38:40 +09:00
Toshiaki Kameyama 6ee4b5e393 Condition of 'if' expression is constant: don't report when condition has named reference
#KT-27651 Fixed
2020-05-27 02:38:40 +09:00
Toshiaki Kameyama 905d0c1016 Unused symbol: do not report for @JsName annotated declarations
#KT-17368 Fixed
2020-05-27 02:38:40 +09:00
Toshiaki Kameyama 7abd0831a1 Unused unary operator: highlight whole expression in yellow
#KT-37156 Fixed
2020-05-27 02:38:40 +09:00
Toshiaki Kameyama 43b106fc72 Can be replaced with binary operator: do not report if it leads to an error/warning after conversion
#KT-25050 Fixed
2020-05-27 02:38:40 +09:00
Toshiaki Kameyama bf3e739edf Replace with string templates: add curly braces if needed
#KT-37173 Fixed
2020-05-27 02:38:39 +09:00
Toshiaki Kameyama 8d3e41ae60 ReplaceToWithInfixFormInspection: don't report when call expression has type typeArguments
#KT-36508 Fixed
2020-05-27 02:38:39 +09:00
Toshiaki Kameyama b8ae13b3d9 RedundantLetInspection: remove 'let' safe call correctly
#KT-37148 Fixed
2020-05-27 02:38:39 +09:00
Toshiaki Kameyama 081d6c1dff Useless call on collection: propose 'Replace with toList()' instead of 'Remove useless call' if receiver is array type
#KT-38961 Fixed
2020-05-20 12:46:23 +03:00
Toshiaki Kameyama 23c4eac45b Introduce "Logger initialized with foreign class" inspection
^KT-38982 Fixed
2020-05-18 18:16:52 +03:00
Toshiaki Kameyama 08588001be Redundant suspend modifier: do not report when the function has 'actual' modifier
#KT-37746 Fixed
2020-05-14 12:08:52 +02:00
Dmitry Gridin 50506658c0 fix some tests for as36 2020-05-08 19:13:28 +07:00
Dmitry Gridin afb15eb7cf BranchedFoldingUtils: fix psi tree after tryFoldToAssignment
#KT-38677 Fixed
2020-05-07 12:36:45 +00:00
Dmitry Gridin 11a3482970 tests: apply official code style
#KT-38632 Fixed
2020-05-07 12:36:44 +00:00
Dmitry Gridin ac9ad30681 SetterBackingFieldAssignmentInspection: fix exception
#KT-38520 Fixed
2020-05-04 03:49:29 +00:00
Toshiaki Kameyama 831fbba0c1 Redundant qualifier name: don't report for EnumClass.Companion
#KT-37181 Fixed
2020-04-16 10:48:06 +02:00
Toshiaki Kameyama f747f8543e Redundant qualifier name: don't report for EnumClass.values/EnumClass.valueOf
#KT-34696 Fixed
2020-04-16 10:48:05 +02:00
Toshiaki Kameyama 37277d71de Condition of 'if' expression is constant: remove else keyword if needed
#KT-34713 Fixed
2020-04-15 21:53:16 +02:00
Toshiaki Kameyama e2a7170b2f Fix false positive "Collection count can be converted to size" with Iterable
#KT-34677 Fixed
2020-04-15 18:38:37 +02:00
Dmitry Gridin b548c5bf93 RemoveRedundantQualifierNameInspection: add regression test
#KT-35898
2020-04-07 15:57:34 +07:00
Toshiaki Kameyama 1f6b7dd88d "Redundant suspend modifier": fix false negative with only recursive call
#KT-35829 Fixed
2020-04-03 01:17:15 +03:00
Toshiaki Kameyama 6eebe21897 Remove redundant backticks: fix false positive for multiple underscores
#KT-37496 Fixed
2020-04-01 00:46:22 +03:00
Toshiaki Kameyama e5b4b03314 RedundantLambdaArrowInspection: fix false positive when receiver is qualified expression
#KT-37502 Fixed
2020-03-31 20:36:24 +03:00
Mikhail Zarechenskiy 191fb02bf6 [NI] Consider intersection type with number type as Nothing
Currently, only for "in": In<in Int & A> == In<in Nothing> == In<*>

 #KT-37302 Fixed
2020-03-23 16:39:21 +03:00
Dmitry Gridin 80caa063b3 UnusedUnaryOperatorInspection: shouldn't report on annotation entry
#KT-37294 Fixed
2020-03-12 08:46:33 +00:00
Toshiaki Kameyama 266149b88c RedundantLetInspection: fix false positive with nullable receiver extension call
#KT-31601 Fixed
2020-03-02 10:21:47 +07:00
Toshiaki Kameyama e56abcbb85 Inline variable: fix it works correctly for 'when' subject variable
#KT-29870 Fixed
2020-02-21 17:30:13 +01:00
Toshiaki Kameyama 820b8c3c54 Introduce "Redundant '?: return null'" inspection
#KT-34819 Fixed
2020-02-21 16:24:42 +01:00
Toshiaki Kameyama 5f1cc3b152 Introduce "Redundant 'inner' modifier" inspection
#KT-3262 Fixed
2020-02-21 16:12:49 +01:00
Toshiaki Kameyama 3398683093 Unused symbol: do not report for secondary constructor when class is used as typealias
#KT-20907 Fixed
2020-02-21 15:11:38 +01:00
Toshiaki Kameyama a3252b9480 Unused symbol: fix false positive in anonymous object in top level or companion object
#KT-31800 Fixed
#KT-20868 Fixed
2020-02-21 14:36:18 +01:00
Toshiaki Kameyama ef1e54eda9 ReplaceToStringWithStringTemplateInspection: insert curly braces if needed
#KT-36735 Fixed
2020-02-21 14:28:07 +01:00
Toshiaki Kameyama 19093e2e02 Redundant companion reference: fix false positive when companion has same name member as companion name
#KT-36707 Fixed
2020-02-21 13:57:04 +01:00
Roman Golyshev 46ae6136cb Rewrite RedundantSamConstructorInspection to support more cases
- Now inspection does not rely on synthetic descriptors at all, instead
it uses `SamConversionOracle` and `SamConversionResolver` to detect
if the argument type support SAM conversion
- This transparently considers all language features like
`SAM conversions for kotlin functions`, `Functional interfaces` etc.
- In case of multiple SAM arguments, part of them can be converted only
when `SAM conversion per argument` is enabled
- Fix inspection and nj2k tests that were failing because of better
working inspection
- Rewrite automatically fixes multiple bugs that were present
- ^KT-36367 ^KT-36368 ^KT-36296 ^KT-36395 Fixed
2020-02-19 17:16:17 +03:00
Roman Golyshev 3122760c49 Add more tests for RedundantSamConstructorInspection
- All those tests already pass, they are needed to fix the behaviour of the inspection before the changes
2020-02-19 17:16:17 +03:00
Toshiaki Kameyama 7f2cf571b0 Convert to range check: do not transform binaries/hexadecimals to decimals
#KT-36685 Fixed
2020-02-16 15:56:44 +09:00
Toshiaki Kameyama 0c9720f20c ReplaceGetOrSetInspection: do not report for 'get' with spread operator
#KT-36171 Fixed
2020-02-14 08:47:10 +03:00
Dmitry Gridin f8a21340d0 ProhibitRepeatedUseSiteTargetAnnotationsMigrationInspection: add test
#KT-36257
2020-02-13 13:51:33 +07:00