Commit Graph

4 Commits

Author SHA1 Message Date
Dmitry Savvinov 5800160ee1 Rewrite GradleDaemonAnalyzerTest
Previously, GradleDaemonAnalyzer reused common IJ infrastructure for
highlighting tests (see DaemonAnalyzerTеstCase, ExpectedHighlightingData
and such).

Unfortunately, this infrastructure had several flaws,
mainly around checking expected highlighting against actual one:

- overlapping line markers lead to crash (fixed in 193+)

- no way to sanitize descriptions of line markers (important for cases
where description returns HTML-formatted text, which makes testdata
completely unreadable and also drives parser insane)

- thrown FileNotFoundException doesn't have a physical file with
expected testdata attached, which makes browsing diff a little less
convenient (no way to apply changes to expected file)

- no easy way to plug-in with additional after-highlighting checks

This commit fixes it by overriding doCheckResult and providing custom
checking of highlighting/line markers, based on TagsTestDataUtil.
Because we don't rely on IJ-checking anymore, we also remove weird hoops
with removing/adding testdata markup in checkFiles.
Also this commit adds strings sanitization in TagsTestDataUtil, removing HTML-tags
and line breaks, so that description of tag is always one-liner with
plain text.
2020-01-24 11:00:16 +03:00
Mikhail Glukhikh 329e4f6000 New MPP highlighting test: add test without errors (KT-27494) 2018-11-02 15:42:39 +03:00
Mikhail Glukhikh 62e9eae48d New MPP highlighting test: check also line markers (KT-27494)
We have to do complex operations with tags, because otherwise
tags in different files prevent correct analysis of the current one
2018-11-02 15:42:06 +03:00
Mikhail Glukhikh 9be23bb21c Add first test for new multiplatform highlighting #KT-27494 Fixed 2018-11-02 15:41:45 +03:00