Commit Graph

21854 Commits

Author SHA1 Message Date
Natalia Selezneva 8bb9c572ac Move inProgress lock at the onFinish of background task (KT-34688)
Setting inProgress to false inside run method can lead to multiple notifications because of delay between run method end and progress hide
^KT-34688 Fixed
2019-11-26 16:35:59 +03:00
Ilya Goncharov f73fc5199b [Gradle, JS] Mute testWeb false positive test 2019-11-26 16:03:26 +03:00
Dmitry Gridin b40a888f1d Formatter: fix line break between declarations with annotations
#KT-35093 Fixed
#KT-35106 Fixed
2019-11-26 19:40:51 +07:00
Dmitry Gridin bfd539d5d1 Formatter: fix line break between declarations with comment
#KT-12490 Fixed
#KT-35088 Fixed
2019-11-26 19:40:51 +07:00
Dmitry Gridin b6b755506c Formatter: support Chop down if long for Chained method calls
#KT-23929 Fixed
#KT-33553 Fixed
2019-11-26 19:40:51 +07:00
Dmitry Gridin 351fef5628 DoubleBangToIfIntention: fix invalid psi tree 2019-11-26 19:40:50 +07:00
Nikolay Krasko 89f26cc89d Minor: Make diff function for AbstractKotlinFoldingTest
~true~ and ~false~ cases left unresolved
2019-11-26 15:39:27 +03:00
Toshiaki Kameyama 251899c31a Fix bad indentation when copy-paste to trimIndent()
#KT-33888 Fixed
2019-11-26 18:00:38 +07:00
Roman Golyshev faf4c05fc8 KT-34644 Give return keyword more priority in completion where appropriate
- See `returnExpressionItems::returnIsProbableInPosition` to get an idea where return is supposed to be more appropriate
  - End of the block (except for top level block of unit function or cycle) or as single expression in if or when
  - Right side of the elvis operator (which is not already in return)
- Add additional `probable_keyword` weigher to signalize about probable keyword (for now it is only for `return`)
- ^KT-34644 Fixed
2019-11-26 11:56:32 +03:00
Roman Golyshev de11b4cb64 KT-34644 Refactor CompletionUtils::returnExpressionItems
- Collecting `return` lookups to `blockBodyReturns` will later allow to modify them to increase priority in the completion
2019-11-26 11:56:19 +03:00
Mikhail Zarechenskiy eb73650209 Fix race in IDE: inject proper storage manager for type parameters
With NO_LOCKS strategy we can easily end up in a situation when
 constraint system for a generic call is built incorrectly,
 producing flaky errors (or don't produce errors at all)

 Now proper storage manager is injected for all cases except:
 - IR
 - Codegen
 - Serialization plugin
 - Fake local objects

 Most likely, NO_LOCKS strategy for these cases is fine as at that point
 the compiler works in one thread

 #KT-34786 Fixed
2019-11-26 10:52:45 +03:00
Yan Zhulanow 076166c22f Debugger: Generate line numbers for class initializers with a number on the 'init' keyword (KT-16277)
Debugger tests not absent as they use the bootstrap version of kotlinc.
Obviously, this change is not present in it yet.
2019-11-25 17:26:31 +09:00
Yan Zhulanow bebc8974b2 Report 5308947: check module validity before asking for library versions 2019-11-25 17:26:30 +09:00
Yan Zhulanow cf620cc60d Debugger: Synchronize "Add field breakpoint" dialog with the platform code 2019-11-25 17:26:30 +09:00
Yan Zhulanow 75b366fc5e EA-211653: Wrap field breakpoint dialog into a transaction guard 2019-11-25 17:26:30 +09:00
Yan Zhulanow ffeef6c18d EA-210460: Use 'safeAllLineLocations()' instead of throwing 'allLineLocations()' 2019-11-25 17:26:30 +09:00
Yan Zhulanow aaa45425da EA-210002: handle interruption in case of background inline callable searcher task 2019-11-25 17:26:30 +09:00
Yan Zhulanow 36073ef61e EA-209923: Add missing read action 2019-11-25 17:26:30 +09:00
Yan Zhulanow 69d5115b89 EA-214241: Remove worthless error reporting 2019-11-25 17:26:29 +09:00
Yan Zhulanow 16c4b0e458 EA-210823: Fix AIE in breakpoint applicability test 2019-11-25 17:26:29 +09:00
Yan Zhulanow ab06f772fc EA-209419: Fix read action requirement in Light constant evaluator 2019-11-25 17:26:29 +09:00
Yan Zhulanow 2983c87212 EA-215308: Fix unsafe check casts in template entry handling 2019-11-25 17:26:29 +09:00
Yan Zhulanow 3534d4af36 EA-215324: Fix "Module already disposed" in Scratch combo-box 2019-11-25 17:26:29 +09:00
Yan Zhulanow 3d17af0ada EA-215375: Check range, not rangeMarker with nullable 'range' inside 2019-11-25 17:26:29 +09:00
Yan Zhulanow 89bd3b8767 EA-215872: Check text range validity before 'getText(range)' 2019-11-25 17:26:28 +09:00
Yan Zhulanow 49bcb103ef EA-216005: Do not request KotlinFacetSettingsProvider for dead projects 2019-11-25 17:26:28 +09:00
Yan Zhulanow f91a84872a EA-216299: fix SIOOBE in completion 2019-11-25 17:26:28 +09:00
Yan Zhulanow f75288b480 EA-216333: check PsiElement validity before light class generation 2019-11-25 17:26:28 +09:00
Yan Zhulanow 59296d6a6b EA-217068: Add missing read action 2019-11-25 17:26:28 +09:00
Yan Zhulanow e12f17d5dc EA-217069: Add missing read action 2019-11-25 17:26:28 +09:00
Yan Zhulanow 54203100bc EA-217072: Add missing read action 2019-11-25 17:26:28 +09:00
Yan Zhulanow 6a4b658ad4 EA-217153: Add line count check 2019-11-25 17:26:27 +09:00
Yan Zhulanow ab0f841642 Debugger: Provide fixed implementation of 'toString()' for lambdas (KT-32691) 2019-11-25 17:26:27 +09:00
Yan Zhulanow 82a1750d26 Debugger: Forbid 'Nothing' constructor calls in evaluated code (KT-33093) 2019-11-25 17:26:27 +09:00
Dmitriy Dolovov 58dd9a6004 Fix AWT freeze in KotlinNativeABICompatibilityChecker (part 2)
Issue #KT-35052
2019-11-25 09:07:09 +07:00
Dmitriy Dolovov 0747a4d9b7 Fix AWT freeze in KotlinNativeABICompatibilityChecker
Issue #KT-35052
2019-11-25 09:07:02 +07:00
Vladimir Dolzhenko e321c9e4e7 Fix diagnostics calculations for incremental analysis 2019-11-23 23:36:49 +01:00
Vladimir Dolzhenko c7c512d55e Merge pull request #2815 from t-kameyama/KT-35022
Remove `const` modifier on "change to var" quickfix

#KT-35022 Fixed
2019-11-23 13:42:00 +01:00
Vladimir Dolzhenko d599322503 Calculate method parameter hint info in updateParameterInfo method (with a progress till 201)
Fixed #EA-216268
2019-11-23 09:24:14 +01:00
Svyatoslav Kuzmich 84757964bb Advance bootstrap to 1.3.70-dev-1806
Due to updated K/JS klib ABI

Add dependency of KotlinCoverageExtension to idea test classpath because of a new check introduced in 1806.

(cherry picked from commit bffbe89f53)
2019-11-22 22:12:39 +03:00
Nikolay Krasko 73a152ccc7 Re-mute inspection tests in AS34 (KT-32856) 2019-11-22 22:12:39 +03:00
Nikolay Krasko e49d7c86ff Re-mute move refactoring tests (KT-34106) 2019-11-22 22:12:38 +03:00
Nikolay Krasko 0ae677e945 Re-mute checker tests (KT-34105) 2019-11-22 22:12:38 +03:00
Nikolay Krasko 394a812329 Re-mute completion tests (KT-32919) 2019-11-22 22:12:37 +03:00
Nikolay Krasko 9356155f60 Minor: add bunch directives for better discoverability banched code 2019-11-22 22:12:36 +03:00
Toshiaki Kameyama f6059c3eb5 "Change to var": remove const modifier
#KT-35022 Fixed
2019-11-23 01:17:38 +09:00
Vyacheslav Gerasimov 027bc671c1 Build: Remove duplicated compiler.xml from idea module
Workaround for JPS build by copying compiler.xml in test runner before tests

For gradle just copy it in the processResourcesTask of idea project

 #KT-34528
2019-11-22 18:52:00 +03:00
Vladimir Ilmov a0d4d0da58 [coroutine][debug] rollback compilation failed exception as it breaks test scenarios 2019-11-22 13:17:37 +01:00
Natalia Selezneva b10f47b50e Minor: merge util methods for scripting to one file in idea-gradle 2019-11-22 11:43:35 +03:00
Natalia Selezneva 23f95872ad Minor: fix packages after moving classes to idea-gradle module 2019-11-22 11:43:35 +03:00