Commit Graph

17291 Commits

Author SHA1 Message Date
Pavel V. Talanov 7daf44a806 Fix bunch files after mpp changes 2018-04-23 18:56:36 +02:00
Alexander Udalov 965e3ebab2 Do not serialize SOURCE-retained annotations
Also, fix the value of "hasAnnotations" flag to reflect if there are any
_non-source_ annotations on a declaration.

Unfortunately, after this change
IncrementalJsCompilerRunnerTestGenerated$PureKotlin.testAnnotations
starts to fail because of the following problem. The problem is that
annotations on property accessors are not serialized yet on JS (see
KT-14529), yet property proto message has setterFlags field which has
the hasAnnotations flag. Upon the full rebuild of the code in that test,
we correctly write hasAnnotations = true, but annotations themselves are
not serialized. After an incremental build, we deserialize property
setter descriptor, observe its Annotations object which happens to be an
instance of NonEmptyDeserializedAnnotationsWithPossibleTargets. Now,
because annotations itself are not serialized, that Annotations object
has no annotations, yet its isEmpty always returns false (see the code).
Everything worked correctly before the change because in
DescriptorSerializer.hasAnnotations, we used Annotations.isEmpty and the
result was the same in the full rebuild and in the incremental scenario.
But now we're actually loading annotations, to determine their
retention, and that's why the setterFlags are becoming different here
and the test fails

 #KT-23360 Fixed
2018-04-23 18:42:33 +02:00
Alexander Udalov 361f686124 Move ModuleMapping and BinaryModuleData to metadata.jvm 2018-04-23 18:42:32 +02:00
Alexander Udalov d0544a148a Minimize dependencies of ModuleMapping
Prepare it to be moved to metadata.jvm
2018-04-23 18:42:32 +02:00
Nikolay Krasko 5817a7fdac Prevent endless processing of problem pending events
If some pending event processing caused exception in PerModulePackageCacheService,
log the problem and consider event processed. Otherwise it is going to
be stuck there forever.
2018-04-23 16:41:14 +03:00
Nikolay Krasko 00119c309c Don't call findChild on invalid file in ImplicitPackagePrefixCache 2018-04-23 16:41:14 +03:00
Nikolay Krasko 3f6022d74e Don't show several lambda return inlay hints for elvis (KT-22436)
Don't show inlay hints on binary expression operands

 #KT-22436
2018-04-23 16:41:14 +03:00
Nikolay Krasko 2a7f195bbc Fix FoldingAfterOptimizeImportsTest for case-sensitive file systems
Broken in b6699d7522
2018-04-23 16:41:13 +03:00
Nikolay Krasko d085f3e474 Don't call elementAtCaret for file usage test (fix for 181)
Fix testPropertyFileUsages test in 181.

Starting from 181, call `elementAtCaret` with zero offset returns
null element, when file starts with comment. Test fails because
of that.

https://github.com/JetBrains/intellij-community/commit/fdebc4084b9067ec19933d45a1ef2e04861206c3
2018-04-23 16:41:13 +03:00
Nikolay Krasko ffca06d8a8 Drop specific behaviour in AbstractFindUsagesTest.kt for 172
It's OK to run find usages test under progress manager.
2018-04-23 16:41:13 +03:00
Nikolay Krasko c6f8c868ce Minor: remove unused FIND_FILE_USAGES directive 2018-04-23 16:41:13 +03:00
Nicolay Mitropolsky 06e65e5f48 182: removing Spring from Kotlin-Ultimate
because all necessary functionality is already in IDEA-Ultimate
2018-04-21 11:25:49 +03:00
Pavel V. Talanov 521357a22d Add tests for KT-20824, KT-23745, KT-23124, KT-20605, KT-23760
#KT-20824 Fixed
 #KT-23745 Fixed
 #KT-23124 Fixed
 #KT-20605 Fixed
 #KT-23760 Fixed
2018-04-20 20:00:12 +02:00
Pavel V. Talanov 94fe170b7b MPP: analyze platform sources with expectedBy common sources
This allows to emulate current compiler behaviour

Introduce CombinedModuleInfo which is a combination of several other modules intended to be analyzed together
2018-04-20 20:00:11 +02:00
Pavel V. Talanov 94dfcba5c5 Minor: adjust quick fix test data to avoid "conflicting overloads" 2018-04-20 20:00:07 +02:00
Pavel V. Talanov 3949fc70c9 Adjust test data for previously ignored tests 2018-04-20 20:00:05 +02:00
Pavel V. Talanov 5ddb7c71d1 Mpp resolve: fix actual/expect declaration lookup
Previously we would look fo expect declaration in common dependencies
    as opposed to looking inside the module exclusively
2018-04-20 20:00:04 +02:00
Pavel V. Talanov cdb49511e6 Mpp highlighting test: make generated, adjust test data
Note: this spawns new test cases which were ignored previously
2018-04-20 20:00:02 +02:00
Pavel V. Talanov 5a85f2437d Mpp test utils: allow to setup dependencies on stdlib and fulljdk
Allow to specify jjvm8 as platform
2018-04-20 20:00:00 +02:00
Mikhail Glukhikh c69dd98c86 Build fix: quick-fix tests (forgotten actions) 2018-04-20 20:55:27 +03:00
Alexey Sedunov 36975786e8 Gradle: Import project dependency with non-default configuration by its artifacts 2018-04-20 16:57:43 +03:00
Dmitry Jemerov 2a684684a5 Pass canChangeWhitespaceOnly flag in reformat inspection
Otherwise IDEA will run preformat and postformat processors, which don't
expect to run outside of EDT (IDEA-185991)
2018-04-20 15:38:35 +02:00
Alexey Sedunov 38808118b1 Misc: Update test data for MavenUpdateConfigurationQuickFixTest (181/182) 2018-04-20 16:19:25 +03:00
Nikolay Krasko c86e157a48 Fix KotlinFileStructureTestGenerated in 181
Use common code for 173 and 181.
2018-04-20 14:37:02 +03:00
Nikolay Krasko b6699d7522 Postpone analyze and remove direct working with BindingContext in folding
#KT-5206 Fixed
2018-04-20 14:37:01 +03:00
Aaron Nwabuoku 3a83983bfc Support code folding for standard library collection factory functions (KT-5206)
#KT-5206 Fixed
2018-04-20 14:37:01 +03:00
Mikhail Glukhikh c4cdc0543d KT-23266 (forgotten change): modify plugin.xml for all branches 2018-04-20 13:17:06 +03:00
Alexey Sedunov 898105a5fa [REVERT/172] Test Support: Implement proper detection of existing TestNG configurations 2018-04-20 12:57:36 +03:00
Alexey Sedunov 48984fb3bf Maven: Support "javaParameters" tag in Kotlin/JVM configurations (181) 2018-04-19 19:11:54 +03:00
Alexey Sedunov 4819fc337d Misc: Fix dialog text for CallableRefactoring implementations
#KT-23778 Fixed
2018-04-19 19:06:48 +03:00
Alexey Sedunov f69a807ae6 Change Signature: Fix original method info for Java method used in Kotlin
#KT-23714 Fixed
2018-04-19 19:06:48 +03:00
Alexey Sedunov 53a4baac8b Safe Delete: Do not replace SafeDeleteOverrideAnnotation for Java methods
#KT-23613 Fixed
2018-04-19 19:06:48 +03:00
Alexey Sedunov 4938825e19 Test Support: Implement proper detection of existing TestNG configurations
#KT-8407 Fixed
2018-04-19 19:06:48 +03:00
Alexey Sedunov 3b5227d6ea Maven: Support "javaParameters" tag in Kotlin/JVM configurations
#KT-23845 Fixed
2018-04-19 19:06:47 +03:00
Claus Holst 84f0b327b1 KT-17608 Kotlin plugin says missing apply() call for SharedPreferences.Editor in With expression (#1164) 2018-04-19 16:29:27 +03:00
Alexey Sedunov 0f588955a9 Misc: Fix test data after updating to IDEA 181.3870.7 2018-04-19 15:27:56 +03:00
Zalim Bashorov 9c5e3ac629 Regenerate tests after rebase to master 2018-04-19 14:27:20 +03:00
Zalim Bashorov d40b0b556c Regenerate tests after fix usages of IGNORE_BACKEND_WITHOUT_CHECK 2018-04-19 13:18:31 +03:00
Zalim Bashorov 09d5a0cb89 Fix usages of IGNORE_BACKEND_WITHOUT_CHECK 2018-04-19 13:17:28 +03:00
Zalim Bashorov ab03ab84bb Regenerate tests 2018-04-19 13:17:27 +03:00
Zalim Bashorov 86fe2cc404 Minor: reformat DeprecatedSymbolUsageFixSpecialTest.kt 2018-04-19 13:17:21 +03:00
Toshiaki Kameyama fee74273aa Invert if condition intention: do not remove line breaks #KT-11740 Fixed 2018-04-19 10:00:46 +03:00
Toshiaki Kameyama dce5cb3ce9 Reformat InvertIfConditionIntention 2018-04-19 10:00:12 +03:00
Nicolay Mitropolsky 46ff4f2bbf 182: KotlinElementActionsFactory: "value"-parameters in generated java-annotations is putted without explicit parameter name #KT-23644 2018-04-18 21:17:24 +03:00
Mikhail Glukhikh de0cbf5844 Join parameter/argument list: use document to delete whitespaces
Otherwise fix has no effect in IDE. Related to KT-23266
2018-04-18 20:45:31 +03:00
Toshiaki Kameyama 03902030ed Add intentions to put arguments / parameters on one line #KT-23266 Fixed 2018-04-18 20:45:31 +03:00
Toshiaki Kameyama 3992f0215c "map.put() to assignment": handle case with labeled return inside
So #KT-23194 Fixed
2018-04-18 18:50:15 +03:00
Mikhail Glukhikh 77f62f1666 Move to separate file: minor optimization, related to KT-23321 2018-04-18 18:41:24 +03:00
Toshiaki Kameyama a8d0e8995d Don't suggest to move type to separate file for sealed classes
So #KT-23321 Fixed
2018-04-18 18:41:23 +03:00
Vyacheslav Gerasimov 02578bc378 Add dependency on com.intellij.modules.androidstudio to AS 3.1 & 3.2 plugin.xml 2018-04-18 18:31:39 +03:00