Commit Graph

496 Commits

Author SHA1 Message Date
Toshiaki Kameyama 831fbba0c1 Redundant qualifier name: don't report for EnumClass.Companion
#KT-37181 Fixed
2020-04-16 10:48:06 +02:00
Toshiaki Kameyama f747f8543e Redundant qualifier name: don't report for EnumClass.values/EnumClass.valueOf
#KT-34696 Fixed
2020-04-16 10:48:05 +02:00
Toshiaki Kameyama 37277d71de Condition of 'if' expression is constant: remove else keyword if needed
#KT-34713 Fixed
2020-04-15 21:53:16 +02:00
Toshiaki Kameyama e2a7170b2f Fix false positive "Collection count can be converted to size" with Iterable
#KT-34677 Fixed
2020-04-15 18:38:37 +02:00
Dmitry Gridin b548c5bf93 RemoveRedundantQualifierNameInspection: add regression test
#KT-35898
2020-04-07 15:57:34 +07:00
Toshiaki Kameyama 1f6b7dd88d "Redundant suspend modifier": fix false negative with only recursive call
#KT-35829 Fixed
2020-04-03 01:17:15 +03:00
Toshiaki Kameyama 6eebe21897 Remove redundant backticks: fix false positive for multiple underscores
#KT-37496 Fixed
2020-04-01 00:46:22 +03:00
Toshiaki Kameyama e5b4b03314 RedundantLambdaArrowInspection: fix false positive when receiver is qualified expression
#KT-37502 Fixed
2020-03-31 20:36:24 +03:00
Mikhail Zarechenskiy 191fb02bf6 [NI] Consider intersection type with number type as Nothing
Currently, only for "in": In<in Int & A> == In<in Nothing> == In<*>

 #KT-37302 Fixed
2020-03-23 16:39:21 +03:00
Dmitry Gridin 80caa063b3 UnusedUnaryOperatorInspection: shouldn't report on annotation entry
#KT-37294 Fixed
2020-03-12 08:46:33 +00:00
Toshiaki Kameyama 266149b88c RedundantLetInspection: fix false positive with nullable receiver extension call
#KT-31601 Fixed
2020-03-02 10:21:47 +07:00
Toshiaki Kameyama e56abcbb85 Inline variable: fix it works correctly for 'when' subject variable
#KT-29870 Fixed
2020-02-21 17:30:13 +01:00
Toshiaki Kameyama 820b8c3c54 Introduce "Redundant '?: return null'" inspection
#KT-34819 Fixed
2020-02-21 16:24:42 +01:00
Toshiaki Kameyama 5f1cc3b152 Introduce "Redundant 'inner' modifier" inspection
#KT-3262 Fixed
2020-02-21 16:12:49 +01:00
Toshiaki Kameyama 3398683093 Unused symbol: do not report for secondary constructor when class is used as typealias
#KT-20907 Fixed
2020-02-21 15:11:38 +01:00
Toshiaki Kameyama a3252b9480 Unused symbol: fix false positive in anonymous object in top level or companion object
#KT-31800 Fixed
#KT-20868 Fixed
2020-02-21 14:36:18 +01:00
Toshiaki Kameyama ef1e54eda9 ReplaceToStringWithStringTemplateInspection: insert curly braces if needed
#KT-36735 Fixed
2020-02-21 14:28:07 +01:00
Toshiaki Kameyama 19093e2e02 Redundant companion reference: fix false positive when companion has same name member as companion name
#KT-36707 Fixed
2020-02-21 13:57:04 +01:00
Roman Golyshev 46ae6136cb Rewrite RedundantSamConstructorInspection to support more cases
- Now inspection does not rely on synthetic descriptors at all, instead
it uses `SamConversionOracle` and `SamConversionResolver` to detect
if the argument type support SAM conversion
- This transparently considers all language features like
`SAM conversions for kotlin functions`, `Functional interfaces` etc.
- In case of multiple SAM arguments, part of them can be converted only
when `SAM conversion per argument` is enabled
- Fix inspection and nj2k tests that were failing because of better
working inspection
- Rewrite automatically fixes multiple bugs that were present
- ^KT-36367 ^KT-36368 ^KT-36296 ^KT-36395 Fixed
2020-02-19 17:16:17 +03:00
Roman Golyshev 3122760c49 Add more tests for RedundantSamConstructorInspection
- All those tests already pass, they are needed to fix the behaviour of the inspection before the changes
2020-02-19 17:16:17 +03:00
Toshiaki Kameyama 7f2cf571b0 Convert to range check: do not transform binaries/hexadecimals to decimals
#KT-36685 Fixed
2020-02-16 15:56:44 +09:00
Toshiaki Kameyama 0c9720f20c ReplaceGetOrSetInspection: do not report for 'get' with spread operator
#KT-36171 Fixed
2020-02-14 08:47:10 +03:00
Dmitry Gridin f8a21340d0 ProhibitRepeatedUseSiteTargetAnnotationsMigrationInspection: add test
#KT-36257
2020-02-13 13:51:33 +07:00
Toshiaki Kameyama 3ebad2acec "Constructor has non-null self reference parameter": don't report for vararg parameter
#KT-36160 Fixed
2020-02-12 16:35:26 +03:00
Toshiaki Kameyama 6c93217539 Lift assignment out: don't report when expression is used as expression
#KT-36357 Fixed
2020-02-12 16:17:25 +03:00
Dmitry Gridin bcfd089473 AbstractDiagnosticBasedMigrationInspection: fix case with nullable custom factory
#KT-36479 Fixed
2020-02-11 09:58:59 +07:00
Dmitry Gridin 733e596eed Create WarningOnMainUnusedParameterMigrationInspection
#KT-36256 Fixed
2020-02-10 17:04:07 +07:00
Dmitry Gridin 8d48d899d0 Create ProhibitRepeatedUseSiteTargetAnnotationsMigrationInspection
#KT-36257 Fixed
2020-02-10 17:04:07 +07:00
Dmitry Gridin 266a7a67f0 Create ProhibitUseSiteTargetAnnotationsOnSuperTypesMigrationInspection
#KT-36258 Fixed
2020-02-10 17:04:07 +07:00
Dmitry Gridin 181dd432ca RestrictReturnStatementTargetMigrationInspection: add quickfix
#KT-36262 Fixed
2020-02-10 17:04:07 +07:00
Dmitry Gridin 311860699e Create RedundantLabelMigrationInspection
#KT-36262
2020-02-10 17:04:06 +07:00
Dmitry Gridin 2f3e3b9c9e Create ProhibitJvmOverloadsOnConstructorsOfAnnotationClassesMigrationInspection
#KT-36260 Fixed
2020-02-10 17:04:06 +07:00
Dmitry Gridin cbcc76c3ff Create ProhibitTypeParametersForLocalVariablesMigrationInspection
#KT-36261 Fixed
2020-02-10 17:04:06 +07:00
Toshiaki Kameyama 4d1937b92d "Redundant 'suspend' modifier": do not report when function has 'suspend' calls by parenthesized expression
#KT-24869 Fixed
2020-02-05 14:31:13 +03:00
Dmitry Gridin c34b417d0c Fix tests after disabling trailing comma
#KT-34744
2020-02-04 21:34:53 +07:00
Toshiaki Kameyama 2f19ad7bdc Redundant companion reference: fix false positive with overridden Java getter (#2935)
#KT-33771 Fixed
2020-01-30 15:55:47 +03:00
Dmitry Gridin 96f49d8e3c Remove trailing comma from some tests 2020-01-30 15:32:09 +07:00
Dmitry Gridin 7627834dd0 TrailingCommaInspection: report Missing trailing comma on argument
#KT-34744
2020-01-23 17:36:38 +07:00
Dmitry Gridin 63ee723928 TrailingCommaPostFormatProcessor: improve findInvalidCommas
Add case for line break between argument and comma
#KT-34744
2020-01-23 17:36:38 +07:00
Dmitry Gridin ca1aa6ed4e TrailingCommaInspection: should report Missing line break
#KT-34744
2020-01-23 17:36:38 +07:00
Dmitry Gridin 9b64a1d18a TrailingCommaInspection: should report Missing trailing comma on symbol after argument
#KT-34744
2020-01-23 17:36:38 +07:00
Dmitry Gridin 6c166e744a Implement TrailingCommaInspection
#KT-34744
2020-01-17 21:02:55 +07:00
Dmitry Gridin d06787886a Fix tests after implementing trailing comma in formatter
#KT-34744
2020-01-17 21:02:54 +07:00
Toshiaki Kameyama fabeca5955 Redundant curly braces in string template: do not report labeled 'this'
#KT-35475 Fixed
2019-12-24 14:46:46 +07:00
Toshiaki Kameyama 03ec76b570 Redundant visibility modifier: do not report for 'internal' inside 'private'
#KT-35639 Fixed
2019-12-24 14:41:10 +07:00
Toshiaki Kameyama afc680d5c9 JavaMapForEachInspection: do not report when lambda parameter is destructuring declaration
#KT-34511 Fixed
2019-12-17 11:18:27 +03:00
Toshiaki Kameyama f8f50b2131 DeprecatedCallableAddReplaceWithInspection: add argument name if needed
#KT-34297 Fixed
2019-12-17 11:04:50 +03:00
Toshiaki Kameyama c72622c6d7 KT-32551 New J2K: Non-canonical modifiers order inspection is not applied during convertion of inner super class (#2806)
New J2K: add SortModifiers inspection to post-processing

#KT-32551 Fixed
2019-11-27 16:08:54 +03:00
Dmitry Gridin f641e2a139 RedundantRequireNotNullCallInspection: should use BodyResolveMode.PARTIAL_WITH_CFA instead of BodyResolveMode.PARTIAL
#KT-34672 Fixed
2019-10-31 19:24:37 +07:00
Nikolay Krasko 201859be92 Mute RedundantRequireNotNullCall tests in 193 (KT-34672) 2019-10-31 11:11:49 +03:00