Commit Graph

442 Commits

Author SHA1 Message Date
Toshiaki Kameyama 449c406e24 Redundant visibility modifier: do not report for public modifier that overrides protected setter visibility
#KT-33580 Fixed
2019-10-21 23:45:09 +07:00
Toshiaki Kameyama 131567474a "Redundant qualifier name": fix false positive with enum constant initialized with companion object field
#KT-33526 Fixed
2019-10-21 15:55:04 +07:00
Toshiaki Kameyama 15613afa20 Control flow with empty body: do not report 'if' with comments
#KT-34325 Fixed
2019-10-18 21:07:52 +07:00
Toshiaki Kameyama 74970ddfeb Introduce "Unused unary operator" inspection
#KT-12073 Fixed
2019-10-18 18:50:53 +07:00
Toshiaki Kameyama 89180e2650 Redundant companion reference: fix false positive with Java synthetic property
#KT-33771 Fixed
2019-10-17 17:17:44 +07:00
Toshiaki Kameyama a4f805ccd0 "Redundant qualifier name": add tests for enum/object
Relates to #KT-34113
Relates to #KT-32965
Relates to #KT-33991
Relates to #KT-33597
2019-10-17 14:30:25 +07:00
Pavel Kirpichenkov b7e5d9faae Update annotation rendering in diagnostics
Disable annotation rendering in default type and descriptor renderers.
Preserve annotations in Android and Serialization plugins.
Update error texts in ide tests.
Nullability annotations in Java descriptors are rendered with context-dependent renderer.

#KT-20258 Fixed
2019-10-04 11:18:45 +03:00
Dmitriy Novozhilov 439e8faf94 [NI] Remove outdated intention test according to fixed consistency of OI and NI 2019-09-27 17:20:47 +03:00
Toshiaki Kameyama fdf9acfb6a Introduce subject to when: suggest for qualified, not for obj / constant
#KT-18772 Fixed
2019-09-27 08:26:52 +03:00
Toshiaki Kameyama 998adfb098 Move variable declaration into when: don't report when property has 'break' or 'continue'
#KT-31999
2019-09-24 12:11:41 +03:00
Toshiaki Kameyama 877e583a96 Move variable declaration into when: don't report when property has 'return' or 'throw'
#KT-31999 Fixed
2019-09-24 12:11:41 +03:00
Toshiaki Kameyama 92dcb54207 "Redundant overriding method" inspection: do not report when overriding package private method
#KT-33153 Fixed
2019-09-23 12:35:56 +07:00
Toshiaki Kameyama 0ec18b4a33 Explicit this inspection: fix false negative with local variable
#KT-30136 Fixed
2019-08-30 12:07:13 +03:00
Toshiaki Kameyama 64d4cca589 Redundant override: do not report when class has derived property
#KT-32479 Fixed
2019-08-23 14:57:20 +07:00
Toshiaki Kameyama 7c2f6ecba7 Redundant curly braces in string template: remove braces for 'this'
#KT-32972 Fixed
2019-08-23 14:19:41 +07:00
Toshiaki Kameyama c0f896c96a flatMap call could be simplified to flatten(): Fix false positive with Array
#KT-33204 Fixed
2019-08-23 14:12:17 +07:00
Yan Zhulanow a8d08815a6 Simplify call: Fix false positive in "filter {}" detection (KT-32468)
"Simplify filter {}" conversion changes semantics when the casted type is not a subtype if an initial collection element type.
This commit limits a replacement suggestion to subtype cases.
2019-08-07 01:15:28 +09:00
Toshiaki Kameyama 892135ae23 Unused symbol: don't report for enum entry when enum builtin function is used
#KT-31133 Fixed
2019-08-05 12:50:28 +03:00
Toshiaki Kameyama 776cccf57c FunctionWithLambdaExpressionBodyInspection: fix ClassCastException for "Remove braces" quick fix
#KT-32580 Fixed
2019-08-05 12:35:23 +03:00
Toshiaki Kameyama 80b09b9a08 Replace 'if' with 'when': don't remove branch brances
#KT-32650 Fixed
2019-08-01 16:05:06 +03:00
Toshiaki Kameyama a6690e4e35 ReplaceGuardClause inspection: do not remove 'else' branch
#KT-32797 Fixed
2019-07-22 20:49:20 +03:00
Dmitry Gridin 694c231689 RemoveRedundantQualifierNameInspection: fix false negative for java constructor
#KT-32506 Fixed
2019-07-12 15:51:12 +03:00
Dmitry Gridin beba1d82fc ReplaceJavaStaticMethodWithKotlinAnalogInspection: add CommentSaver for case with transform to extension 2019-07-10 14:09:37 +03:00
Dmitry Gridin 56d2961cd9 ReplaceJavaStaticMethodWithKotlinAnalogInspection: add more tests 2019-07-10 14:09:37 +03:00
Dmitry Gridin 8314dbffd5 ReplaceJavaStaticMethodWithKotlinAnalogInspection: introduce Transformation for extension with non-null arguments 2019-07-10 14:09:36 +03:00
Dmitry Gridin 8b8858b223 ReplaceJavaStaticMethodWithKotlinAnalogInspection: introduce Transformation for extension with non-null receiver 2019-07-10 14:09:36 +03:00
Dmitry Gridin 026949a758 ReplaceJavaStaticMethodWithKotlinAnalogInspection: remove non-implemented cases 2019-07-10 14:09:36 +03:00
Dmitry Gridin 3aa2401f19 ReplaceJavaStaticMethodWithKotlinAnalogInspection: introduce Transform interface
#KT-32454 Fixed
2019-07-10 14:09:36 +03:00
Dmitry Gridin 835532c206 ReplaceJavaStaticMethodWithKotlinAnalogInspection: move to move to inspections.jdk2k subpackage 2019-07-10 14:09:36 +03:00
Dmitry Gridin b2a60795da ReplaceJavaStaticMethodWithKotlinAnalogInspection: add more cases for Arrays
#KT-32512 Fixed
#KT-30124 Fixed
2019-07-10 14:09:35 +03:00
Dmitry Gridin 24caca1882 ReplaceJavaStaticMethodWithKotlinAnalogInspection: fix false positive for 'Arrays.copyOf'
#KT-32477
2019-07-10 14:09:35 +03:00
Dmitry Gridin fda5692fc6 RemoveCurlyBracesFromTemplateInspection: add heuristic to change severity
Change severity to INFORMATION if a variable hasn't whitespace around & add an option to return the old behavior
 #KT-31717 Fixed
2019-07-10 10:28:45 +03:00
Toshiaki Kameyama 2ca0056cd0 ReplaceGuardClause inspection: check contracts availability 2019-07-08 16:36:19 +03:00
Toshiaki Kameyama 8cbcb66197 ReplaceGuardClause inspection: don't report when argument is not String 2019-07-08 16:36:18 +03:00
Toshiaki Kameyama 90b0ea73dc Add inspection for check/require/checkNotNull/requireNotNull
#KT-30640 Fixed
#KT-22412 Fixed
2019-07-08 16:36:18 +03:00
Dmitry Gridin f9b53da0fa Attempt to fix some inspection tests 2019-07-05 13:02:52 +07:00
Dmitry Gridin 46eb929bd1 ControlFlowWithEmptyBodyInspection: shouldn't report on while with comments
#KT-32419 Fixed
2019-07-04 16:33:24 +07:00
Dmitry Gridin 148eed2a12 ShortenReferences: fix false negative for object call chain
#KT-32320 Fixed
2019-07-02 11:54:38 +07:00
Dmitry Gridin 7e0db3d612 ComplexRedundantLetInspection: fix highlight for multiple line receiver
#KT-31278 Fixed
2019-06-25 14:37:04 +07:00
Dmitry Gridin b97aaf0f71 Split ReplaceSingleLineLetInspection to SimpleRedundantLet & ComplexRedundantLet
Relates to #KT-32010
2019-06-25 14:37:04 +07:00
Dmitry Gridin 8e0bbe7d4a Convert ReplaceSingleLineLetIntention to inspection & decrease severity to INFORMATION
#KT-32010 Fixed
2019-06-25 14:37:04 +07:00
Dmitry Gridin 0b16c51baf RemoveRedundantQualifierNameInspection: fix false positive
#KT-32112 Fixed
2019-06-24 15:17:10 +07:00
Dmitry Gridin a170de2c56 RemoveRedundantQualifierNameInspection: support class literal expression
#KT-32046 Fixed
2019-06-24 15:17:09 +07:00
Toshiaki Kameyama 2efbc6e914 Explicit this inspection: fix false positive with subclass and extension
#KT-27550 Fixed
2019-06-24 09:34:08 +03:00
Dmitry Gridin d9808b70b6 LeakingThisInspection: fix false positives for enum class
#KT-25905 Fixed
2019-06-21 18:40:31 +07:00
Toshiaki Kameyama 05a132357b Lift assignment: suggest for assignment of null
#KT-30191 Fixed
 #KT-28595 Fixed
2019-06-17 11:24:28 +07:00
Toshiaki Kameyama 4b4be07942 Add Inspection for lateinit var overrides another lateinit var
#KT-30775 Fixed
2019-06-17 01:28:55 +03:00
Toshiaki Kameyama a2205cfc98 Add "'equals()' between objects of inconvertible types" inspection
#KT-25006 Fixed
2019-06-17 01:09:54 +03:00
Toshiaki Kameyama b650c7ab00 Add "Redundant empty initializer block" inspection
^KT-5008 Fixed
2019-06-14 12:27:21 +03:00
Dmitry Gridin c155bf680f MoveVariableDeclarationIntoWhenInspection should move caret to subject expression
#KT-31954 Fixed
2019-06-14 15:28:06 +07:00