Yan Zhulanow
df88acaefd
Get rid of test-to-production dependencies as it's not supported in plain IDEA projects
2018-03-02 03:15:24 +03:00
Yan Zhulanow
a0c105adbe
Fixes to make the project compile when using Pill
2018-03-02 03:15:19 +03:00
Yan Zhulanow
8dad2d30f5
Move the compiler.xml back to IDEA (this fixes almost all IDE tests when running on JPS)
2018-03-02 03:15:18 +03:00
Yan Zhulanow
34d1611ed4
Add Pill support to compiler and IDE modules
2018-03-02 03:15:17 +03:00
Alexey Sedunov
30314d43d9
Shorten Reference: Disable ${...} shortening inside completion insert handler
2018-03-01 17:41:10 +03:00
Mikhail Glukhikh
68757fff2e
Downgrade "Type parameter can have ... variance" to INFORMATION level
2018-03-01 16:19:21 +03:00
Nikolay Krasko
a03470d151
Fix test data for JavaMethodUsedInKotlin.kt test after 173.3.4 update
...
- Ignore empty lines in actual test data
- Don't generate additional //INFO: in final file diff
2018-03-01 15:41:10 +03:00
Renaud Paquay
94ee78c0ca
Hitting breakpoint in Kotlin sometimes doesn't work (KT-22205)
...
Fix KT-22205 and https://issuetracker.google.com/issues/71556313
Hitting breakpoints in Kotlin JUnit test with an Android Gradle
project sometimes(*) does not work in Android Studio 3.1 beta.
(*) The issue is related to various threads running concurrently
with "dumb" mode background code, so the issue reproduces only
on certain configurations.
In a nutshell, the issue is as follows
* On one hand, gradle build finishes, fires an event ("buildFinished")
that is processed "later" and that causes the IDE to enter "dumb" mode
for a shot amount of time (about 300-500 msec on a somewhat up to date
multi-core computer).
* On the other hand, once the JVM of the debuggee is started, breakpoints
need to be resolved (on the debugger thread, through a call to
com.intellij.debugger.engine.CompoundPositionManager.createPrepareRequests.
This code calls into the "KotlinPositionManager.createPrepareRequests",
which in turns calls into "PerFileAnalysisCache.analyze". That method
returns "AnalysisResult.EMPTY" is the project is in dumb mode.
This return value prevents callers from successfully resolving
the source location into a breakpoint.
Given that the 2 code paths above execute on separate threads without
explicit synchronization, the "failed to resolve breakpoint" issue
occurs sporadically, to the point it happens 100% of the time on
certain configuration.
The fix is so wrap the kotlin breakpoint resolution code inside
a "runReadActionInSmartMode" so that the debugger thread "waits"
for "dumb" mode to terminates before trying to resolve breakpoint
locations.
#KT-22205 Fixed
2018-03-01 15:41:09 +03:00
Nikolay Krasko
b1bcadd762
Add mandatory dependency to com.intellij.modules.remoteServers
...
Android studio doesn't have this bundled module, so this should
prevent installing plugins for Intellij to AS.
This patch should be reverted in AS branches.
2018-03-01 15:41:07 +03:00
Pavel V. Talanov
a6aea5625a
Dsl completion: fix completion when multiple receivers are in scope
2018-02-28 19:48:45 +01:00
Ilya Chernikov
65af137117
(minor) Fix script templates from setting processing
2018-02-28 19:29:05 +01:00
Nicolay Mitropolsky
fa1d2a891b
KotlinLanguageInjector: getNameReference extracted to work with annotations
2018-02-28 17:19:46 +03:00
Nicolay Mitropolsky
08c41474af
KotlinLanguageInjector: "kotlin" injections in annotations handled by injectWithCall
2018-02-28 17:19:46 +03:00
Nicolay Mitropolsky
fd4f4ef853
KotlinLanguageInjector: support for nested annotations (#KT-21753)
2018-02-28 17:19:46 +03:00
Alexander Podkhalyuzin
12c01ef80a
Kotlin SDK auto-creation is disabled now #KT-23059 Fixed
...
(cherry picked from commit f5d8479)
2018-02-28 14:38:29 +03:00
Mikhail Glukhikh
0f029d8f51
Scope function conversion: remove 'can' from description to fix tests
2018-02-28 14:30:32 +03:00
Alexey Sedunov
d06f23f2ba
Move: Fix replacement of non-code usages with backquoted names
...
#KT-13986 Fixed
2018-02-28 14:03:43 +03:00
Alexey Sedunov
a194eb94cf
Remove Redundant Backticks: Fix inspection applicability
...
#KT-22804 Fixed
2018-02-28 14:03:43 +03:00
Alexey Sedunov
883558a4c7
Move/Copy: Fix 'protected' conflict reporting for references in super type entries
...
#KT-22678 Fixed
2018-02-28 14:03:43 +03:00
Alexey Sedunov
27f5ddcf83
Rename: Report redeclaration conflict between class and type alias
...
#KT-22751 Fixed
2018-02-28 14:03:42 +03:00
Alexey Sedunov
a341392524
Move: Search Java usages when top-level declaration moves to new facade
...
#KT-22747 Fixed
2018-02-28 14:03:42 +03:00
Alexey Sedunov
91fdc0e967
Move: Drop ${...} around shortened qualified expression
...
#KT-22692 Fixed
2018-02-28 14:03:42 +03:00
Alexey Sedunov
e63e48933d
Move: Add import for top-level declarations moved to the default package
...
#KT-22661 Fixed
2018-02-28 14:03:42 +03:00
Alexey Sedunov
96132a686a
Type Hierarchy: Support Kotlin class constructors
...
#KT-22925 Fixed
#KT-22926 Fixed
2018-02-28 14:03:41 +03:00
Mikhail Glukhikh
66f3126b20
Scope function conversion: remove forced INFORMATION highlight type
2018-02-28 13:17:39 +03:00
Nicolay Mitropolsky
2f6fb4091b
making LambdaArgument methods nullable
...
overridden `LambdaArgument.getArgumentExpression` removed because it is already nullable in parent
#EA-117013
2018-02-28 12:13:12 +03:00
Mikhail Glukhikh
664a25ce81
Polish KT-22011 inspection: message, level, group, range, etc.
2018-02-28 12:10:24 +03:00
Toshiaki Kameyama
7d6cb7805c
Add inspection: Java mutator method used on immutable Kotlin Collections
...
In particular, fill, reverse, shuffle, sort calls are reported
So #KT-22011 Fixed
2018-02-28 11:52:44 +03:00
Mikhail Glukhikh
bec28c8388
Replace with for-each: add new-lines using comment saver
...
Related to KT-15858
2018-02-28 11:29:44 +03:00
Toshiaki Kameyama
7f880bf58c
Replace with for-each: add new-line if necessary #KT-15858 Fixed
2018-02-28 11:18:21 +03:00
Mikhail Glukhikh
24622c0139
Fix two broken tests (missing actions)
2018-02-28 10:31:27 +03:00
Mikhail Glukhikh
dd106cb65c
Add braces: use CommentSaver to save/restore comments
...
Related to KT-16332
2018-02-27 18:25:38 +03:00
Toshiaki Kameyama
4726b44371
Add braces to 'if' statement: save/restore comments correctly
...
So #KT-16332 Fixed
2018-02-27 18:25:22 +03:00
Mikhail Glukhikh
b436ee6e19
Replace some of RESOLVED_CALL & REFERENCE_TARGET usages to resolveToCall
2018-02-27 18:24:55 +03:00
Mikhail Glukhikh
a3f88165cd
Make add / remove labeled return: extract 'getParentLambdaLabelName'
...
Related to KT-20439
2018-02-27 14:47:11 +03:00
Mikhail Glukhikh
86e6f3c5e3
Make add / remove labeled return working for hierarchical blocks
...
Related to KT-20439
2018-02-27 14:47:10 +03:00
shiraji
59f6dc07cf
Implement intention to add labeled return to last expression in a lambda
...
So #KT-20439 Fixed
2018-02-27 14:47:04 +03:00
shiraji
769e28519e
Implement intention to remove labeled return from last lambda expression
...
So #KT-20439 Fixed
2018-02-27 14:46:50 +03:00
Nikolay Krasko
4c7e46cbf8
Support prefix and suffix in Kotlin injection with comments and annotations (KT-23005)
...
#KT-23005 Fixed
2018-02-26 18:42:59 +03:00
Nikolay Krasko
9026582352
Minor: rename file
2018-02-26 18:42:58 +03:00
Nikolay Krasko
c5fc195754
Refactoring: move collectAllModuleInfosFromIdeaModel function
2018-02-26 18:42:58 +03:00
Nikolay Krasko
60af145170
Refactoring: move package ../caches/resolve/lightClasses -> ../caches/lightClasses
2018-02-26 18:42:58 +03:00
Nikolay Krasko
08a46c1396
Refactoring: move idea source modules classes to caches/project package
2018-02-26 18:42:58 +03:00
Nikolay Krasko
287ad512fb
Refactoring: extract project structure caches to separate package
2018-02-26 18:42:57 +03:00
Nikolay Krasko
a67ae0bf9f
Refactoring: remove defaults values
2018-02-26 18:42:57 +03:00
Nikolay Krasko
9b8e550f3b
Refactoring: move util files
2018-02-26 18:42:57 +03:00
Nikolay Krasko
931dec9cd8
Refactoring: move MapPsiToAsmDesc.kt to lightClasses package
2018-02-26 18:42:57 +03:00
Nikolay Krasko
47f4c79204
Reformat caches package
2018-02-26 18:42:57 +03:00
Simon Ogorodnik
57e47d1830
Propose convert to string template as inspection more frequent
2018-02-26 12:11:18 +03:00
Pavel V. Talanov
cf6fd4da81
Completion: prevent lookup elements from being duplicated correctly
...
This code prevents completion items from being submitted several times for the same descriptors
But some contributors actually do contribute extra items for already processed descriptors
Fixes a problem introduced in 1796d40118
2018-02-22 20:32:54 +01:00