Commit Graph

8192 Commits

Author SHA1 Message Date
Toshiaki Kameyama 4d1937b92d "Redundant 'suspend' modifier": do not report when function has 'suspend' calls by parenthesized expression
#KT-24869 Fixed
2020-02-05 14:31:13 +03:00
Dmitry Gridin 6c439ae85a Create TrailingCommaIntention
#KT-34744
2020-02-04 21:34:53 +07:00
Dmitry Gridin 195d9020a6 TrailingCommaInspection: shouldn't be associated with formatter settings
#KT-34744
2020-02-04 21:34:53 +07:00
Dmitry Gridin b5d0956a5e Move call-site trailing comma to registry
#KT-34744
2020-02-04 21:34:53 +07:00
Dmitry Gridin c34b417d0c Fix tests after disabling trailing comma
#KT-34744
2020-02-04 21:34:53 +07:00
Dmitriy Dolovov 623b554297 IDE: Fix friendly displaying of K/N KLIBs with components
Issue #KT-36213
2020-02-01 17:07:09 +07:00
Juan Chen 188abc243a [FIR] add vararg arguments support, improve vararg parameters support 2020-01-31 16:41:25 +03:00
Toshiaki Kameyama 2f19ad7bdc Redundant companion reference: fix false positive with overridden Java getter (#2935)
#KT-33771 Fixed
2020-01-30 15:55:47 +03:00
Ilya Kirillov 9f7af4b58d Fix testdata after ebe3619251 2020-01-30 15:52:54 +03:00
Dmitry Gridin 96f49d8e3c Remove trailing comma from some tests 2020-01-30 15:32:09 +07:00
Toshiaki Kameyama ebe3619251 KT-33384 Intention to switch between single-line/multi-line lambda (#2790)
Add intention for single-line lambda <-> multi-line lambda conversion

#KT-33384 Fixed
2020-01-29 12:32:26 +03:00
Ilya Gorbunov 30bccc431b Migrate tests to release coroutines
where it's not essential to use experimental ones

#KT-36083
2020-01-29 09:12:41 +03:00
Dmitriy Dolovov 901bb904e0 Fix GradleNativeLibrariesInIDENamingTest 2020-01-27 21:33:30 +07:00
Toshiaki Kameyama 1ba8b52856 Constructor parameter is never used as a property: do not report if parameter is used as a reference
#KT-34686 Fixed
2020-01-27 11:33:50 +03:00
Toshiaki Kameyama 59f70a912a Convert to lambda reference: don't suggest when lambda is argument for 'suspend' function parameter
#KT-16907 Fixed
2020-01-27 11:31:16 +03:00
Dmitriy Dolovov 224b2acdcc K/N: Get rid of remaining parts of "lite" KLIB API
Rewrite it in clean way and move to 'idea-gradle' module.
2020-01-26 22:17:50 +07:00
Dmitry Savvinov 56286cd4dc Fix overly restrictive cast to allow running multiplatform tests for objects
^KT-35480 Fixed
2020-01-24 11:00:17 +03:00
Dmitry Savvinov 77a7ceaa55 Add test on object with tests in common module
^KT-35480 In Progress

(current behavior is undesired, see fix in next commit)
2020-01-24 11:00:17 +03:00
Dmitry Savvinov f78ea75431 Fix running tests from expect class by using FakeLightClasses
Unfortunately, IJ API requires us to return instances of
PsiClass/PsiMethod in order to proceed with run configuration creation.

In fact, those instances will be queried only by trivial requests, like
containingFile or name. Therefore, full-blown LightClasses are not
needed and even harmful, because for some declarations we can not build
proper light classes (like for expect declarations, for example)

Previously it mostly worked because most of declarations in common
indeed have corresponding Light-instances (because common source-set can
be seen from Java through JVM-part of a project).

^KT-34503 Fixed
2020-01-24 11:00:16 +03:00
Dmitry Savvinov cea612cba4 Add test on expect class with test methods inside
^KT-34503 In Progress

(current behaviour is undesired, see next commit for fix)
2020-01-24 11:00:16 +03:00
Dmitry Savvinov b34f091fa4 Introduce tests runner for run configurations + highlighting + Gradle
This allows us to check two things:
- presence of line markers (haven't been checked by old
  GradleTestRunConfigurationTests, though could've been checked by
  LineMarkerTests)
- some properties of run configurations which will be created from those
  line markers

Old GradleTestRunConfigurationTest have been renamed to
GradleTestRunConfigurationCustomTest and slightly modified to be able
to re-use the same testdata if necessary.
2020-01-24 11:00:16 +03:00
Dmitry Savvinov 5800160ee1 Rewrite GradleDaemonAnalyzerTest
Previously, GradleDaemonAnalyzer reused common IJ infrastructure for
highlighting tests (see DaemonAnalyzerTеstCase, ExpectedHighlightingData
and such).

Unfortunately, this infrastructure had several flaws,
mainly around checking expected highlighting against actual one:

- overlapping line markers lead to crash (fixed in 193+)

- no way to sanitize descriptions of line markers (important for cases
where description returns HTML-formatted text, which makes testdata
completely unreadable and also drives parser insane)

- thrown FileNotFoundException doesn't have a physical file with
expected testdata attached, which makes browsing diff a little less
convenient (no way to apply changes to expected file)

- no easy way to plug-in with additional after-highlighting checks

This commit fixes it by overriding doCheckResult and providing custom
checking of highlighting/line markers, based on TagsTestDataUtil.
Because we don't rely on IJ-checking anymore, we also remove weird hoops
with removing/adding testdata markup in checkFiles.
Also this commit adds strings sanitization in TagsTestDataUtil, removing HTML-tags
and line breaks, so that description of tag is always one-liner with
plain text.
2020-01-24 11:00:16 +03:00
Ilya Gorbunov 39078342ee Remove mod function deprecation tests
#KT-26654
2020-01-23 19:28:23 +03:00
Leonid Startsev 4285c6045a Fix unavailable 'Specify visibility explicitly' quickfix
in explicit API mode due to incorrect cast.
Add tests for applying this quickfix.
#KT-36020 fixed.
2020-01-23 17:05:50 +03:00
Roman Golyshev a2b2c47b51 KT-34795 Use maven(...) instead of maven { setUrl(...) } for gradle scripts generation
- Use new syntax in tests, but not in actual gradle files
- Reuse public `toKotlinRepositorySnippet` instead of private one
- ^KT-34795 Fixed
2020-01-23 13:45:16 +03:00
Roman Golyshev 3dbc058db9 KT-34795 Remove obsolete Gradle 3.5 test data
- Tests do not run with Gradle 3.5 anymore
2020-01-23 13:45:16 +03:00
Dmitry Gridin 7627834dd0 TrailingCommaInspection: report Missing trailing comma on argument
#KT-34744
2020-01-23 17:36:38 +07:00
Dmitry Gridin 63ee723928 TrailingCommaPostFormatProcessor: improve findInvalidCommas
Add case for line break between argument and comma
#KT-34744
2020-01-23 17:36:38 +07:00
Dmitry Gridin ca1aa6ed4e TrailingCommaInspection: should report Missing line break
#KT-34744
2020-01-23 17:36:38 +07:00
Dmitry Gridin 9b64a1d18a TrailingCommaInspection: should report Missing trailing comma on symbol after argument
#KT-34744
2020-01-23 17:36:38 +07:00
Vladimir Dolzhenko db8b0a6593 Show Review Added Imports on paste action
Fixed multi-caret selection in kotlin-to-kotlin copy-paste processor

Relates to #KT-33939
2020-01-22 17:14:04 +01:00
Toshiaki Kameyama 2daedc98b5 KT-35648 RemoveArgumentNameIntention: Support MixedNamedArgumentsInTheirOwnPosition
- ^KT-35648 Fixed
2020-01-21 11:43:37 +03:00
Dmitriy Novozhilov 5cb7cf040a Update some testdata according switching compiler to 1.4 2020-01-20 16:41:46 +03:00
Dmitry Gridin 976db65911 TrailingCommaInspection: replace "Redundant trailing comma" message with "Useless trailing comma"
#KT-34744
2020-01-20 16:56:06 +07:00
Mikhail Zarechenskiy 581db19544 Fix test after advancing bootstrap compiler to 1.4
Now test is correct as it was previously, see https://github.com/JetBrains/kotlin/commit/76b3964e96b7a13479e9df95d5927be70eeea712#diff-03626fd0c49fefdea63cff24d50ea9eaL10
2020-01-20 11:01:28 +03:00
Nikolay Krasko f01b4706d1 Switch to 193 platform 2020-01-19 12:01:53 +03:00
Mikhail Zarechenskiy 8206cadce2 FIC: support fun interfaces in stub builder 2020-01-17 19:36:12 +03:00
Dmitry Gridin 6c166e744a Implement TrailingCommaInspection
#KT-34744
2020-01-17 21:02:55 +07:00
Dmitry Gridin c5c035b67c TrailingCommaPostFormatProcessor: fix comments position before comma
#KT-34744
2020-01-17 21:02:54 +07:00
Dmitry Gridin d06787886a Fix tests after implementing trailing comma in formatter
#KT-34744
2020-01-17 21:02:54 +07:00
Dmitry Gridin 9511348497 TrailingCommaPostFormatProcessor: should be completed in one round
#KT-34744
2020-01-17 21:02:53 +07:00
Dmitry Gridin 8a45d2eb58 Formatter: add line break between comma and semicolon
#KT-34744
2020-01-17 21:02:53 +07:00
Dmitry Gridin b72da6c4fc Formatter: support trailing comma in destruction declarations
#KT-34744
2020-01-17 21:02:53 +07:00
Dmitry Gridin 96a11707ca Formatter: support trailing comma in lambda value parameters & fix comments in KtParameter
#KT-34744
2020-01-17 21:02:53 +07:00
Dmitry Gridin d013fc2234 Formatter: support trailing comma in when entry
#KT-34744
2020-01-17 21:02:53 +07:00
Dmitry Gridin 4adfaab3ec Formatter: support trailing comma in lambda parameters
#KT-34744
2020-01-17 21:02:53 +07:00
Dmitry Gridin 07bda5a759 Formatter: support trailing comma in collection literal expression
#KT-34744
2020-01-17 21:02:52 +07:00
Dmitry Gridin ccd780c008 Formatter: support trailing comma in type arguments
#KT-34744
2020-01-17 21:02:52 +07:00
Dmitry Gridin b99c7f8d14 Formatter: support trailing comma in type parameters
#KT-34744
2020-01-17 21:02:52 +07:00
Dmitry Gridin 58058eef21 Formatter: support trailing comma in indexing suffix
#KT-34744
2020-01-17 21:02:52 +07:00