From fee83051e95222872bcb95080cff58a474b9f0d8 Mon Sep 17 00:00:00 2001 From: Ilya Kirillov Date: Wed, 14 Apr 2021 13:06:01 +0200 Subject: [PATCH] FIR: encapsulate creating of cli-only session components into single function --- .../kotlin/fir/session/ComponentsContainers.kt | 10 +--------- .../jetbrains/kotlin/fir/session/FirSessionFactory.kt | 8 ++------ 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/compiler/fir/entrypoint/src/org/jetbrains/kotlin/fir/session/ComponentsContainers.kt b/compiler/fir/entrypoint/src/org/jetbrains/kotlin/fir/session/ComponentsContainers.kt index bb4bed81e96..0551fc88a09 100644 --- a/compiler/fir/entrypoint/src/org/jetbrains/kotlin/fir/session/ComponentsContainers.kt +++ b/compiler/fir/entrypoint/src/org/jetbrains/kotlin/fir/session/ComponentsContainers.kt @@ -51,17 +51,9 @@ fun FirSession.registerCommonComponents(languageVersionSettings: LanguageVersion } @OptIn(SessionConfiguration::class) -fun FirSession.registerThreadUnsafeCaches() { +fun FirSession.registerCliCompilerOnlyComponents() { register(FirCachesFactory::class, FirThreadUnsafeCachesFactory) -} - -@OptIn(SessionConfiguration::class) -fun FirSession.registerSealedClassInheritorsProvider() { register(SealedClassInheritorsProvider::class, SealedClassInheritorsProviderImpl) -} - -@OptIn(SessionConfiguration::class) -fun FirSession.registerFirCliPhaseManager() { register(FirPhaseManager::class, FirPhaseCheckingPhaseManager) } diff --git a/compiler/fir/entrypoint/src/org/jetbrains/kotlin/fir/session/FirSessionFactory.kt b/compiler/fir/entrypoint/src/org/jetbrains/kotlin/fir/session/FirSessionFactory.kt index 20008779721..7758e58b1e7 100644 --- a/compiler/fir/entrypoint/src/org/jetbrains/kotlin/fir/session/FirSessionFactory.kt +++ b/compiler/fir/entrypoint/src/org/jetbrains/kotlin/fir/session/FirSessionFactory.kt @@ -73,12 +73,10 @@ object FirSessionFactory { init: FirSessionConfigurator.() -> Unit = {} ): FirJavaModuleBasedSession { return FirJavaModuleBasedSession(moduleInfo, sessionProvider).apply { - registerThreadUnsafeCaches() - registerFirCliPhaseManager() + registerCliCompilerOnlyComponents() registerCommonComponents(languageVersionSettings) registerResolveComponents(lookupTracker) registerJavaSpecificResolveComponents() - registerSealedClassInheritorsProvider() val kotlinScopeProvider = KotlinScopeProvider(::wrapScopeWithJvmMapped) @@ -127,10 +125,8 @@ object FirSessionFactory { languageVersionSettings: LanguageVersionSettings = LanguageVersionSettingsImpl.DEFAULT, ): FirLibrarySession { return FirLibrarySession(moduleInfo, sessionProvider).apply { - registerThreadUnsafeCaches() - registerFirCliPhaseManager() + registerCliCompilerOnlyComponents() registerCommonComponents(languageVersionSettings) - registerSealedClassInheritorsProvider() val javaSymbolProvider = JavaSymbolProvider(this, project, scope)