azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Code cleanup: ReplaceAddWithPlusAssignIntention

Browse Source
This commit is contained in:
Mikhail Glukhikh
2017-10-10 15:40:51 +03:00
committed by Mikhail Glukhikh
parent 45c9be2945
commit fd95769780
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/src/org/jetbrains/kotlin/idea/intentions/ReplaceAddWithPlusAssignIntention.kt
+8 -6
View File
@@ -29,15 +29,17 @@ import org.jetbrains.kotlin.resolve.calls.resolvedCallUtil.getExplicitReceiverVa
import org.jetbrains.kotlin.resolve.descriptorUtil.isSubclassOf import org.jetbrains.kotlin.resolve.descriptorUtil.isSubclassOf
import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
class ReplaceAddWithPlusAssignIntention : SelfTargetingOffsetIndependentIntention<KtDotQualifiedExpression>(KtDotQualifiedExpression::class.java, "Replace with '+='") { class ReplaceAddWithPlusAssignIntention : SelfTargetingOffsetIndependentIntention<KtDotQualifiedExpression>(
KtDotQualifiedExpression::class.java,
"Replace with '+='"
) {
private val compatibleNames = setOf("add", "addAll")
override fun isApplicableTo(element: KtDotQualifiedExpression): Boolean { override fun isApplicableTo(element: KtDotQualifiedExpression): Boolean {
if (element.callExpression?.valueArguments?.size != 1) return false if (element.callExpression?.valueArguments?.size != 1) return false
when (element.calleeName) { if (element.calleeName !in compatibleNames) return false
"add" -> text = "Replace 'add()' with '+='" text = "Replace '${element.calleeName}()' with '+='"
"addAll" -> text = "Replace 'addAll()' with '+='"
else -> return false
}
val context = element.analyze(BodyResolveMode.PARTIAL) val context = element.analyze(BodyResolveMode.PARTIAL)
BindingContextUtils.extractVariableDescriptorFromReference(context, element.receiverExpression)?.let { BindingContextUtils.extractVariableDescriptorFromReference(context, element.receiverExpression)?.let {