Report invisible setter error if it's resolved to synthetic property of base class with public getter and protected setter

^KT-11713 Fixed

compiler/testData/diagnostics/tests/scopes/protectedVisibility/syntheticPropertyExtensions.kt

@@ -23,7 +23,7 @@ class B : A() {
 
         a.<!INVISIBLE_MEMBER!>foo<!>
         // TODO: should be INVISIBLE_SETTER
-        a.bar = a.bar + ""
+        a.<!INVISIBLE_SETTER!>bar<!> = a.bar + ""
 
         if (a is B) {
             <!DEBUG_INFO_SMARTCAST!>a<!>.foo
@@ -34,12 +34,12 @@ class B : A() {
             d.x.abc // Ok
             d.x.<!INVISIBLE_MEMBER!>foo<!>
             // TODO: should be INVISIBLE_SETTER
-            d.x.bar = d.x.bar + ""
+            d.x.<!INVISIBLE_SETTER!>bar<!> = d.x.bar + ""
         }
     }
 }
 
 fun baz(a: A) {
     a.<!INVISIBLE_MEMBER!>foo<!>
-    <!INVISIBLE_SETTER!>a.bar<!> = a.bar + ""
+    <!INVISIBLE_SETTER!>a.<!INVISIBLE_SETTER!>bar<!><!> = a.bar + ""
 }

compiler/testData/diagnostics/tests/scopes/protectedVisibility/syntheticSAMExtensions.kt

@@ -17,7 +17,7 @@ class B : A() {
         b.foo { }
 
         if (a is B) {
-            <!DEBUG_INFO_SMARTCAST!>a<!>.foo {}
+            <!OI;DEBUG_INFO_SMARTCAST!>a<!>.<!NI;INVISIBLE_MEMBER!>foo<!> {}
         }
 
         if (d.x is B) {

compiler/testData/diagnostics/tests/syntheticExtensions/javaProperties/OnlyPublic.kt

@@ -8,7 +8,7 @@ fun foo(javaClass: JavaClass) {
     javaClass.<!INVISIBLE_MEMBER!>somethingProtected<!>
     javaClass.<!UNRESOLVED_REFERENCE!>somethingPrivate<!>
     javaClass.<!INVISIBLE_MEMBER!>somethingPackage<!>
-    <!INVISIBLE_SETTER!>javaClass.somethingPublic<!> = 1
+    <!INVISIBLE_SETTER!>javaClass.<!INVISIBLE_SETTER!>somethingPublic<!><!> = 1
 }
 
 // FILE: JavaClass.java

compiler/testData/diagnostics/tests/visibility/invisibleSetterOfJavaClass.fir.kt

@@ -0,0 +1,29 @@
+// !LANGUAGE: +ImproveReportingDiagnosticsOnProtectedMembersOfBaseClass
+
+// FILE: abc/Foo.java
+package abc;
+
+public class Foo {
+    public String getBar() { return ""; }
+    protected void setBar(String x) {  }
+    public String getFoo() { return ""; }
+    private void setFoo(String x) {  }
+}
+
+// FILE: main.kt
+
+import abc.Foo
+
+class Data(var x: Foo)
+
+class B : Foo() {
+    fun baz(a: Foo, t: Foo, d: Data) {
+        a.bar = t.bar
+        a.foo = t.foo
+
+        if (d.x is B) {
+            d.x.bar = d.x.bar + ""
+            d.x.foo = d.x.foo + ""
+        }
+    }
+}

compiler/testData/diagnostics/tests/visibility/invisibleSetterOfJavaClass.kt

@@ -0,0 +1,29 @@
+// !LANGUAGE: +ImproveReportingDiagnosticsOnProtectedMembersOfBaseClass
+
+// FILE: abc/Foo.java
+package abc;
+
+public class Foo {
+    public String getBar() { return ""; }
+    protected void setBar(String x) {  }
+    public String getFoo() { return ""; }
+    private void setFoo(String x) {  }
+}
+
+// FILE: main.kt
+
+import abc.Foo
+
+class Data(var x: Foo)
+
+class B : Foo() {
+    fun baz(a: Foo, t: Foo, d: Data) {
+        a.<!INVISIBLE_SETTER!>bar<!> = t.bar
+        <!VAL_REASSIGNMENT!>a.foo<!> = t.foo
+
+        if (d.x is B) {
+            d.x.<!INVISIBLE_SETTER!>bar<!> = d.x.bar + ""
+            d.x.foo = d.x.foo + ""
+        }
+    }
+}

compiler/testData/diagnostics/tests/visibility/invisibleSetterOfJavaClass.txt

@@ -0,0 +1,35 @@
+package
+
+public final class B : abc.Foo {
+    public constructor B()
+    public final fun baz(/*0*/ a: abc.Foo, /*1*/ t: abc.Foo, /*2*/ d: Data): kotlin.Unit
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ /*fake_override*/ fun getBar(): kotlin.String!
+    public open override /*1*/ /*fake_override*/ fun getFoo(): kotlin.String!
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    protected/*protected and package*/ open override /*1*/ /*fake_override*/ fun setBar(/*0*/ x: kotlin.String!): kotlin.Unit
+    invisible_fake open override /*1*/ /*fake_override*/ fun setFoo(/*0*/ x: kotlin.String!): kotlin.Unit
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class Data {
+    public constructor Data(/*0*/ x: abc.Foo)
+    public final var x: abc.Foo
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+package abc {
+
+    public open class Foo {
+        public constructor Foo()
+        public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+        public open fun getBar(): kotlin.String!
+        public open fun getFoo(): kotlin.String!
+        public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+        protected/*protected and package*/ open fun setBar(/*0*/ x: kotlin.String!): kotlin.Unit
+        private open fun setFoo(/*0*/ x: kotlin.String!): kotlin.Unit
+        public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+    }
+}

compiler/testData/diagnostics/tests/visibility/invisibleSetterOfJavaClassWithDisabledFeature.fir.kt

@@ -0,0 +1,29 @@
+// !LANGUAGE: -ImproveReportingDiagnosticsOnProtectedMembersOfBaseClass
+
+// FILE: abc/Foo.java
+package abc;
+
+public class Foo {
+    public String getBar() { return ""; }
+    protected void setBar(String x) {  }
+    public String getFoo() { return ""; }
+    private void setFoo(String x) {  }
+}
+
+// FILE: main.kt
+
+import abc.Foo
+
+class Data(var x: Foo)
+
+class B : Foo() {
+    fun baz(a: Foo, t: Foo, d: Data) {
+        a.bar = t.bar
+        a.foo = t.foo
+
+        if (d.x is B) {
+            d.x.bar = d.x.bar + ""
+            d.x.foo = d.x.foo + ""
+        }
+    }
+}

compiler/testData/diagnostics/tests/visibility/invisibleSetterOfJavaClassWithDisabledFeature.kt

@@ -0,0 +1,29 @@
+// !LANGUAGE: -ImproveReportingDiagnosticsOnProtectedMembersOfBaseClass
+
+// FILE: abc/Foo.java
+package abc;
+
+public class Foo {
+    public String getBar() { return ""; }
+    protected void setBar(String x) {  }
+    public String getFoo() { return ""; }
+    private void setFoo(String x) {  }
+}
+
+// FILE: main.kt
+
+import abc.Foo
+
+class Data(var x: Foo)
+
+class B : Foo() {
+    fun baz(a: Foo, t: Foo, d: Data) {
+        a.bar = t.bar
+        <!VAL_REASSIGNMENT!>a.foo<!> = t.foo
+
+        if (d.x is B) {
+            d.x.bar = d.x.bar + ""
+            d.x.foo = d.x.foo + ""
+        }
+    }
+}

compiler/testData/diagnostics/tests/visibility/invisibleSetterOfJavaClassWithDisabledFeature.txt

@@ -0,0 +1,35 @@
+package
+
+public final class B : abc.Foo {
+    public constructor B()
+    public final fun baz(/*0*/ a: abc.Foo, /*1*/ t: abc.Foo, /*2*/ d: Data): kotlin.Unit
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ /*fake_override*/ fun getBar(): kotlin.String!
+    public open override /*1*/ /*fake_override*/ fun getFoo(): kotlin.String!
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    protected/*protected and package*/ open override /*1*/ /*fake_override*/ fun setBar(/*0*/ x: kotlin.String!): kotlin.Unit
+    invisible_fake open override /*1*/ /*fake_override*/ fun setFoo(/*0*/ x: kotlin.String!): kotlin.Unit
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class Data {
+    public constructor Data(/*0*/ x: abc.Foo)
+    public final var x: abc.Foo
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+package abc {
+
+    public open class Foo {
+        public constructor Foo()
+        public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+        public open fun getBar(): kotlin.String!
+        public open fun getFoo(): kotlin.String!
+        public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+        protected/*protected and package*/ open fun setBar(/*0*/ x: kotlin.String!): kotlin.Unit
+        private open fun setFoo(/*0*/ x: kotlin.String!): kotlin.Unit
+        public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+    }
+}

compiler/testData/diagnostics/tests/visibility/lackOfInvisibleSetterOfJavaClassInSamePackage.fir.kt

@@ -0,0 +1,23 @@
+// FILE: Foo.java
+public class Foo {
+    public String getBar() { return ""; }
+    protected void setBar(String x) {  }
+    public String getFoo() { return ""; }
+    private void setFoo(String x) {  }
+}
+
+// FILE: main.kt
+
+class Data(var x: Foo)
+
+class B : Foo() {
+    fun baz(a: Foo, t: Foo, d: Data) {
+        a.bar = t.bar
+        a.foo = t.foo
+
+        if (d.x is B) {
+            d.x.bar = d.x.bar + ""
+            d.x.foo = d.x.foo + ""
+        }
+    }
+}

compiler/testData/diagnostics/tests/visibility/lackOfInvisibleSetterOfJavaClassInSamePackage.kt

@@ -0,0 +1,23 @@
+// FILE: Foo.java
+public class Foo {
+    public String getBar() { return ""; }
+    protected void setBar(String x) {  }
+    public String getFoo() { return ""; }
+    private void setFoo(String x) {  }
+}
+
+// FILE: main.kt
+
+class Data(var x: Foo)
+
+class B : Foo() {
+    fun baz(a: Foo, t: Foo, d: Data) {
+        a.bar = t.bar
+        <!VAL_REASSIGNMENT!>a.foo<!> = t.foo
+
+        if (d.x is B) {
+            d.x.bar = d.x.bar + ""
+            d.x.foo = d.x.foo + ""
+        }
+    }
+}

compiler/testData/diagnostics/tests/visibility/lackOfInvisibleSetterOfJavaClassInSamePackage.txt

@@ -0,0 +1,32 @@
+package
+
+public final class B : Foo {
+    public constructor B()
+    public final fun baz(/*0*/ a: Foo, /*1*/ t: Foo, /*2*/ d: Data): kotlin.Unit
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ /*fake_override*/ fun getBar(): kotlin.String!
+    public open override /*1*/ /*fake_override*/ fun getFoo(): kotlin.String!
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    protected/*protected and package*/ open override /*1*/ /*fake_override*/ fun setBar(/*0*/ x: kotlin.String!): kotlin.Unit
+    invisible_fake open override /*1*/ /*fake_override*/ fun setFoo(/*0*/ x: kotlin.String!): kotlin.Unit
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class Data {
+    public constructor Data(/*0*/ x: Foo)
+    public final var x: Foo
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public open class Foo {
+    public constructor Foo()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open fun getBar(): kotlin.String!
+    public open fun getFoo(): kotlin.String!
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    protected/*protected and package*/ open fun setBar(/*0*/ x: kotlin.String!): kotlin.Unit
+    private open fun setFoo(/*0*/ x: kotlin.String!): kotlin.Unit
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}