azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

JPS plugin: remove unnecessary method KotlinSourceFileCollector#hasDirtyFiles.

Browse Source
This commit is contained in:
Zalim Bashorov
2013-10-01 19:46:56 +04:00
parent b6f3baa485
commit fc6b77366a
2 changed files with 1 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jps-plugin/src/org/jetbrains/jet/jps/build/KotlinBuilder.java
+1 -1
View File
@@ -98,7 +98,7 @@ public class KotlinBuilder extends ModuleLevelBuilder {
ModuleBuildTarget representativeTarget = chunk.representativeTarget(); ModuleBuildTarget representativeTarget = chunk.representativeTarget();
// For non-incremental build: take all sources // For non-incremental build: take all sources
if (!KotlinSourceFileCollector.hasDirtyFiles(dirtyFilesHolder)) { if (!dirtyFilesHolder.hasDirtyFiles()) {
return ExitCode.NOTHING_DONE; return ExitCode.NOTHING_DONE;
} }
List<File> sourceFiles = KotlinSourceFileCollector.getAllKotlinSourceFiles(representativeTarget); List<File> sourceFiles = KotlinSourceFileCollector.getAllKotlinSourceFiles(representativeTarget);
jps-plugin/src/org/jetbrains/jet/jps/build/KotlinSourceFileCollector.java
-16
View File
@@ -16,7 +16,6 @@
package org.jetbrains.jet.jps.build; package org.jetbrains.jet.jps.build;
import com.intellij.openapi.util.Ref;
import com.intellij.openapi.util.io.FileUtil; import com.intellij.openapi.util.io.FileUtil;
import com.intellij.util.Processor; import com.intellij.util.Processor;
import com.intellij.util.containers.ContainerUtil; import com.intellij.util.containers.ContainerUtil;
@@ -51,21 +50,6 @@ public class KotlinSourceFileCollector {
return sourceFiles; return sourceFiles;
} }
// For incremental compilation
public static boolean hasDirtyFiles(DirtyFilesHolder<JavaSourceRootDescriptor, ModuleBuildTarget> dirtyFilesHolder)
throws IOException {
final Ref<Boolean> result = Ref.create(false);
dirtyFilesHolder.processDirtyFiles(new FileProcessor<JavaSourceRootDescriptor, ModuleBuildTarget>() {
@Override
public boolean apply(ModuleBuildTarget target, File file, JavaSourceRootDescriptor root) throws IOException {
result.set(true);
return false;
}
});
return result.get();
}
@NotNull @NotNull
public static List<File> getAllKotlinSourceFiles(@NotNull ModuleBuildTarget target) { public static List<File> getAllKotlinSourceFiles(@NotNull ModuleBuildTarget target) {
final List<File> result = ContainerUtil.newArrayList(); final List<File> result = ContainerUtil.newArrayList();