azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

K1: report a warning for invisible setter accessed from a derived class

Browse Source 
The issue is that during binding fake overrides, the compiler doesn't
 differ setters from its properties, so the compiler uses the same
 visibility for setter and entire property.

 Changing logic at the binding stage can cause some unpredictable consequences so
 the fix is to do this differentiation right at the reporting stage

 ^KT-56662 Fixed

Merge-request: KT-MR-9565
Merged-by: Michail Zarečenskij <Mikhail.Zarechenskiy@jetbrains.com>
This commit is contained in:
Mikhail Zarechenskiy
2023-04-17 11:08:16 +00:00
committed by Space Team
parent d8f253d07b
commit fc37885d6d
14 changed files with 332 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/DiagnosticCompilerTestFE10TestdataTestGenerated.java
Generated
+12
View File
@@ -27554,6 +27554,18 @@ public class DiagnosticCompilerTestFE10TestdataTestGenerated extends AbstractDia
runTest("compiler/testData/diagnostics/tests/scopes/initializerScopeOfExtensionProperty.kt");
}
@Test
@TestMetadata("invisibleInternalSetterAccessFromDeriviedClass.kt")
public void testInvisibleInternalSetterAccessFromDeriviedClass() throws Exception {
runTest("compiler/testData/diagnostics/tests/scopes/invisibleInternalSetterAccessFromDeriviedClass.kt");
}
@Test
@TestMetadata("invisibleInternalSetterAccessFromDeriviedClassOn.kt")
public void testInvisibleInternalSetterAccessFromDeriviedClassOn() throws Exception {
runTest("compiler/testData/diagnostics/tests/scopes/invisibleInternalSetterAccessFromDeriviedClassOn.kt");
}
@Test
@TestMetadata("invisibleSetter.kt")
public void testInvisibleSetter() throws Exception {
analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/LLFirPreresolvedReversedDiagnosticCompilerFE10TestDataTestGenerated.java
Generated
+12
View File
@@ -27554,6 +27554,18 @@ public class LLFirPreresolvedReversedDiagnosticCompilerFE10TestDataTestGenerated
runTest("compiler/testData/diagnostics/tests/scopes/initializerScopeOfExtensionProperty.kt");
}
@Test
@TestMetadata("invisibleInternalSetterAccessFromDeriviedClass.kt")
public void testInvisibleInternalSetterAccessFromDeriviedClass() throws Exception {
runTest("compiler/testData/diagnostics/tests/scopes/invisibleInternalSetterAccessFromDeriviedClass.kt");
}
@Test
@TestMetadata("invisibleInternalSetterAccessFromDeriviedClassOn.kt")
public void testInvisibleInternalSetterAccessFromDeriviedClassOn() throws Exception {
runTest("compiler/testData/diagnostics/tests/scopes/invisibleInternalSetterAccessFromDeriviedClassOn.kt");
}
@Test
@TestMetadata("invisibleSetter.kt")
public void testInvisibleSetter() throws Exception {