From facee840202840a45e11f04ec31163de810deb0f Mon Sep 17 00:00:00 2001 From: Mikhael Bogdanov Date: Mon, 12 Dec 2016 16:10:19 +0100 Subject: [PATCH] Temporary remove JVM_1_8 target from facet settings --- .../org/jetbrains/kotlin/config/KotlinFacetSettings.kt | 10 +++------- .../configuration/KotlinCompilerConfigurableTab.java | 4 +--- idea/src/org/jetbrains/kotlin/idea/facet/facetUtils.kt | 10 ++-------- 3 files changed, 6 insertions(+), 18 deletions(-) diff --git a/idea/idea-jps-common/src/org/jetbrains/kotlin/config/KotlinFacetSettings.kt b/idea/idea-jps-common/src/org/jetbrains/kotlin/config/KotlinFacetSettings.kt index 0c2fd311d3a..e5315348240 100644 --- a/idea/idea-jps-common/src/org/jetbrains/kotlin/config/KotlinFacetSettings.kt +++ b/idea/idea-jps-common/src/org/jetbrains/kotlin/config/KotlinFacetSettings.kt @@ -31,12 +31,8 @@ sealed class TargetPlatformKind( ) : DescriptionAware { override val description = "$name ${version.description}" - class Jvm(version: JvmTarget) : TargetPlatformKind(version, "JVM") { - companion object { - val JVM_PLATFORMS by lazy { JvmTarget.values().map(::Jvm) } - - operator fun get(version: JvmTarget) = JVM_PLATFORMS[version.ordinal] - } + sealed class Jvm(version: JvmTarget) : TargetPlatformKind(version, "JVM") { + object JVM_1_6 : Jvm(JvmTarget.JVM_1_6) } object JavaScript : TargetPlatformKind(NoVersion, "JavaScript") @@ -44,7 +40,7 @@ sealed class TargetPlatformKind( object Default : TargetPlatformKind(NoVersion, "Default (experimental)") companion object { - val ALL_PLATFORMS: List> by lazy { Jvm.JVM_PLATFORMS + JavaScript + Default } + val ALL_PLATFORMS: List> by lazy { listOf(Jvm.JVM_1_6, JavaScript, Default) } } } diff --git a/idea/src/org/jetbrains/kotlin/idea/compiler/configuration/KotlinCompilerConfigurableTab.java b/idea/src/org/jetbrains/kotlin/idea/compiler/configuration/KotlinCompilerConfigurableTab.java index fe02a2ae1b0..2e8fd5ab602 100644 --- a/idea/src/org/jetbrains/kotlin/idea/compiler/configuration/KotlinCompilerConfigurableTab.java +++ b/idea/src/org/jetbrains/kotlin/idea/compiler/configuration/KotlinCompilerConfigurableTab.java @@ -140,9 +140,7 @@ public class KotlinCompilerConfigurableTab implements SearchableConfigurable, Co @SuppressWarnings("unchecked") private void fillJvmVersionList() { - for (TargetPlatformKind.Jvm jvm : TargetPlatformKind.Jvm.Companion.getJVM_PLATFORMS()) { - jvmVersionComboBox.addItem(jvm.getVersion().getDescription()); - } + jvmVersionComboBox.addItem(TargetPlatformKind.Jvm.JVM_1_6.INSTANCE.getVersion().getDescription()); } @SuppressWarnings("unchecked") diff --git a/idea/src/org/jetbrains/kotlin/idea/facet/facetUtils.kt b/idea/src/org/jetbrains/kotlin/idea/facet/facetUtils.kt index 18ea83c8658..ca0fb17b2b1 100644 --- a/idea/src/org/jetbrains/kotlin/idea/facet/facetUtils.kt +++ b/idea/src/org/jetbrains/kotlin/idea/facet/facetUtils.kt @@ -69,13 +69,7 @@ private fun getDefaultTargetPlatform(module: Module, rootModel: ModuleRootModel? if (getRuntimeLibraryVersions(module, rootModel, TargetPlatformKind.JavaScript).isNotEmpty()) { return TargetPlatformKind.JavaScript } - - val sdk = ((rootModel ?: ModuleRootManager.getInstance(module))).sdk - val sdkVersion = (sdk?.sdkType as? JavaSdk)?.getVersion(sdk!!) - return when { - sdkVersion == null || sdkVersion >= JavaSdkVersion.JDK_1_8 -> TargetPlatformKind.Jvm[JvmTarget.JVM_1_8] - else -> TargetPlatformKind.Jvm[JvmTarget.JVM_1_6] - } + return TargetPlatformKind.Jvm.JVM_1_6 } private fun getDefaultLanguageLevel( @@ -98,7 +92,7 @@ internal fun getLibraryLanguageLevel( rootModel: ModuleRootModel?, targetPlatform: TargetPlatformKind<*>? ): LanguageVersion { - val minVersion = getRuntimeLibraryVersions(module, rootModel, targetPlatform ?: TargetPlatformKind.Jvm[JvmTarget.JVM_1_8]) + val minVersion = getRuntimeLibraryVersions(module, rootModel, targetPlatform ?: TargetPlatformKind.Jvm.JVM_1_6) .minWith(VersionComparatorUtil.COMPARATOR) return getDefaultLanguageLevel(module, minVersion) }