kotlin.test: 'fail' returns Nothing, 'assertFails' returns Throwable (not nullable).

Js tests now fail at the first failed assertion.
#KT-10289 Fixed
#KT-10369 Fixed

js/js.libraries/src/core/javalang.kt

@@ -27,6 +27,9 @@ public class NumberFormatException(message: String? = null) : RuntimeException(m
 @library
 public class NullPointerException(message: String? = null) : RuntimeException(message) {}
 
+@library
+public class AssertionError(message: String? = null) : Error(message) {}
+
 @library
 public interface Runnable {
     public open fun run() : Unit;

js/js.libraries/src/stdlib/testCode.kt

@@ -18,14 +18,23 @@ public var asserter: Asserter = QUnitAsserter()
 public class QUnitAsserter(): Asserter {
 
     public override fun assertTrue(lazyMessage: () -> String?, actual: Boolean) {
-        QUnit.ok(actual, lazyMessage())
+        assertTrue(actual, lazyMessage())
     }
 
     public override fun assertTrue(message: String?, actual: Boolean) {
         QUnit.ok(actual, message)
+        if (!actual) failWithMessage(message)
     }
 
-    public override fun fail(message: String?) {
+    public override fun fail(message: String?): Nothing {
         QUnit.ok(false, message)
+        failWithMessage(message)
+    }
+
+    private fun failWithMessage(message: String?): Nothing {
+        if (message == null)
+            throw AssertionError()
+        else
+            throw AssertionError(message)
     }
 }

js/js.translator/testData/jsTester/jsTester.js

@@ -21,11 +21,15 @@ var JsTests = (function () {
 
     var assert = function (isTrue, message) {
         if (!isTrue) {
-            reporter.reportError(message);
+            fail(message);
-            throw failedTest;
         }
     };
 
+    var fail = function (message) {
+        reporter.reportError(message);
+        throw failedTest;
+    };
+
     var init = function () {
         init = function() {};
         Kotlin.modules["JS_TESTS"].kotlin.test.init();
@@ -49,6 +53,7 @@ var JsTests = (function () {
     };
     return {
         test: test,
-        assert: assert
+        assert: assert,
+        fail: fail
     }
 })();

js/js.translator/testData/jsTester/jsTester.kt

@@ -7,10 +7,11 @@ fun init() {
 }
 
 public class JsTestsAsserter() : Asserter {
-    public override fun fail(message: String?) {
+    public override fun fail(message: String?): Nothing = failWithMessage(message)
-        assert(false, message)
-    }
 }
 
 @native("JsTests.assert")
 public fun assert(value: Boolean, message: String?): Unit = noImpl
+
+@native("JsTests.fail")
+private fun failWithMessage(message: String?): Nothing = noImpl

js/js.translator/testData/kotlin_lib.js

@@ -200,6 +200,7 @@
     Kotlin.UnsupportedOperationException = createClassNowWithMessage(Kotlin.RuntimeException);
     Kotlin.IndexOutOfBoundsException = createClassNowWithMessage(Kotlin.RuntimeException);
     Kotlin.IOException = createClassNowWithMessage(Kotlin.Exception);
+    Kotlin.AssertionError = createClassNowWithMessage(Kotlin.Error);
 
     Kotlin.throwNPE = function (message) {
         throw new Kotlin.NullPointerException(message);

libraries/kotlin.test/junit/src/main/kotlin/JUnitSupport.kt

@@ -35,7 +35,9 @@ object JUnitAsserter : Asserter {
         Assert.assertNull(message ?: "actual value is not null", actual)
     }
 
-    override fun fail(message : String?) {
+    override fun fail(message : String?): Nothing {
         Assert.fail(message)
+        // should not get here
+        throw AssertionError(message)
     }
 }

libraries/kotlin.test/shared/src/main/kotlin.jvm/kotlin/test/TestAssertionsJVM.kt

@@ -22,11 +22,9 @@ fun <T : Throwable> assertFailsWith(exceptionClass: Class<T>, message: String?,
             return e as T
         }
         asserter.fail((message?.let { "$it. " } ?: "") + "Expected an exception of type $exceptionClass to be thrown, but was $e")
-        throw e
     }
     val msg = message?.let { "$it. " } ?: ""
     asserter.fail(msg + "Expected an exception of type $exceptionClass to be thrown, but was completed successfully.")
-    throw IllegalStateException(msg + "Should have failed.")
 }
 
 /** Asserts that a [block] fails with a specific exception of type [exceptionClass] being thrown. */

libraries/kotlin.test/shared/src/main/kotlin/kotlin/test/DefaultAsserter.kt

@@ -5,7 +5,7 @@ package kotlin.test
  */
 class DefaultAsserter() : Asserter {
 
-    override fun fail(message: String?) {
+    override fun fail(message: String?): Nothing {
         if (message == null)
             throw AssertionError()
         else

libraries/kotlin.test/shared/src/main/kotlin/kotlin/test/TestAssertions.kt

@@ -63,7 +63,7 @@ fun assertNull(actual: Any?, message: String? = null) {
 }
 
 /** Marks a test as having failed if this point in the execution path is reached, with an optional [message]. */
-fun fail(message: String? = null) {
+fun fail(message: String? = null): Nothing {
     asserter.fail(message)
 }
 
@@ -81,16 +81,13 @@ fun <@OnlyInputTypes T> expect(expected: T, message: String?, block: () -> T) {
 fun fails(block: () -> Unit): Throwable? = assertFails(block)
 
 /** Asserts that given function [block] fails by throwing an exception. */
-fun assertFails(block: () -> Unit): Throwable? {
+fun assertFails(block: () -> Unit): Throwable {
-    var thrown: Throwable? = null
     try {
         block()
     } catch (e: Throwable) {
-        thrown = e
+        return e
     }
-    if (thrown == null)
+    asserter.fail("Expected an exception to be thrown")
-        asserter.fail("Expected an exception to be thrown")
-    return thrown
 }
 
 /**
@@ -103,7 +100,7 @@ interface Asserter {
      *
      * @param message the message to report.
      */
-    fun fail(message: String?): Unit
+    fun fail(message: String?): Nothing
 
     /**
      * Asserts that the specified value is `true`.