KTIJ-25232 [FIR IDE] Do not shorten properties with non-trivial receiver

If property call receiver is something real (like another property or a
function call), then it should not be shortened because the semantics
might change

^KTIJ-25232 Fixed

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/components/KtFirReferenceShortener.kt

@@ -874,6 +874,10 @@ private class ElementsToShortenCollector(
         val availableCallables = shorteningContext.findPropertiesInScopes(scopes, callableSymbol.name)
 
         val firPropertyAccess = qualifiedProperty.getOrBuildFir(firResolveSession) as? FirQualifiedAccessExpression ?: return
+
+        // if explicit receiver is a property access or a function call, we cannot shorten it
+        if (firPropertyAccess.explicitReceiver !is FirResolvedQualifier) return
+
         if (availableCallables.isNotEmpty() && shortenIfAlreadyImported(firPropertyAccess, callableSymbol, referenceExpression)) {
             addElementToShorten(ShortenQualifier(qualifiedProperty))
             return

analysis/analysis-api-fir/tests-gen/org/jetbrains/kotlin/analysis/api/fir/test/cases/generated/cases/references/FirIdeNormalAnalysisSourceModuleReferenceShortenerTestGenerated.java

@@ -298,6 +298,18 @@ public class FirIdeNormalAnalysisSourceModuleReferenceShortenerTestGenerated ext
         runTest("analysis/analysis-api/testData/components/referenceShortener/referenceShortener/sameTypeNamesWithinSameScopes.kt");
     }
 
+    @Test
+    @TestMetadata("selfPropertyChain.kt")
+    public void testSelfPropertyChain() throws Exception {
+        runTest("analysis/analysis-api/testData/components/referenceShortener/referenceShortener/selfPropertyChain.kt");
+    }
+
+    @Test
+    @TestMetadata("selfPropertyChain1.kt")
+    public void testSelfPropertyChain1() throws Exception {
+        runTest("analysis/analysis-api/testData/components/referenceShortener/referenceShortener/selfPropertyChain1.kt");
+    }
+
     @Test
     @TestMetadata("shortenAlreadyImportedClass.kt")
     public void testShortenAlreadyImportedClass() throws Exception {

analysis/analysis-api-standalone/tests-gen/org/jetbrains/kotlin/analysis/api/standalone/fir/test/cases/generated/cases/references/FirStandaloneNormalAnalysisSourceModuleReferenceShortenerTestGenerated.java

@@ -298,6 +298,18 @@ public class FirStandaloneNormalAnalysisSourceModuleReferenceShortenerTestGenera
         runTest("analysis/analysis-api/testData/components/referenceShortener/referenceShortener/sameTypeNamesWithinSameScopes.kt");
     }
 
+    @Test
+    @TestMetadata("selfPropertyChain.kt")
+    public void testSelfPropertyChain() throws Exception {
+        runTest("analysis/analysis-api/testData/components/referenceShortener/referenceShortener/selfPropertyChain.kt");
+    }
+
+    @Test
+    @TestMetadata("selfPropertyChain1.kt")
+    public void testSelfPropertyChain1() throws Exception {
+        runTest("analysis/analysis-api/testData/components/referenceShortener/referenceShortener/selfPropertyChain1.kt");
+    }
+
     @Test
     @TestMetadata("shortenAlreadyImportedClass.kt")
     public void testShortenAlreadyImportedClass() throws Exception {

analysis/analysis-api/testData/components/referenceShortener/referenceShortener/selfPropertyChain.kt

@@ -0,0 +1,15 @@
+// FILE: main.kt
+package foo
+
+class Foo {
+    val self = this
+
+    fun selfFun(): Foo = this
+
+    <expr>
+    fun check() {
+        self.self
+        selfFun().self
+    }
+    </expr>
+}

analysis/analysis-api/testData/components/referenceShortener/referenceShortener/selfPropertyChain.txt

@@ -0,0 +1,8 @@
+Before shortening: fun check() {
+        self.self
+        selfFun().self
+    }
+with DO_NOT_SHORTEN:
+with SHORTEN_IF_ALREADY_IMPORTED:
+with SHORTEN_AND_IMPORT:
+with SHORTEN_AND_STAR_IMPORT:

analysis/analysis-api/testData/components/referenceShortener/referenceShortener/selfPropertyChain1.kt

@@ -0,0 +1,15 @@
+// FILE: main.kt
+package foo
+
+object Foo {
+    val self = this
+
+    fun selfFun(): Foo = this
+
+    <expr>
+    fun check() {
+        self.self
+        selfFun().self
+    }
+    </expr>
+}

analysis/analysis-api/testData/components/referenceShortener/referenceShortener/selfPropertyChain1.txt

@@ -0,0 +1,8 @@
+Before shortening: fun check() {
+        self.self
+        selfFun().self
+    }
+with DO_NOT_SHORTEN:
+with SHORTEN_IF_ALREADY_IMPORTED:
+with SHORTEN_AND_IMPORT:
+with SHORTEN_AND_STAR_IMPORT: