From f5e5a134e791277a6ad5317c292e480694ecf307 Mon Sep 17 00:00:00 2001 From: Ilya Kirillov Date: Mon, 6 Feb 2023 17:03:55 +0100 Subject: [PATCH] [Analysis API] remove caches from KtSymbolByFirBuilder with very low hit rates ^KTIJ-22749 --- .../kotlin/analysis/api/fir/KtSymbolByFirBuilder.kt | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/KtSymbolByFirBuilder.kt b/analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/KtSymbolByFirBuilder.kt index ba338880ca3..1a5e3844130 100644 --- a/analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/KtSymbolByFirBuilder.kt +++ b/analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/KtSymbolByFirBuilder.kt @@ -78,9 +78,6 @@ internal class KtSymbolByFirBuilder constructor( val rootSession: FirSession = firResolveSession.useSiteFirSession private val symbolsCache = BuilderCache, KtSymbol>() - private val extensionReceiverSymbolsCache = BuilderCache, KtSymbol>() - private val filesCache = BuilderCache() - private val backingFieldCache = BuilderCache() val classifierBuilder = ClassifierSymbolBuilder() val functionLikeBuilder = FunctionLikeSymbolBuilder() @@ -105,7 +102,7 @@ internal class KtSymbolByFirBuilder constructor( fun buildEnumEntrySymbol(firSymbol: FirEnumEntrySymbol) = symbolsCache.cache(firSymbol) { KtFirEnumEntrySymbol(firSymbol, analysisSession) } - fun buildFileSymbol(firSymbol: FirFileSymbol) = filesCache.cache(firSymbol) { KtFirFileSymbol(firSymbol, analysisSession) } + fun buildFileSymbol(firSymbol: FirFileSymbol) = KtFirFileSymbol(firSymbol, analysisSession) private val packageProvider = project.createPackageProvider(GlobalSearchScope.allScope(project))//todo scope @@ -348,9 +345,7 @@ internal class KtSymbolByFirBuilder constructor( } fun buildBackingFieldSymbol(firSymbol: FirBackingFieldSymbol): KtFirBackingFieldSymbol { - return backingFieldCache.cache(firSymbol) { - KtFirBackingFieldSymbol(firSymbol, analysisSession) - } + return KtFirBackingFieldSymbol(firSymbol, analysisSession) } fun buildBackingFieldSymbolByProperty(firSymbol: FirPropertySymbol): KtFirBackingFieldSymbol { @@ -409,9 +404,7 @@ internal class KtSymbolByFirBuilder constructor( fun buildExtensionReceiverSymbol(firCallableSymbol: FirCallableSymbol<*>): KtReceiverParameterSymbol? { if (firCallableSymbol.fir.receiverParameter == null) return null - return extensionReceiverSymbolsCache.cache(firCallableSymbol) { - KtFirReceiverParameterSymbol(firCallableSymbol, analysisSession) - } + return KtFirReceiverParameterSymbol(firCallableSymbol, analysisSession) } }