azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CLI: make message bold only for errors and warnings

Browse Source 
Info, logging and output are not important enough to appear bold every time
This commit is contained in:
Alexander Udalov
2015-06-26 03:22:45 +03:00
parent 499579274d
commit f52bc8a2d2
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/cli/src/org/jetbrains/kotlin/cli/common/messages/PlainTextMessageRenderer.java
+12 -2
View File
@@ -24,6 +24,11 @@ import org.fusesource.jansi.internal.CLibrary;
import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable; import org.jetbrains.annotations.Nullable;
import java.util.EnumSet;
import java.util.Set;
import static org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.*;
public abstract class PlainTextMessageRenderer implements MessageRenderer { public abstract class PlainTextMessageRenderer implements MessageRenderer {
// AnsiConsole doesn't check isatty() for stderr (see https://github.com/fusesource/jansi/pull/35). // AnsiConsole doesn't check isatty() for stderr (see https://github.com/fusesource/jansi/pull/35).
// TODO: investigate why ANSI escape codes on Windows only work in REPL for some reason // TODO: investigate why ANSI escape codes on Windows only work in REPL for some reason
@@ -33,6 +38,8 @@ public abstract class PlainTextMessageRenderer implements MessageRenderer {
private static final String LINE_SEPARATOR = LineSeparator.getSystemLineSeparator().getSeparatorString(); private static final String LINE_SEPARATOR = LineSeparator.getSystemLineSeparator().getSeparatorString();
private static final Set<CompilerMessageSeverity> IMPORTANT_MESSAGE_SEVERITIES = EnumSet.of(EXCEPTION, ERROR, WARNING);
@Override @Override
public String renderPreamble() { public String renderPreamble() {
return ""; return "";
@@ -67,8 +74,11 @@ public abstract class PlainTextMessageRenderer implements MessageRenderer {
.fg(severityColor(severity)) .fg(severityColor(severity))
.a(severity.name().toLowerCase()) .a(severity.name().toLowerCase())
.a(": ") .a(": ")
.reset() .reset();
.bold();
if (IMPORTANT_MESSAGE_SEVERITIES.contains(severity)) {
ansi.bold();
}
// Only make the first line of the message bold. Otherwise long overload ambiguity errors or exceptions are hard to read // Only make the first line of the message bold. Otherwise long overload ambiguity errors or exceptions are hard to read
String decapitalized = decapitalizeIfNeeded(message); String decapitalized = decapitalizeIfNeeded(message);