Add tests for folding/unfolding operations

generators/org/jetbrains/jet/generators/tests/GenerateTests.java

@@ -306,8 +306,7 @@ public class GenerateTests {
                 "CodeTransformationsTestGenerated",
                 AbstractCodeTransformationTest.class,
                 testModel("idea/testData/codeInsight/codeTransformations/ifStatementWithAssignmentsToExpression", "doTestIfStatementWithAssignmentsToExpression"),
-                testModel("idea/testData/codeInsight/codeTransformations/assignmentWithIfExpressionToStatement", "doTestAssignmentWithIfExpressionToStatement"),
+                testModel("idea/testData/codeInsight/codeTransformations/assignmentWithIfExpressionToStatement", "doTestAssignmentWithIfExpressionToStatement")
-                testModel("idea/testData/codeInsight/codeTransformations/removeUnnecessaryParentheses", "doTestRemoveUnnecessaryParentheses")
         );
 
         generateTest(

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/innerWhenTransformed.kt

@@ -0,0 +1,21 @@
+fun test(n: Int): String {
+    var res: String
+
+    if (3 > 2) {
+        <caret>when(n) {
+            1 -> {
+                println("***")
+                res = "one"
+            }
+            else -> {
+                println("***")
+                res = "two"
+            }
+        }
+    } else {
+        println("***")
+        res = "???"
+    }
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/innerWhenTransformed.kt.after

@@ -0,0 +1,21 @@
+fun test(n: Int): String {
+    var res: String
+
+    if (3 > 2) {
+        <caret>res = when(n) {
+            1 -> {
+                println("***")
+                "one"
+            }
+            else -> {
+                println("***")
+                "two"
+            }
+        }
+    } else {
+        println("***")
+        res = "???"
+    }
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleIf.kt

@@ -0,0 +1,7 @@
+fun test(n: Int): String {
+    var res: String
+
+    <caret>if (n == 1) res = "one" else res = "two"
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleIf.kt.after

@@ -0,0 +1,7 @@
+fun test(n: Int): String {
+    var res: String
+
+    <caret>res = if (n == 1) "one" else "two"
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleIfWithAugmentedAssignment.kt

@@ -0,0 +1,7 @@
+fun test(n: Int): String {
+    var res: String = "!"
+
+    <caret>if (n == 1) res += "one" else res += "two"
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleIfWithAugmentedAssignment.kt.after

@@ -0,0 +1,7 @@
+fun test(n: Int): String {
+    var res: String = "!"
+
+    <caret>res += if (n == 1) "one" else "two"
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleIfWithShadowedVar.kt

@@ -0,0 +1,16 @@
+// IS_APPLICABLE: false
+fun test(n: Int): String {
+    var res: String = ""
+
+    <caret>if (n == 1) {
+        println("***")
+        res = "one"
+    } else {
+        var res: String
+
+        println("***")
+        res = "two"
+    }
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleIfWithUnmatchedAssignmentOps.kt

@@ -0,0 +1,12 @@
+// IS_APPLICABLE: false
+fun test(s: String): Int {
+    var n: Int = 1;
+
+    <caret>if (s.equals("add")) {
+        n += 1
+    } else {
+        n -= 1
+    }
+
+    return n
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleIfWithUnmatchedAssignments.kt

@@ -0,0 +1,13 @@
+// IS_APPLICABLE: false
+fun test(n: Int): String {
+    var res: String = ""
+    var res2: String = ""
+
+    <caret>if (n == 1) {
+        res = "one"
+    } else {
+        res2 = "two"
+    }
+
+    return res + res2
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleWhen.kt

@@ -0,0 +1,10 @@
+fun test(n: Int): String {
+    var res: String
+
+    <caret>when(n) {
+        1 -> res = "one"
+        else -> res = "two"
+    }
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleWhen.kt.after

@@ -0,0 +1,10 @@
+fun test(n: Int): String {
+    var res: String
+
+    <caret>res = when(n) {
+        1 -> "one"
+        else -> "two"
+    }
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleWhenWithBlocks.kt

@@ -0,0 +1,16 @@
+fun test(n: Int): String {
+    var res: String
+
+    <caret>when (n) {
+        1 -> {
+            println("***")
+            res = "one"
+        }
+        else -> {
+            println("***")
+            res = "two"
+        }
+    }
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleWhenWithBlocks.kt.after

@@ -0,0 +1,16 @@
+fun test(n: Int): String {
+    var res: String
+
+    <caret>res = when (n) {
+        1 -> {
+            println("***")
+            "one"
+        }
+        else -> {
+            println("***")
+            "two"
+        }
+    }
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleWhenWithShadowedVar.kt

@@ -0,0 +1,19 @@
+// IS_APPLICABLE: false
+fun test(n: Int): String {
+    var res: String = ""
+
+    <caret>when (n) {
+        1 -> {
+            println("***")
+            res = "one"
+        }
+        else -> {
+            var res: String
+
+            res = "two"
+            println("***")
+        }
+    }
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleWhenWithUnmatchedAssignments.kt

@@ -0,0 +1,18 @@
+// IS_APPLICABLE: false
+fun test(n: Int): String {
+    var res: String = ""
+    var res2: String = ""
+
+    <caret>when (n) {
+        1 -> {
+            println("***")
+            res = "one"
+        }
+        else -> {
+            println("***")
+            res2 = "two"
+        }
+    }
+
+    return res + res2
+}

idea/testData/codeInsight/codeTransformations/branched/folding/assignment/simpleWhenWithoutTerminatingAssignment.kt

@@ -0,0 +1,17 @@
+// IS_APPLICABLE: false
+fun test(n: Int): String {
+    var res: String
+
+    <caret>when (n) {
+            1 -> {
+                println("***")
+                res = "one"
+            }
+            else -> {
+                res = "two"
+                println("***")
+            }
+    }
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/folding/asymmetricReturn/simpleIf.kt

@@ -0,0 +1,4 @@
+fun test(n: Int): String {
+    <caret>if (n == 1) return "one"
+    return "two"
+}

idea/testData/codeInsight/codeTransformations/branched/folding/asymmetricReturn/simpleIf.kt.after

@@ -0,0 +1,3 @@
+fun test(n: Int): String {
+    <caret>return if (n == 1) "one" else "two"
+}

idea/testData/codeInsight/codeTransformations/branched/folding/asymmetricReturn/simpleIfWithBlocks.kt

@@ -0,0 +1,7 @@
+fun test(n: Int): String {
+    <caret>if (n == 1) {
+        println("***")
+        return "one"
+    }
+    return "two"
+}

idea/testData/codeInsight/codeTransformations/branched/folding/asymmetricReturn/simpleIfWithBlocks.kt.after

@@ -0,0 +1,6 @@
+fun test(n: Int): String {
+    <caret>return if (n == 1) {
+        println("***")
+        "one"
+    } else "two"
+}

idea/testData/codeInsight/codeTransformations/branched/folding/return/innerIfTransformed.kt

@@ -1,21 +1,17 @@
 fun test(n: Int): String {
-    var res: String
+    if (n == 1) {
-
+        <caret>if (3 > 2) {
-    <caret>if (n == 1) {
-        if (3 > 2) {
             println("***")
-            res = "one"
+            return "one"
         } else {
             println("***")
-            res = "???"
+            return "???"
         }
     } else if (n == 2) {
         println("***")
-        res = "two"
+        return "two"
     } else {
         println("***")
-        res = "too many"
+        return "too many"
     }
-
-    return res
 }

idea/testData/codeInsight/codeTransformations/branched/folding/return/innerIfTransformed.kt.after

@@ -1,21 +1,17 @@
 fun test(n: Int): String {
-    var res: String
+    if (n == 1) {
-
+        <caret>return if (3 > 2) {
-    <caret>if (n == 1) {
-        if (3 > 2) {
             println("***")
-            res = "one"
+            "one"
         } else {
             println("***")
-            res = "???"
+            "???"
         }
     } else if (n == 2) {
         println("***")
-        res = "two"
+        return "two"
     } else {
         println("***")
-        res = "too many"
+        return "too many"
     }
-
-    return res
 }

idea/testData/codeInsight/codeTransformations/branched/folding/return/innerWhenTransformed.kt

@@ -0,0 +1,11 @@
+fun test(n: Int): String {
+    if (3 > 2) {
+        <caret>when (n) {
+            1 -> return "one"
+            else -> return "two"
+        }
+    } else {
+        println("***")
+        return "???"
+    }
+}

idea/testData/codeInsight/codeTransformations/branched/folding/return/innerWhenTransformed.kt.after

@@ -0,0 +1,11 @@
+fun test(n: Int): String {
+    if (3 > 2) {
+        <caret>return when (n) {
+            1 -> "one"
+            else -> "two"
+        }
+    } else {
+        println("***")
+        return "???"
+    }
+}

idea/testData/codeInsight/codeTransformations/branched/folding/return/simpleIf.kt

@@ -0,0 +1,6 @@
+fun test(n: Int): String {
+    <caret>if (n == 1)
+      return "one"
+    else
+      return "two"
+}

idea/testData/codeInsight/codeTransformations/branched/folding/return/simpleIf.kt.after

@@ -0,0 +1,6 @@
+fun test(n: Int): String {
+    <caret>return if (n == 1)
+        "one"
+    else
+        "two"
+}

idea/testData/codeInsight/codeTransformations/branched/folding/return/simpleIfWithBlocks.kt

@@ -0,0 +1,9 @@
+fun test(n: Int): String {
+    <caret>if (n == 1) {
+        println("***")
+        return "one"
+    } else {
+        println("***")
+        return "two"
+    }
+}

idea/testData/codeInsight/codeTransformations/branched/folding/return/simpleIfWithBlocks.kt.after

@@ -0,0 +1,9 @@
+fun test(n: Int): String {
+    <caret>return if (n == 1) {
+        println("***")
+        "one"
+    } else {
+        println("***")
+        "two"
+    }
+}

idea/testData/codeInsight/codeTransformations/branched/folding/return/simpleWhen.kt

@@ -0,0 +1,6 @@
+fun test(n: Int): String {
+    <caret>when (n) {
+      1 -> return "one"
+      else -> return "two"
+    }
+}

idea/testData/codeInsight/codeTransformations/branched/folding/return/simpleWhen.kt.after

@@ -0,0 +1,6 @@
+fun test(n: Int): String {
+    <caret>return when (n) {
+      1 -> "one"
+      else -> "two"
+    }
+}

idea/testData/codeInsight/codeTransformations/branched/folding/return/simpleWhenWithBlocks.kt

@@ -0,0 +1,11 @@
+fun test(n: Int): String {
+    <caret>when(n) {
+    1 -> {
+        println("***")
+        return "one"
+    }
+    else -> {
+        println("***")
+        return "two"
+    }
+}

idea/testData/codeInsight/codeTransformations/branched/folding/return/simpleWhenWithBlocks.kt.after

@@ -0,0 +1,11 @@
+fun test(n: Int): String {
+    <caret>return when(n) {
+    1 -> {
+        println("***")
+        "one"
+    }
+    else -> {
+        println("***")
+        "two"
+    }
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/assignment/nestedIfs.kt.after

@@ -1,15 +1,15 @@
 fun test(n: Int): String {
     var res: String
 
-    <caret>res = if (n == 1) {
+    <caret>if (n == 1) {
-        if (3 > 2) {
+        res = if (3 > 2) {
             println("***")
             "one"
         } else {
             println("***")
             "???"
         }
-    } else if (n == 2) {
+    } else res = if (n == 2) {
         println("***")
         "two"
     } else {

idea/testData/codeInsight/codeTransformations/branched/unfolding/assignment/simpleIf.kt

@@ -0,0 +1,7 @@
+fun test(n: Int): String {
+    var res: String
+
+    <caret>res = if (n == 1) "one" else "two"
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/assignment/simpleIf.kt.after

@@ -0,0 +1,7 @@
+fun test(n: Int): String {
+    var res: String
+
+    <caret>if (n == 1) res = "one" else res = "two"
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/assignment/simpleIfWithAugmentedAssignment.kt

@@ -0,0 +1,7 @@
+fun test(n: Int): String {
+    var res: String = "!"
+
+    <caret>res += if (n == 1) "one" else "two"
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/assignment/simpleIfWithAugmentedAssignment.kt.after

@@ -0,0 +1,7 @@
+fun test(n: Int): String {
+    var res: String = "!"
+
+    <caret>if (n == 1) res += "one" else res += "two"
+
+    return res
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/asymmetricReturn/simpleIf.kt

@@ -0,0 +1,3 @@
+fun test(n: Int): String {
+    <caret>return if (n == 1) "one" else "two"
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/asymmetricReturn/simpleIf.kt.after

@@ -0,0 +1,3 @@
+fun test(n: Int): String {
+    <caret>if (n == 1) return "one" else return "two"
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/asymmetricReturn/simpleIfWithBlocks.kt

@@ -0,0 +1,6 @@
+fun test(n: Int): String {
+    <caret>return if (n == 1) {
+        println("***")
+        "one"
+    } else "two"
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/asymmetricReturn/simpleIfWithBlocks.kt.after

@@ -0,0 +1,6 @@
+fun test(n: Int): String {
+    <caret>if (n == 1) {
+        println("***")
+        return "one"
+    } else return "two"
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/return/innerIfTransformed.kt

@@ -0,0 +1,17 @@
+fun test(n: Int): String {
+    if (n == 1) {
+        <caret>return if (3 > 2) {
+            println("***")
+            "one"
+        } else {
+            println("***")
+            "???"
+        }
+    } else if (n == 2) {
+        println("***")
+        return "two"
+    } else {
+        println("***")
+        return "too many"
+    }
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/return/innerIfTransformed.kt.after

@@ -0,0 +1,17 @@
+fun test(n: Int): String {
+    if (n == 1) {
+        <caret>if (3 > 2) {
+            println("***")
+            return "one"
+        } else {
+            println("***")
+            return "???"
+        }
+    } else if (n == 2) {
+        println("***")
+        return "two"
+    } else {
+        println("***")
+        return "too many"
+    }
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/return/simpleIf.kt

@@ -0,0 +1,6 @@
+fun test(n: Int): String {
+    <caret>return if (n == 1)
+      "one"
+    else
+      "two"
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/return/simpleIf.kt.after

@@ -0,0 +1,6 @@
+fun test(n: Int): String {
+    <caret>if (n == 1)
+        return "one"
+    else
+        return "two"
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/return/simpleIfWithBlocks.kt

@@ -0,0 +1,9 @@
+fun test(n: Int): String {
+    <caret>return if (n == 1) {
+        println("***")
+        "one"
+    } else {
+        println("***")
+        "two"
+    }
+}

idea/testData/codeInsight/codeTransformations/branched/unfolding/return/simpleIfWithBlocks.kt.after

@@ -0,0 +1,9 @@
+fun test(n: Int): String {
+    <caret>if (n == 1) {
+        println("***")
+        return "one"
+    } else {
+        println("***")
+        return "two"
+    }
+}

idea/tests/org/jetbrains/jet/plugin/codeInsight/codeTransformations/CodeTransformationsTestGenerated.java

@@ -30,7 +30,7 @@ import org.jetbrains.jet.plugin.codeInsight.codeTransformations.AbstractCodeTran
 
 /** This class is generated by {@link org.jetbrains.jet.generators.tests.GenerateTests}. DO NOT MODIFY MANUALLY */
 @SuppressWarnings("all")
-@InnerTestClasses({CodeTransformationsTestGenerated.IfStatementWithAssignmentsToExpression.class, CodeTransformationsTestGenerated.AssignmentWithIfExpressionToStatement.class, CodeTransformationsTestGenerated.RemoveUnnecessaryParentheses.class})
+@InnerTestClasses({CodeTransformationsTestGenerated.IfStatementWithAssignmentsToExpression.class, CodeTransformationsTestGenerated.AssignmentWithIfExpressionToStatement.class})
 public class CodeTransformationsTestGenerated extends AbstractCodeTransformationTest {
     @TestMetadata("idea/testData/codeInsight/codeTransformations/ifStatementWithAssignmentsToExpression")
     public static class IfStatementWithAssignmentsToExpression extends AbstractCodeTransformationTest {