Fix messages #KT-25177

This commit is contained in:
Toshiaki Kameyama
2018-07-30 18:37:13 +09:00
committed by Anton Bannykh
parent 605736b6ba
commit f2fec6b078
17 changed files with 61 additions and 48 deletions
+2 -2
View File
@@ -2976,8 +2976,8 @@ The Kotlin plugin provides language support in IntelliJ IDEA and Android Studio.
language="kotlin"
/>
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.RedundantAsDynamicInspection"
displayName="Redundant 'asDynamic' call"
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.SuspiciousAsDynamicInspection"
displayName="Suspicious 'asDynamic' member invocation"
groupPath="Kotlin"
groupName="Style issues"
enabledByDefault="true"
+2 -3
View File
@@ -2957,7 +2957,6 @@ The Kotlin plugin provides language support in IntelliJ IDEA and Android Studio.
language="kotlin"
/>
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.RedundantWithInspection"
displayName="Redundant 'with' call"
groupPath="Kotlin"
@@ -2976,8 +2975,8 @@ The Kotlin plugin provides language support in IntelliJ IDEA and Android Studio.
language="kotlin"
/>
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.RedundantAsDynamicInspection"
displayName="Redundant 'asDynamic' call"
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.SuspiciousAsDynamicInspection"
displayName="Suspicious 'asDynamic' member invocation"
groupPath="Kotlin"
groupName="Style issues"
enabledByDefault="true"
+2 -2
View File
@@ -2975,8 +2975,8 @@ The Kotlin plugin provides language support in IntelliJ IDEA and Android Studio.
language="kotlin"
/>
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.RedundantAsDynamicInspection"
displayName="Redundant 'asDynamic' call"
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.SuspiciousAsDynamicInspection"
displayName="Suspicious 'asDynamic' member invocation"
groupPath="Kotlin"
groupName="Style issues"
enabledByDefault="true"
+2 -2
View File
@@ -2976,8 +2976,8 @@ The Kotlin plugin provides language support in IntelliJ IDEA and Android Studio.
language="kotlin"
/>
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.RedundantAsDynamicInspection"
displayName="Redundant 'asDynamic' call"
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.SuspiciousAsDynamicInspection"
displayName="Suspicious 'asDynamic' member invocation"
groupPath="Kotlin"
groupName="Style issues"
enabledByDefault="true"
+2 -2
View File
@@ -2975,8 +2975,8 @@ The Kotlin plugin provides language support in IntelliJ IDEA and Android Studio.
language="kotlin"
/>
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.RedundantAsDynamicInspection"
displayName="Redundant 'asDynamic' call"
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.SuspiciousAsDynamicInspection"
displayName="Suspicious 'asDynamic' member invocation"
groupPath="Kotlin"
groupName="Style issues"
enabledByDefault="true"
+2 -2
View File
@@ -2975,8 +2975,8 @@ The Kotlin plugin provides language support in IntelliJ IDEA and Android Studio.
language="kotlin"
/>
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.RedundantAsDynamicInspection"
displayName="Redundant 'asDynamic' call"
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.SuspiciousAsDynamicInspection"
displayName="Suspicious 'asDynamic' member invocation"
groupPath="Kotlin"
groupName="Style issues"
enabledByDefault="true"
+10
View File
@@ -2958,6 +2958,7 @@ The Kotlin plugin provides language support in IntelliJ IDEA and Android Studio.
language="kotlin"
/>
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.RedundantWithInspection"
displayName="Redundant 'with' call"
groupPath="Kotlin"
@@ -2976,6 +2977,15 @@ The Kotlin plugin provides language support in IntelliJ IDEA and Android Studio.
language="kotlin"
/>
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.SuspiciousAsDynamicInspection"
displayName="Suspicious 'asDynamic' member invocation"
groupPath="Kotlin"
groupName="Style issues"
enabledByDefault="true"
level="WEAK WARNING"
language="kotlin"
/>
<referenceImporter implementation="org.jetbrains.kotlin.idea.quickfix.KotlinReferenceImporter"/>
<fileType.fileViewProviderFactory filetype="KJSM" implementationClass="com.intellij.psi.ClassFileViewProviderFactory"/>
@@ -18,7 +18,7 @@ import org.jetbrains.kotlin.psi.callExpressionVisitor
import org.jetbrains.kotlin.psi.psiUtil.getQualifiedExpressionForSelector
import org.jetbrains.kotlin.types.DynamicType
class RedundantAsDynamicInspection : AbstractKotlinInspection() {
class SuspiciousAsDynamicInspection : AbstractKotlinInspection() {
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean) =
callExpressionVisitor(fun(call) {
if (call.platform != JsPlatform) return
@@ -26,7 +26,7 @@ class RedundantAsDynamicInspection : AbstractKotlinInspection() {
if (call.getQualifiedExpressionForSelector()?.receiverExpression?.getCallableDescriptor()?.returnType !is DynamicType) return
holder.registerProblem(
call,
"Redundant 'asDynamic' call",
"Suspicious 'asDynamic' member invocation",
ProblemHighlightType.GENERIC_ERROR_OR_WARNING,
RemoveAsDynamicCallFix()
)
@@ -34,7 +34,7 @@ class RedundantAsDynamicInspection : AbstractKotlinInspection() {
}
private class RemoveAsDynamicCallFix : LocalQuickFix {
override fun getName() = "Remove 'asDynamic' call"
override fun getName() = "Remove 'asDynamic' invocation"
override fun getFamilyName() = name