[FIR] Add ability to safe proper ConeKotlinType in FirErrorTypeRef

This is needed for cases when some type ref is resolved to proper type
  but has some diagnostic (e.g. this type is invisible)

compiler/fir/providers/src/org/jetbrains/kotlin/fir/CopyUtils.kt

@@ -117,6 +117,7 @@ fun FirTypeRef.resolvedTypeFromPrototype(
     return if (type is ConeKotlinErrorType) {
         buildErrorTypeRef {
             source = this@resolvedTypeFromPrototype.source
+            this.type = type
             diagnostic = type.diagnostic
         }
     } else {

compiler/fir/providers/src/org/jetbrains/kotlin/fir/types/TypeUtils.kt

@@ -217,6 +217,7 @@ fun ConeKotlinType.toFirResolvedTypeRef(
         buildErrorTypeRef {
             this.source = source
             diagnostic = this@toFirResolvedTypeRef.diagnostic
+            type = this@toFirResolvedTypeRef
             this.delegatedTypeRef = delegatedTypeRef
         }
     } else {
@@ -275,6 +276,7 @@ fun FirTypeRef.withReplacedConeType(
     return if (newType is ConeKotlinErrorType) {
         buildErrorTypeRef {
             source = newSource
+            type = newType
             diagnostic = newType.diagnostic
         }
     } else {

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/transformers/FirCallCompletionResultsWriterTransformer.kt

@@ -107,6 +107,7 @@ class FirCallCompletionResultsWriterTransformer(
             } else {
                 buildErrorTypeRef {
                     source = calculated.source?.fakeElement(KtFakeSourceElementKind.ImplicitTypeRef)
+                    type = calculated.type
                     diagnostic = calculated.diagnostic
                 }
             }

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/transformers/FirSpecificTypeResolverTransformer.kt

@@ -116,6 +116,9 @@ class FirSpecificTypeResolverTransformer(
         } else {
             buildErrorTypeRef {
                 source = functionTypeRef.source
+                if (resolvedType != null) {
+                    type = resolvedType
+                }
                 diagnostic = (resolvedType as? ConeClassErrorType)?.diagnostic
                     ?: ConeSimpleDiagnostic("Unresolved functional type: ${functionTypeRef.render()}")
             }
@@ -146,9 +149,9 @@ class FirSpecificTypeResolverTransformer(
                     typeRef.source
                 }
 
-                delegatedTypeRef = typeRef
+                    delegatedTypeRef = typeRef
-
+                    type = resolvedType
-                diagnostic = resolvedType.diagnostic
+                    diagnostic = resolvedType.diagnostic
             }
         }
     }

compiler/fir/tree/src/org/jetbrains/kotlin/fir/types/builder/FirErrorTypeRefBuilder.kt

@@ -26,18 +26,28 @@ import org.jetbrains.kotlin.fir.visitors.*
 @FirBuilderDsl
 class FirErrorTypeRefBuilder : FirAnnotationContainerBuilder {
     override var source: KtSourceElement? = null
+    var type: ConeKotlinType? = null
     var delegatedTypeRef: FirTypeRef? = null
     lateinit var diagnostic: ConeDiagnostic
 
     override fun build(): FirErrorTypeRef {
-        return FirErrorTypeRefImpl(
+        val type = this.type
-            source,
+        return if (type != null) {
-            delegatedTypeRef,
+            FirErrorTypeRefImpl(
-            diagnostic,
+                source,
-        )
+                type,
+                delegatedTypeRef,
+                diagnostic,
+            )
+        } else {
+            FirErrorTypeRefImpl(
+                source,
+                delegatedTypeRef,
+                diagnostic,
+            )
+        }
     }
 
-
     @Deprecated("Modification of 'annotations' has no impact for FirErrorTypeRefBuilder", level = DeprecationLevel.HIDDEN)
     override val annotations: MutableList<FirAnnotation> = mutableListOf()
 }
@@ -57,6 +67,7 @@ inline fun buildErrorTypeRefCopy(original: FirErrorTypeRef, init: FirErrorTypeRe
     }
     val copyBuilder = FirErrorTypeRefBuilder()
     copyBuilder.source = original.source
+    copyBuilder.type = original.type
     copyBuilder.delegatedTypeRef = original.delegatedTypeRef
     copyBuilder.diagnostic = original.diagnostic
     return copyBuilder.apply(init).build()

compiler/fir/tree/src/org/jetbrains/kotlin/fir/types/impl/FirErrorTypeRefImpl.kt

@@ -14,18 +14,19 @@ import org.jetbrains.kotlin.fir.types.FirErrorTypeRef
 import org.jetbrains.kotlin.fir.types.FirTypeRef
 import org.jetbrains.kotlin.fir.visitors.*
 
-/*
- * This file was generated automatically
- * DO NOT MODIFY IT MANUALLY
- */
-
 internal class FirErrorTypeRefImpl(
     override val source: KtSourceElement?,
+    override val type: ConeKotlinType,
     override var delegatedTypeRef: FirTypeRef?,
     override val diagnostic: ConeDiagnostic,
 ) : FirErrorTypeRef() {
+    constructor(source: KtSourceElement?, delegatedTypeRef: FirTypeRef?, diagnostic: ConeDiagnostic) : this(
+        source,
+        ConeClassErrorType(diagnostic),
+        delegatedTypeRef, diagnostic
+    )
+
     override val annotations: MutableList<FirAnnotation> = mutableListOf()
-    override val type: ConeKotlinType = ConeClassErrorType(diagnostic)
 
     override fun <R, D> acceptChildren(visitor: FirVisitor<R, D>, data: D) {
         annotations.forEach { it.accept(visitor, data) }

compiler/fir/tree/tree-generator/src/org/jetbrains/kotlin/fir/tree/generator/BuilderConfigurator.kt

@@ -254,10 +254,6 @@ object BuilderConfigurator : AbstractBuilderConfigurator<FirTreeBuilder>(FirTree
             withCopy()
         }
 
-        builder(errorTypeRef) {
-            withCopy()
-        }
-
         builder(functionTypeRef) {
             withCopy()
         }

compiler/fir/tree/tree-generator/src/org/jetbrains/kotlin/fir/tree/generator/ImplementationConfigurator.kt

@@ -200,15 +200,7 @@ object ImplementationConfigurator : AbstractFirTreeImplementationConfigurator()
             }
         }
 
-        val errorTypeRefImpl = impl(errorTypeRef) {
+        noImpl(errorTypeRef)
-            default("type", "ConeClassErrorType(diagnostic)")
-            default("annotations", "mutableListOf()")
-            useTypes(coneClassErrorTypeType)
-            default("delegatedTypeRef") {
-                needAcceptAndTransform = false
-            }
-        }
-
 
         impl(property) {
             default("isVal") {
@@ -231,7 +223,7 @@ object ImplementationConfigurator : AbstractFirTreeImplementationConfigurator()
                 withGetter = true
             )
             default("returnTypeRef", "FirErrorTypeRefImpl(null, null, diagnostic)")
-            useTypes(errorTypeRefImpl)
+            useTypes(errorTypeRefImplType)
         }
 
         impl(field) {
@@ -428,13 +420,13 @@ object ImplementationConfigurator : AbstractFirTreeImplementationConfigurator()
 
         impl(errorExpression) {
             default("typeRef", "FirErrorTypeRefImpl(source, null, ConeStubDiagnostic(diagnostic))")
-            useTypes(errorTypeRefImpl, coneStubDiagnosticType)
+            useTypes(errorTypeRefImplType, coneStubDiagnosticType)
         }
 
         impl(errorFunction) {
             defaultNull("receiverTypeRef", "body", withGetter = true)
             default("returnTypeRef", "FirErrorTypeRefImpl(null, null, diagnostic)")
-            useTypes(errorTypeRefImpl)
+            useTypes(errorTypeRefImplType)
         }
 
         impl(functionTypeRef)

compiler/fir/tree/tree-generator/src/org/jetbrains/kotlin/fir/tree/generator/Types.kt

@@ -98,4 +98,5 @@ val deprecationsPerUseSiteType = type("fir.declarations", "DeprecationsPerUseSit
 val emptyAnnotationArgumentMappingType = type("fir.expressions.impl", "FirEmptyAnnotationArgumentMapping")
 
 val firPropertySymbolType = type("fir.symbols.impl", "FirPropertySymbol")
+val errorTypeRefImplType = type("fir.types.impl", "FirErrorTypeRefImpl")
 

compiler/testData/diagnostics/tests/callableReference/resolve/ambiguityWithBoundExtensionReceiver.fir.kt

@@ -10,6 +10,6 @@ fun A.foo() = ""
 
 class A {
     fun main() {
-        <!NEW_INFERENCE_NO_INFORMATION_FOR_PARAMETER!>bar<!>(::<!OVERLOAD_RESOLUTION_AMBIGUITY!>foo<!>) <!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>checkType<!> { _<String>() }
+        <!NEW_INFERENCE_NO_INFORMATION_FOR_PARAMETER!>bar<!>(::<!OVERLOAD_RESOLUTION_AMBIGUITY!>foo<!>) <!NEW_INFERENCE_NO_INFORMATION_FOR_PARAMETER!>checkType<!> { _<String>() }
     }
 }