FIR checker: report val reassignment
This commit is contained in:
committed by
Dmitriy Novozhilov
parent
b128577508
commit
f1fa290d49
+5
-5
@@ -22,7 +22,7 @@ fun <T> runOnce(block: () -> T): T {
|
||||
fun valueReassignment() {
|
||||
val x: Int
|
||||
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
|
||||
runTwice { x = 42 }
|
||||
runTwice { <!VAL_REASSIGNMENT!>x<!> = 42 }
|
||||
x.inc()
|
||||
}
|
||||
|
||||
@@ -36,7 +36,7 @@ fun branchingFlow(a: Any?) {
|
||||
val x: Int
|
||||
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
|
||||
if (a is String) {
|
||||
runTwice { x = 42 }
|
||||
runTwice { <!VAL_REASSIGNMENT!>x<!> = 42 }
|
||||
}
|
||||
else {
|
||||
x = 43
|
||||
@@ -47,7 +47,7 @@ fun branchingFlow(a: Any?) {
|
||||
fun branchingFlowWithMissingBranches(a: Any?) {
|
||||
val x: Int
|
||||
if (a is String) {
|
||||
runTwice { x = 42 }
|
||||
runTwice { <!VAL_REASSIGNMENT!>x<!> = 42 }
|
||||
}
|
||||
|
||||
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
|
||||
@@ -58,7 +58,7 @@ fun repeatingFlow(n: Int) {
|
||||
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
|
||||
|
||||
for (i in 1..n) {
|
||||
runTwice { x = 42 }
|
||||
runTwice { <!VAL_REASSIGNMENT!>x<!> = 42 }
|
||||
}
|
||||
|
||||
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
|
||||
@@ -68,7 +68,7 @@ fun repeatingFlow2(n: Int) {
|
||||
val x: Int
|
||||
|
||||
for (i in 1..n) {
|
||||
runTwice { x = 42 }
|
||||
runTwice { <!VAL_REASSIGNMENT!>x<!> = 42 }
|
||||
}
|
||||
|
||||
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
|
||||
|
||||
-28
@@ -1,28 +0,0 @@
|
||||
// !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
|
||||
// !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
|
||||
// !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER
|
||||
|
||||
import kotlin.contracts.*
|
||||
|
||||
fun <T> myRun(block: () -> T): T {
|
||||
contract {
|
||||
callsInPlace(block, InvocationKind.EXACTLY_ONCE)
|
||||
}
|
||||
return block()
|
||||
}
|
||||
|
||||
fun reassignmentInUsualFlow() {
|
||||
val x: Int
|
||||
myRun { x = 42 }
|
||||
x = 43
|
||||
x.inc()
|
||||
}
|
||||
|
||||
fun reassignment() {
|
||||
val x = 42
|
||||
myRun {
|
||||
x = 43
|
||||
}
|
||||
x.inc()
|
||||
}
|
||||
|
||||
+1
@@ -1,3 +1,4 @@
|
||||
// FIR_IDENTICAL
|
||||
// !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
|
||||
// !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
|
||||
// !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER
|
||||
|
||||
+2
-2
@@ -24,7 +24,7 @@ fun branchingIndetermineFlow(a: Any?) {
|
||||
if (a is String) {
|
||||
myRepeat(a.length) {
|
||||
// Val reassignment because we know that repeat's lambda called in-place
|
||||
myRun { x = 42 }
|
||||
myRun { <!VAL_REASSIGNMENT!>x<!> = 42 }
|
||||
}
|
||||
}
|
||||
else {
|
||||
@@ -45,7 +45,7 @@ fun multipleAssignments() {
|
||||
val x: Int
|
||||
myRepeat(42) {
|
||||
// Val reassignment because we know that repeat's lambda called in-place
|
||||
myRun { x = 42 }
|
||||
myRun { <!VAL_REASSIGNMENT!>x<!> = 42 }
|
||||
}
|
||||
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
|
||||
}
|
||||
|
||||
-18
@@ -1,18 +0,0 @@
|
||||
// !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
|
||||
// !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
|
||||
// !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER
|
||||
|
||||
import kotlin.contracts.*
|
||||
|
||||
fun <T> inPlace(block: () -> T): T {
|
||||
contract {
|
||||
callsInPlace(block)
|
||||
}
|
||||
return block()
|
||||
}
|
||||
|
||||
fun reassignmentAndNoInitializaiton() {
|
||||
val x: Int
|
||||
inPlace { x = 42 }
|
||||
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
|
||||
}
|
||||
+1
@@ -1,3 +1,4 @@
|
||||
// FIR_IDENTICAL
|
||||
// !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
|
||||
// !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
|
||||
// !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER
|
||||
|
||||
Reference in New Issue
Block a user