azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FIR checker: report val reassignment

Browse Source
This commit is contained in:
Jinseong Jeon
2021-02-19 00:51:16 -08:00
committed by Dmitriy Novozhilov
parent b128577508
commit f1fa290d49
66 changed files with 386 additions and 309 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/testData/diagnostics/tests/controlFlowAnalysis/UninitializedOrReassignedVariables.fir.kt
Vendored
+4 -4
View File
@@ -63,7 +63,7 @@ fun t4(a: A) {
fun t1() {
val a : Int = 1
a = 2
<!VAL_REASSIGNMENT!>a<!> = 2
var b : Int = 1
b = 3
@@ -83,8 +83,8 @@ enum class ProtocolState {
fun t3() {
val x: ProtocolState = ProtocolState.WAITING
x = x.signal()
x = x.signal() //repeat for x
<!VAL_REASSIGNMENT!>x<!> = x.signal()
<!VAL_REASSIGNMENT!>x<!> = x.signal() //repeat for x
}
fun t4() {
@@ -326,7 +326,7 @@ fun func() {
val a = object {
val x = b
init {
b = 4
<!VAL_REASSIGNMENT!>b<!> = 4
}
}
}
compiler/testData/diagnostics/tests/controlFlowAnalysis/assignedInTryWithCatch.fir.kt
Vendored
+6 -6
View File
@@ -24,7 +24,7 @@ fun assignedInTryAndCatch() {
try {
a = 42
} catch (e: Exception) {
a = 41
<!VAL_REASSIGNMENT!>a<!> = 41
} finally {
}
a.hashCode()
@@ -37,7 +37,7 @@ fun sideEffectBeforeAssignedInTryAndCatch(s: Any) {
a = 42
} catch (e: Exception) {
s as String // Potential cast exception
a = 41
<!VAL_REASSIGNMENT!>a<!> = 41
} finally {
}
a.hashCode()
@@ -48,9 +48,9 @@ fun assignedAtAll() {
try {
a = 42
} catch (e: Exception) {
a = 41
<!VAL_REASSIGNMENT!>a<!> = 41
} finally {
a = 40
<!VAL_REASSIGNMENT!>a<!> = 40
}
a.hashCode()
}
@@ -62,9 +62,9 @@ fun sideEffectBeforeAssignedInTryCatchButNotFinally(s: Any) {
a = 42
} catch (e: Exception) {
s as String // Potential cast exception
a = 41
<!VAL_REASSIGNMENT!>a<!> = 41
} finally {
a = 40
<!VAL_REASSIGNMENT!>a<!> = 40
}
a.hashCode()
}
compiler/testData/diagnostics/tests/controlFlowAnalysis/assignedInTryWithoutCatch.fir.kt
Vendored
+2 -2
View File
@@ -22,7 +22,7 @@ fun assignedInTryAndFinally() {
try {
a = 42
} finally {
a = 41
<!VAL_REASSIGNMENT!>a<!> = 41
}
a.hashCode()
}
@@ -33,7 +33,7 @@ fun sideEffectBeforeAssignmentInTryButNotFinally(s: Any) {
s as String // Potential cast exception
a = 42
} finally {
a = 41
<!VAL_REASSIGNMENT!>a<!> = 41
}
a.hashCode()
}
compiler/testData/diagnostics/tests/controlFlowAnalysis/doWhileAssignment.fir.kt
Vendored
-23
View File
@@ -1,23 +0,0 @@
// See KT-15334: incorrect reassignment in do...while
fun test() {
do {
val s: String
s = ""
} while (s == "")
}
fun test2() {
do {
val s: String
s = "1"
s = s + "2"
} while (s == "1")
}
fun test3() {
val s: String
do {
s = ""
} while (s != "")
}
compiler/testData/diagnostics/tests/controlFlowAnalysis/doWhileAssignment.kt
Vendored
+1
View File
@@ -1,3 +1,4 @@
// FIR_IDENTICAL
// See KT-15334: incorrect reassignment in do...while
fun test() {
compiler/testData/diagnostics/tests/controlFlowAnalysis/reassignmentInTryCatch.fir.kt
Vendored
+6 -6
View File
@@ -8,7 +8,7 @@ fun f1() {
}
catch (e: Exception) {
// KT-13612: reassignment
n = 2
<!VAL_REASSIGNMENT!>n<!> = 2
}
n.hashCode()
}
@@ -20,7 +20,7 @@ fun f2() {
throw Exception()
}
finally {
n = 2
<!VAL_REASSIGNMENT!>n<!> = 2
}
n.hashCode()
}
@@ -33,7 +33,7 @@ fun g1(flag: Boolean) {
}
catch (e: Exception) {
// KT-13612: ? reassignment or definite assignment ?
n = 2
<!VAL_REASSIGNMENT!>n<!> = 2
}
n.hashCode()
}
@@ -45,7 +45,7 @@ fun g2(flag: Boolean) {
n = 1
}
finally {
n = 2
<!VAL_REASSIGNMENT!>n<!> = 2
}
n.hashCode()
}
@@ -84,7 +84,7 @@ fun k1(flag: Boolean) {
}
catch (e: Exception) {
// KT-13612: reassignment
n = 2
<!VAL_REASSIGNMENT!>n<!> = 2
}
n.hashCode()
}
@@ -96,7 +96,7 @@ fun k2(flag: Boolean) {
j(flag)
}
finally {
n = 2
<!VAL_REASSIGNMENT!>n<!> = 2
}
n.hashCode()
}
compiler/testData/diagnostics/tests/declarationChecks/DataFlowInMultiDeclInFor.fir.kt
Vendored
+1 -1
View File
@@ -9,7 +9,7 @@ class A {
fun foo(list: List<A>) {
for (var (c1, c2, c3) in list) {
c1 = 1
<!VAL_REASSIGNMENT!>c1<!> = 1
c3 + 1
}
}
compiler/testData/diagnostics/tests/reassignment/afterfor.fir.kt
Vendored
+2 -2
View File
@@ -3,8 +3,8 @@
fun foo(k: Int): Int {
val i: Int
for (j in 1..k) {
i = j
<!VAL_REASSIGNMENT!>i<!> = j
}
i = 6
<!VAL_REASSIGNMENT!>i<!> = 6
return i
}
compiler/testData/diagnostics/tests/reassignment/dowhile.fir.kt
Vendored
-10
View File
@@ -1,10 +0,0 @@
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(): Int {
val i: Int
var j = 0
do {
i = ++j
} while (j < 5)
return i
}
compiler/testData/diagnostics/tests/reassignment/dowhile.kt
Vendored
+1
View File
@@ -1,3 +1,4 @@
// FIR_IDENTICAL
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(): Int {
compiler/testData/diagnostics/tests/reassignment/else.fir.kt
Vendored
-11
View File
@@ -1,11 +0,0 @@
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(f: Boolean): Int {
val i: Int
if (f) {}
else {
i = 2
}
i = 3
return i
}
compiler/testData/diagnostics/tests/reassignment/else.kt
Vendored
+1
View File
@@ -1,3 +1,4 @@
// FIR_IDENTICAL
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(f: Boolean): Int {
compiler/testData/diagnostics/tests/reassignment/foronly.fir.kt
Vendored
-9
View File
@@ -1,9 +0,0 @@
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(k: Int): Int {
val i: Int
for (j in 1..k) {
i = j
}
return <!UNINITIALIZED_VARIABLE!>i<!>
}
compiler/testData/diagnostics/tests/reassignment/foronly.kt
Vendored
+1
View File
@@ -1,3 +1,4 @@
// FIR_IDENTICAL
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(k: Int): Int {
compiler/testData/diagnostics/tests/reassignment/if.fir.kt
Vendored
-10
View File
@@ -1,10 +0,0 @@
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(f: Boolean): Int {
val i: Int
if (f) {
i = 1
}
i = 3
return i
}
compiler/testData/diagnostics/tests/reassignment/if.kt
Vendored
+1
View File
@@ -1,3 +1,4 @@
// FIR_IDENTICAL
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(f: Boolean): Int {
compiler/testData/diagnostics/tests/reassignment/ifelse.fir.kt
Vendored
-13
View File
@@ -1,13 +0,0 @@
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(f: Boolean): Int {
val i: Int
if (f) {
i = 1
}
else {
i = 2
}
i = 3
return i
}
compiler/testData/diagnostics/tests/reassignment/ifelse.kt
Vendored
+1
View File
@@ -1,3 +1,4 @@
// FIR_IDENTICAL
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(f: Boolean): Int {
compiler/testData/diagnostics/tests/reassignment/when.fir.kt
Vendored
-10
View File
@@ -1,10 +0,0 @@
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(f: Boolean): Int {
val i: Int
when (f) {
true -> i = 1
}
i = 3
return i
}
compiler/testData/diagnostics/tests/reassignment/when.kt
Vendored
+1
View File
@@ -1,3 +1,4 @@
// FIR_IDENTICAL
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(f: Boolean): Int {
compiler/testData/diagnostics/tests/reassignment/whiletrue.fir.kt
Vendored
-11
View File
@@ -1,11 +0,0 @@
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(): Int {
val i: Int
var j = 0
while (true) {
i = ++j
if (j > 5) break
}
return i
}
compiler/testData/diagnostics/tests/reassignment/whiletrue.kt
Vendored
+1
View File
@@ -1,3 +1,4 @@
// FIR_IDENTICAL
// !DIAGNOSTICS: -UNUSED_VALUE
fun foo(): Int {
compiler/testData/diagnostics/tests/when/ExhaustiveValOverConditionalInit.fir.kt
Vendored
+3 -3
View File
@@ -16,8 +16,8 @@ fun foo(a: Boolean, b: Boolean): Int {
x = 1
}
when (b) {
true -> x = 2
false -> x = 3
true -> <!VAL_REASSIGNMENT!>x<!> = 2
false -> <!VAL_REASSIGNMENT!>x<!> = 3
}
return x
}
@@ -28,7 +28,7 @@ fun bar(a: Boolean, b: Boolean): Int {
x = 1
}
when (b) {
false -> x = 3
false -> <!VAL_REASSIGNMENT!>x<!> = 3
}
return <!UNINITIALIZED_VARIABLE!>x<!>
}
compiler/testData/diagnostics/tests/when/withSubjectVariable/reassignmentToWhenSubjectVariable.fir.kt
Vendored
-10
View File
@@ -1,10 +0,0 @@
// !LANGUAGE: +VariableDeclarationInWhenSubject
// !DIAGNOSTICS: -UNUSED_VARIABLE -UNUSED_PARAMETER -UNUSED_VALUE
fun foo(): Any = 42
fun test1(x: Any) {
when (val y = foo()) {
is String -> y = ""
}
}
compiler/testData/diagnostics/tests/when/withSubjectVariable/reassignmentToWhenSubjectVariable.kt
Vendored
+1
View File
@@ -1,3 +1,4 @@
// FIR_IDENTICAL
// !LANGUAGE: +VariableDeclarationInWhenSubject
// !DIAGNOSTICS: -UNUSED_VARIABLE -UNUSED_PARAMETER -UNUSED_VALUE