FIR checker: report val reassignment

compiler/testData/diagnostics/tests/controlFlowAnalysis/UninitializedOrReassignedVariables.fir.kt

@@ -63,7 +63,7 @@ fun t4(a: A) {
 
 fun t1() {
     val a : Int = 1
-    a = 2
+    <!VAL_REASSIGNMENT!>a<!> = 2
 
     var b : Int = 1
     b = 3
@@ -83,8 +83,8 @@ enum class ProtocolState {
 
 fun t3() {
    val x: ProtocolState = ProtocolState.WAITING
-   x = x.signal()
-   x = x.signal() //repeat for x
+   <!VAL_REASSIGNMENT!>x<!> = x.signal()
+   <!VAL_REASSIGNMENT!>x<!> = x.signal() //repeat for x
 }
 
 fun t4() {
@@ -326,7 +326,7 @@ fun func() {
     val a = object {
         val x = b
         init {
-            b = 4
+            <!VAL_REASSIGNMENT!>b<!> = 4
         }
     }
 }

compiler/testData/diagnostics/tests/controlFlowAnalysis/assignedInTryWithCatch.fir.kt

@@ -24,7 +24,7 @@ fun assignedInTryAndCatch() {
     try {
         a = 42
     } catch (e: Exception) {
-        a = 41
+        <!VAL_REASSIGNMENT!>a<!> = 41
     } finally {
     }
     a.hashCode()
@@ -37,7 +37,7 @@ fun sideEffectBeforeAssignedInTryAndCatch(s: Any) {
         a = 42
     } catch (e: Exception) {
         s as String // Potential cast exception
-        a = 41
+        <!VAL_REASSIGNMENT!>a<!> = 41
     } finally {
     }
     a.hashCode()
@@ -48,9 +48,9 @@ fun assignedAtAll() {
     try {
         a = 42
     } catch (e: Exception) {
-        a = 41
+        <!VAL_REASSIGNMENT!>a<!> = 41
     } finally {
-        a = 40
+        <!VAL_REASSIGNMENT!>a<!> = 40
     }
     a.hashCode()
 }
@@ -62,9 +62,9 @@ fun sideEffectBeforeAssignedInTryCatchButNotFinally(s: Any) {
         a = 42
     } catch (e: Exception) {
         s as String // Potential cast exception
-        a = 41
+        <!VAL_REASSIGNMENT!>a<!> = 41
     } finally {
-        a = 40
+        <!VAL_REASSIGNMENT!>a<!> = 40
     }
     a.hashCode()
 }

compiler/testData/diagnostics/tests/controlFlowAnalysis/assignedInTryWithoutCatch.fir.kt

@@ -22,7 +22,7 @@ fun assignedInTryAndFinally() {
     try {
         a = 42
     } finally {
-        a = 41
+        <!VAL_REASSIGNMENT!>a<!> = 41
     }
     a.hashCode()
 }
@@ -33,7 +33,7 @@ fun sideEffectBeforeAssignmentInTryButNotFinally(s: Any) {
         s as String // Potential cast exception
         a = 42
     } finally {
-        a = 41
+        <!VAL_REASSIGNMENT!>a<!> = 41
     }
     a.hashCode()
 }

compiler/testData/diagnostics/tests/controlFlowAnalysis/doWhileAssignment.fir.kt

@@ -1,23 +0,0 @@
-// See KT-15334: incorrect reassignment in do...while
-
-fun test() {
-    do {
-        val s: String
-        s = ""
-    } while (s == "")
-}
-
-fun test2() {
-    do {
-        val s: String
-        s = "1"
-        s = s + "2"
-    } while (s == "1")
-}
-
-fun test3() {
-    val s: String
-    do {
-        s = ""
-    } while (s != "")
-}

compiler/testData/diagnostics/tests/controlFlowAnalysis/doWhileAssignment.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // See KT-15334: incorrect reassignment in do...while
 
 fun test() {

compiler/testData/diagnostics/tests/controlFlowAnalysis/reassignmentInTryCatch.fir.kt

@@ -8,7 +8,7 @@ fun f1() {
     }
     catch (e: Exception) {
         // KT-13612: reassignment
-        n = 2
+        <!VAL_REASSIGNMENT!>n<!> = 2
     }
     n.hashCode()
 }
@@ -20,7 +20,7 @@ fun f2() {
         throw Exception()
     }
     finally {
-        n = 2
+        <!VAL_REASSIGNMENT!>n<!> = 2
     }
     n.hashCode()
 }
@@ -33,7 +33,7 @@ fun g1(flag: Boolean) {
     }
     catch (e: Exception) {
         // KT-13612: ? reassignment or definite assignment ?
-        n = 2
+        <!VAL_REASSIGNMENT!>n<!> = 2
     }
     n.hashCode()
 }
@@ -45,7 +45,7 @@ fun g2(flag: Boolean) {
         n = 1
     }
     finally {
-        n = 2
+        <!VAL_REASSIGNMENT!>n<!> = 2
     }
     n.hashCode()
 }
@@ -84,7 +84,7 @@ fun k1(flag: Boolean) {
     }
     catch (e: Exception) {
         // KT-13612: reassignment
-        n = 2
+        <!VAL_REASSIGNMENT!>n<!> = 2
     }
     n.hashCode()
 }
@@ -96,7 +96,7 @@ fun k2(flag: Boolean) {
         j(flag)
     }
     finally {
-        n = 2
+        <!VAL_REASSIGNMENT!>n<!> = 2
     }
     n.hashCode()
 }

compiler/testData/diagnostics/tests/declarationChecks/DataFlowInMultiDeclInFor.fir.kt

@@ -9,7 +9,7 @@ class A {
 
 fun foo(list: List<A>) {
     for (var (c1, c2, c3) in list) {
-        c1 = 1
+        <!VAL_REASSIGNMENT!>c1<!> = 1
         c3 + 1
     }
 }

compiler/testData/diagnostics/tests/reassignment/afterfor.fir.kt

@@ -3,8 +3,8 @@
 fun foo(k: Int): Int {
     val i: Int
     for (j in 1..k) {
-        i = j
+        <!VAL_REASSIGNMENT!>i<!> = j
     }
-    i = 6
+    <!VAL_REASSIGNMENT!>i<!> = 6
     return i
 }

compiler/testData/diagnostics/tests/reassignment/dowhile.fir.kt

@@ -1,10 +0,0 @@
-// !DIAGNOSTICS: -UNUSED_VALUE
-
-fun foo(): Int {
-    val i: Int
-    var j = 0
-    do {
-        i = ++j
-    } while (j < 5)
-    return i
-}

compiler/testData/diagnostics/tests/reassignment/dowhile.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !DIAGNOSTICS: -UNUSED_VALUE
 
 fun foo(): Int {

compiler/testData/diagnostics/tests/reassignment/else.fir.kt

@@ -1,11 +0,0 @@
-// !DIAGNOSTICS: -UNUSED_VALUE
-
-fun foo(f: Boolean): Int {
-    val i: Int
-    if (f) {}
-    else {
-        i = 2
-    }
-    i = 3
-    return i
-}

compiler/testData/diagnostics/tests/reassignment/else.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !DIAGNOSTICS: -UNUSED_VALUE
 
 fun foo(f: Boolean): Int {

compiler/testData/diagnostics/tests/reassignment/foronly.fir.kt

@@ -1,9 +0,0 @@
-// !DIAGNOSTICS: -UNUSED_VALUE
-
-fun foo(k: Int): Int {
-    val i: Int
-    for (j in 1..k) {
-        i = j
-    }
-    return <!UNINITIALIZED_VARIABLE!>i<!>
-}

compiler/testData/diagnostics/tests/reassignment/foronly.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !DIAGNOSTICS: -UNUSED_VALUE
 
 fun foo(k: Int): Int {

compiler/testData/diagnostics/tests/reassignment/if.fir.kt

@@ -1,10 +0,0 @@
-// !DIAGNOSTICS: -UNUSED_VALUE
-
-fun foo(f: Boolean): Int {
-    val i: Int
-    if (f) {
-        i = 1
-    }
-    i = 3
-    return i
-}

compiler/testData/diagnostics/tests/reassignment/if.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !DIAGNOSTICS: -UNUSED_VALUE
 
 fun foo(f: Boolean): Int {

compiler/testData/diagnostics/tests/reassignment/ifelse.fir.kt

@@ -1,13 +0,0 @@
-// !DIAGNOSTICS: -UNUSED_VALUE
-
-fun foo(f: Boolean): Int {
-    val i: Int
-    if (f) {
-        i = 1
-    }
-    else {
-        i = 2
-    }
-    i = 3
-    return i
-}

compiler/testData/diagnostics/tests/reassignment/ifelse.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !DIAGNOSTICS: -UNUSED_VALUE
 
 fun foo(f: Boolean): Int {

compiler/testData/diagnostics/tests/reassignment/when.fir.kt

@@ -1,10 +0,0 @@
-// !DIAGNOSTICS: -UNUSED_VALUE
-
-fun foo(f: Boolean): Int {
-    val i: Int
-    when (f) {
-        true -> i = 1
-    }
-    i = 3
-    return i
-}

compiler/testData/diagnostics/tests/reassignment/when.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !DIAGNOSTICS: -UNUSED_VALUE
 
 fun foo(f: Boolean): Int {

compiler/testData/diagnostics/tests/reassignment/whiletrue.fir.kt

@@ -1,11 +0,0 @@
-// !DIAGNOSTICS: -UNUSED_VALUE
-
-fun foo(): Int {
-    val i: Int
-    var j = 0
-    while (true) {
-        i = ++j
-        if (j > 5) break
-    } 
-    return i
-}

compiler/testData/diagnostics/tests/reassignment/whiletrue.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !DIAGNOSTICS: -UNUSED_VALUE
 
 fun foo(): Int {

compiler/testData/diagnostics/tests/when/ExhaustiveValOverConditionalInit.fir.kt

@@ -16,8 +16,8 @@ fun foo(a: Boolean, b: Boolean): Int {
         x = 1
     }
     when (b) {
-        true -> x = 2
-        false -> x = 3
+        true -> <!VAL_REASSIGNMENT!>x<!> = 2
+        false -> <!VAL_REASSIGNMENT!>x<!> = 3
     }
     return x
 }
@@ -28,7 +28,7 @@ fun bar(a: Boolean, b: Boolean): Int {
         x = 1
     }
     when (b) {
-        false -> x = 3
+        false -> <!VAL_REASSIGNMENT!>x<!> = 3
     }
     return <!UNINITIALIZED_VARIABLE!>x<!>
 }

compiler/testData/diagnostics/tests/when/withSubjectVariable/reassignmentToWhenSubjectVariable.fir.kt

@@ -1,10 +0,0 @@
-// !LANGUAGE: +VariableDeclarationInWhenSubject
-// !DIAGNOSTICS: -UNUSED_VARIABLE -UNUSED_PARAMETER -UNUSED_VALUE
-
-fun foo(): Any = 42
-
-fun test1(x: Any) {
-    when (val y = foo()) {
-        is String -> y = ""
-    }
-}

compiler/testData/diagnostics/tests/when/withSubjectVariable/reassignmentToWhenSubjectVariable.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !LANGUAGE: +VariableDeclarationInWhenSubject
 // !DIAGNOSTICS: -UNUSED_VARIABLE -UNUSED_PARAMETER -UNUSED_VALUE
 

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/flowInlining/breakContinuesInInlinedLambda.fir.kt

@@ -33,12 +33,12 @@ fun test() {
                 // Loop executed exectly once, initializing x
                 myRun { x.inc() }
 
-                myRun { x = 42 }
+                myRun { <!VAL_REASSIGNMENT!>x<!> = 42 }
                 break
             }
-            // x is I?D here because loop could've been execited
+            // x is ID? here because loop could've been execited
             // VAL_REASSIGNMENT isn't reported because of repeating diagnostic
-            x = 42
+            <!VAL_REASSIGNMENT!>x<!> = 42
             // x is ID now
         }
     else

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/flowInlining/breakContinuesInInlinedLambda.kt

@@ -36,7 +36,7 @@ fun test() {
                 myRun { <!VAL_REASSIGNMENT!>x<!> = 42 }
                 break
             }
-            // x is I?D here because loop could've been execited
+            // x is ID? here because loop could've been execited
             // VAL_REASSIGNMENT isn't reported because of repeating diagnostic
             x = 42
             // x is ID now

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/flowInlining/labeledReturns.fir.kt

@@ -42,7 +42,7 @@ fun threeLevelsReturnNoInitialization(x: Int?): Int? {
             }
         }
         // Possible to report unreachable here
-        y = 54
+        <!VAL_REASSIGNMENT!>y<!> = 54
     }
     return <!UNINITIALIZED_VARIABLE!>y<!>.inc()
 }

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/flowInlining/nestedTryCatchFinally.fir.kt

@@ -27,13 +27,13 @@ fun outerFinallyInitializes() {
                 log()
             }
             // possible reassignment if innerComputation finished
-            x = 42
+            <!VAL_REASSIGNMENT!>x<!> = 42
             // x is ID here
         }
 
         // Definite reassignment here, cause can get here only if myRun finished
         // Not reported because of repeating diagnostic
-        x = outerComputation()
+        <!VAL_REASSIGNMENT!>x<!> = outerComputation()
     } catch (e: java.lang.Exception) {
         // can catch exception thrown by the inner, so x can be not initialized
         <!UNINITIALIZED_VARIABLE!>x<!>.inc()
@@ -41,7 +41,7 @@ fun outerFinallyInitializes() {
     } finally {
         // Possible reassignment (e.g. if everything finished)
         // Not reported because of repeating diagnostic
-        x = 42
+        <!VAL_REASSIGNMENT!>x<!> = 42
     }
 
     // Properly initialized

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/flowInlining/nestedTryCatchs.fir.kt

@@ -25,7 +25,7 @@ fun innerTryCatchInitializes() {
             }
             catch (e: java.lang.Exception) {
                 // Potential reassignment because x.inc() could threw
-                x = 42
+                <!VAL_REASSIGNMENT!>x<!> = 42
                 x.inc()
             }
         }
@@ -40,7 +40,7 @@ fun innerTryCatchInitializes() {
         <!UNINITIALIZED_VARIABLE!>x<!>.inc()
 
         // Potential reasignment
-        x = 42
+        <!VAL_REASSIGNMENT!>x<!> = 42
     }
     // Here x=I because outer try-catch either exited normally (x=I) or catched exception (x=I, with reassingment, though)
     x.inc()

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/flowInlining/tryCatch.fir.kt

@@ -1,58 +0,0 @@
-// !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
-// !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
-// !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER
-
-import kotlin.contracts.*
-
-fun <T> myRun(block: () -> T): T {
-    contract {
-        callsInPlace(block, InvocationKind.EXACTLY_ONCE)
-    }
-    return block()
-}
-
-fun someComputation(): Int = 42
-
-fun tryCatchInlined() {
-    val x: Int
-
-    myRun {
-        try {
-            x = someComputation()
-            x.inc()
-        }
-        catch (e: java.lang.Exception) {
-            <!UNINITIALIZED_VARIABLE!>x<!>.inc()
-        }
-    }
-    x = 42
-    x.inc()
-}
-
-fun possibleReassignmentInTryCatch() {
-    val x: Int
-
-    myRun {
-        try {
-            x = someComputation()
-            x.inc()
-        }
-        catch (e: java.lang.Exception) {
-            x = 42
-            x.inc()
-        }
-        x.inc()
-    }
-    x.inc()
-}
-
-fun tryCatchOuter() {
-    val x: Int
-    try {
-        myRun {  x = someComputation() }
-        x.inc()
-    }
-    catch (e: java.lang.Exception) {
-        <!UNINITIALIZED_VARIABLE!>x<!>.inc()
-    }
-}

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/flowInlining/tryCatch.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
 // !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
 // !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/flowInlining/tryCatchFinally.fir.kt

@@ -23,10 +23,10 @@ fun innerTryCatchFinally() {
             x = someComputation()
             report(x)
         } catch (e: java.lang.Exception) {
-            x = 42
+            <!VAL_REASSIGNMENT!>x<!> = 42
             report(x)
         } finally {
-            x = 0
+            <!VAL_REASSIGNMENT!>x<!> = 0
         }
     }
 

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/initialization/atLeastOnce/valDefiniteReassignment.fir.kt

@@ -22,7 +22,7 @@ fun <T> runOnce(block: () -> T): T {
 fun valueReassignment() {
     val x: Int
     <!UNINITIALIZED_VARIABLE!>x<!>.inc()
-    runTwice { x = 42 }
+    runTwice { <!VAL_REASSIGNMENT!>x<!> = 42 }
     x.inc()
 }
 
@@ -36,7 +36,7 @@ fun branchingFlow(a: Any?) {
     val x: Int
     <!UNINITIALIZED_VARIABLE!>x<!>.inc()
     if (a is String) {
-        runTwice { x = 42 }
+        runTwice { <!VAL_REASSIGNMENT!>x<!> = 42 }
     }
     else {
         x = 43
@@ -47,7 +47,7 @@ fun branchingFlow(a: Any?) {
 fun branchingFlowWithMissingBranches(a: Any?) {
     val x: Int
     if (a is String) {
-        runTwice { x = 42 }
+        runTwice { <!VAL_REASSIGNMENT!>x<!> = 42 }
     }
 
     <!UNINITIALIZED_VARIABLE!>x<!>.inc()
@@ -58,7 +58,7 @@ fun repeatingFlow(n: Int) {
     <!UNINITIALIZED_VARIABLE!>x<!>.inc()
 
     for (i in 1..n) {
-        runTwice { x = 42 }
+        runTwice { <!VAL_REASSIGNMENT!>x<!> = 42 }
     }
 
     <!UNINITIALIZED_VARIABLE!>x<!>.inc()
@@ -68,7 +68,7 @@ fun repeatingFlow2(n: Int) {
     val x: Int
 
     for (i in 1..n) {
-        runTwice { x = 42 }
+        runTwice { <!VAL_REASSIGNMENT!>x<!> = 42 }
     }
 
     <!UNINITIALIZED_VARIABLE!>x<!>.inc()

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/initialization/exactlyOnce/valDefiniteReassignment.fir.kt

@@ -1,28 +0,0 @@
-// !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
-// !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
-// !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER
-
-import kotlin.contracts.*
-
-fun <T> myRun(block: () -> T): T {
-    contract {
-        callsInPlace(block, InvocationKind.EXACTLY_ONCE)
-    }
-    return block()
-}
-
-fun reassignmentInUsualFlow() {
-    val x: Int
-    myRun { x = 42 }
-    x = 43
-    x.inc()
-}
-
-fun reassignment() {
-    val x = 42
-    myRun {
-        x = 43
-    }
-    x.inc()
-}
-

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/initialization/exactlyOnce/valDefiniteReassignment.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
 // !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
 // !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/initialization/exactlyOnce/valIndefiniteInitialization.fir.kt

@@ -24,7 +24,7 @@ fun branchingIndetermineFlow(a: Any?) {
     if (a is String) {
         myRepeat(a.length) {
             // Val reassignment because we know that repeat's lambda called in-place
-            myRun { x = 42 }
+            myRun { <!VAL_REASSIGNMENT!>x<!> = 42 }
         }
     }
     else {
@@ -45,7 +45,7 @@ fun multipleAssignments() {
     val x: Int
     myRepeat(42) {
         // Val reassignment because we know that repeat's lambda called in-place
-        myRun { x = 42 }
+        myRun { <!VAL_REASSIGNMENT!>x<!> = 42 }
     }
     <!UNINITIALIZED_VARIABLE!>x<!>.inc()
 }

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/initialization/unknown/unknownInvocations.fir.kt

@@ -1,18 +0,0 @@
-// !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
-// !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
-// !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER
-
-import kotlin.contracts.*
-
-fun <T> inPlace(block: () -> T): T {
-    contract {
-        callsInPlace(block)
-    }
-    return block()
-}
-
-fun reassignmentAndNoInitializaiton() {
-    val x: Int
-    inPlace { x = 42 }
-    <!UNINITIALIZED_VARIABLE!>x<!>.inc()
-}

compiler/testData/diagnostics/testsWithStdLib/contracts/controlflow/initialization/unknown/unknownInvocations.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
 // !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
 // !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER

compiler/testData/diagnostics/testsWithStdLib/contracts/fromStdlib/fromStandardKt.fir.kt

@@ -86,7 +86,7 @@ fun testRepeatOnVal(x: Int) {
     val y: Int
     repeat(x) {
         // reassignment instead of captured val initialization
-        y = 42
+        <!VAL_REASSIGNMENT!>y<!> = 42
     }
     println(<!UNINITIALIZED_VARIABLE!>y<!>)
 }