[Gradle][Minor] Fix naming of KotlinCompilationAssociator impls

^KT-54312 Verification Pending
This commit is contained in:
Sebastian Sellmair
2022-10-27 08:57:32 +02:00
committed by Space Team
parent 331294c747
commit f109b11746
6 changed files with 18 additions and 17 deletions
@@ -51,7 +51,7 @@ internal object DefaultKotlinCompilationAssociator : KotlinCompilationAssociator
} }
} }
internal object NativeKotlinCompilationAssociator : KotlinCompilationAssociator { internal object KotlinNativeCompilationAssociator : KotlinCompilationAssociator {
override fun associate(target: KotlinTarget, first: InternalKotlinCompilation<*>, second: InternalKotlinCompilation<*>) { override fun associate(target: KotlinTarget, first: InternalKotlinCompilation<*>, second: InternalKotlinCompilation<*>) {
first.compileDependencyFiles += first.compileDependencyFiles +=
@@ -63,7 +63,7 @@ internal object NativeKotlinCompilationAssociator : KotlinCompilationAssociator
} }
} }
internal object JvmKotlinCompilationAssociator : KotlinCompilationAssociator { internal object KotlinJvmCompilationAssociator : KotlinCompilationAssociator {
override fun associate(target: KotlinTarget, first: InternalKotlinCompilation<*>, second: InternalKotlinCompilation<*>) { override fun associate(target: KotlinTarget, first: InternalKotlinCompilation<*>, second: InternalKotlinCompilation<*>) {
/* Main to Test association handled already by java plugin */ /* Main to Test association handled already by java plugin */
if (target is KotlinJvmTarget && target.withJavaEnabled && first.isMain() && second.isTest()) { if (target is KotlinJvmTarget && target.withJavaEnabled && first.isMain() && second.isTest()) {
@@ -81,7 +81,7 @@ internal object JvmKotlinCompilationAssociator : KotlinCompilationAssociator {
* We now explicitly add associate compilation dependencies to the Kotlin test compilation configurations (test classpaths). * We now explicitly add associate compilation dependencies to the Kotlin test compilation configurations (test classpaths).
* This helps, because the Android test classpath configurations extend from the Kotlin test compilations' directly. * This helps, because the Android test classpath configurations extend from the Kotlin test compilations' directly.
*/ */
internal object AndroidKotlinCompilationAssociator : KotlinCompilationAssociator { internal object KotlinAndroidCompilationAssociator : KotlinCompilationAssociator {
override fun associate(target: KotlinTarget, first: InternalKotlinCompilation<*>, second: InternalKotlinCompilation<*>) { override fun associate(target: KotlinTarget, first: InternalKotlinCompilation<*>, second: InternalKotlinCompilation<*>) {
first.compileDependencyConfigurationName.addAllDependenciesFromOtherConfigurations( first.compileDependencyConfigurationName.addAllDependenciesFromOtherConfigurations(
target.project, target.project,
@@ -90,7 +90,6 @@ internal object AndroidKotlinCompilationAssociator : KotlinCompilationAssociator
second.compileOnlyConfigurationName second.compileOnlyConfigurationName
) )
} }
} }
/** /**
@@ -7,7 +7,7 @@
package org.jetbrains.kotlin.gradle.plugin.mpp package org.jetbrains.kotlin.gradle.plugin.mpp
import com.android.build.gradle.api.BaseVariant import com.android.build.gradle.api.BaseVariant
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.AndroidKotlinCompilationAssociator import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.KotlinAndroidCompilationAssociator
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.DefaultKotlinCompilationFriendPathsResolver import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.DefaultKotlinCompilationFriendPathsResolver
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.AndroidCompilationSourceSetsContainerFactory import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.AndroidCompilationSourceSetsContainerFactory
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinJvmCompilerOptionsFactory import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinJvmCompilerOptionsFactory
@@ -24,7 +24,7 @@ class KotlinJvmAndroidCompilationFactory internal constructor(
DefaultKotlinCompilationFriendPathsResolver.AdditionalAndroidFriendArtifactResolver DefaultKotlinCompilationFriendPathsResolver.AdditionalAndroidFriendArtifactResolver
) )
), ),
compilationAssociator = AndroidKotlinCompilationAssociator, compilationAssociator = KotlinAndroidCompilationAssociator,
compilationSourceSetsContainerFactory = AndroidCompilationSourceSetsContainerFactory(target, variant) compilationSourceSetsContainerFactory = AndroidCompilationSourceSetsContainerFactory(target, variant)
) )
) : KotlinCompilationFactory<KotlinJvmAndroidCompilation> { ) : KotlinCompilationFactory<KotlinJvmAndroidCompilation> {
@@ -8,19 +8,21 @@ package org.jetbrains.kotlin.gradle.plugin.mpp
import org.jetbrains.kotlin.gradle.plugin.* import org.jetbrains.kotlin.gradle.plugin.*
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.* import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.*
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinJvmCompilerOptionsFactory
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinCompilationImplFactory import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinCompilationImplFactory
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinJvmCompilerOptionsFactory
import org.jetbrains.kotlin.gradle.targets.jvm.KotlinJvmTarget import org.jetbrains.kotlin.gradle.targets.jvm.KotlinJvmTarget
import org.jetbrains.kotlin.gradle.utils.* import org.jetbrains.kotlin.gradle.utils.*
open class KotlinJvmCompilationFactory internal constructor( open class KotlinJvmCompilationFactory internal constructor(
override val target: KotlinJvmTarget, override val target: KotlinJvmTarget
) : KotlinCompilationFactory<KotlinJvmCompilation> {
private val compilationImplFactory: KotlinCompilationImplFactory = private val compilationImplFactory: KotlinCompilationImplFactory =
KotlinCompilationImplFactory( KotlinCompilationImplFactory(
compilerOptionsFactory = KotlinJvmCompilerOptionsFactory, compilerOptionsFactory = KotlinJvmCompilerOptionsFactory,
compilationAssociator = JvmKotlinCompilationAssociator compilationAssociator = KotlinJvmCompilationAssociator
), )
) : KotlinCompilationFactory<KotlinJvmCompilation> {
override val itemClass: Class<KotlinJvmCompilation> override val itemClass: Class<KotlinJvmCompilation>
get() = KotlinJvmCompilation::class.java get() = KotlinJvmCompilation::class.java
@@ -9,7 +9,7 @@ package org.jetbrains.kotlin.gradle.plugin.mpp
import org.jetbrains.kotlin.gradle.dsl.KotlinCommonCompilerOptions import org.jetbrains.kotlin.gradle.dsl.KotlinCommonCompilerOptions
import org.jetbrains.kotlin.gradle.dsl.KotlinCommonOptions import org.jetbrains.kotlin.gradle.dsl.KotlinCommonOptions
import org.jetbrains.kotlin.gradle.plugin.HasCompilerOptions import org.jetbrains.kotlin.gradle.plugin.HasCompilerOptions
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.JvmKotlinCompilationAssociator import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.KotlinJvmCompilationAssociator
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.JvmWithJavaCompilationDependencyConfigurationsFactory import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.JvmWithJavaCompilationDependencyConfigurationsFactory
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.JvmWithJavaCompilationTaskNamesContainerFactory import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.JvmWithJavaCompilationTaskNamesContainerFactory
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinCompilationImplFactory import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinCompilationImplFactory
@@ -34,7 +34,7 @@ class KotlinWithJavaCompilationFactory<KotlinOptionsType : KotlinCommonOptions,
val kotlinOptions = kotlinOptionsFactory(compilerOptions.options) val kotlinOptions = kotlinOptionsFactory(compilerOptions.options)
KotlinCompilationImplFactory.KotlinCompilerOptionsFactory.Options(compilerOptions, kotlinOptions) KotlinCompilationImplFactory.KotlinCompilerOptionsFactory.Options(compilerOptions, kotlinOptions)
}, },
compilationAssociator = JvmKotlinCompilationAssociator, compilationAssociator = KotlinJvmCompilationAssociator,
compilationOutputFactory = { _, compilationName -> compilationOutputFactory = { _, compilationName ->
KotlinWithJavaCompilationOutput(target.javaSourceSets.maybeCreate(compilationName)) KotlinWithJavaCompilationOutput(target.javaSourceSets.maybeCreate(compilationName))
}, },
@@ -7,7 +7,7 @@
package org.jetbrains.kotlin.gradle.plugin.mpp package org.jetbrains.kotlin.gradle.plugin.mpp
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.DefaultKotlinCompilationSourceSetInclusion import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.DefaultKotlinCompilationSourceSetInclusion
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.NativeKotlinCompilationAssociator import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.KotlinNativeCompilationAssociator
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinCompilationImplFactory import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinCompilationImplFactory
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinNativeCompilerOptionsFactory import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinNativeCompilerOptionsFactory
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.NativeKotlinCompilationDependencyConfigurationsFactory import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.NativeKotlinCompilationDependencyConfigurationsFactory
@@ -20,7 +20,7 @@ open class KotlinNativeCompilationFactory internal constructor(
compilationTaskNamesContainerFactory = NativeKotlinCompilationTaskNamesContainerFactory, compilationTaskNamesContainerFactory = NativeKotlinCompilationTaskNamesContainerFactory,
compilationDependencyConfigurationsFactory = NativeKotlinCompilationDependencyConfigurationsFactory, compilationDependencyConfigurationsFactory = NativeKotlinCompilationDependencyConfigurationsFactory,
compilerOptionsFactory = KotlinNativeCompilerOptionsFactory, compilerOptionsFactory = KotlinNativeCompilerOptionsFactory,
compilationAssociator = NativeKotlinCompilationAssociator, compilationAssociator = KotlinNativeCompilationAssociator,
compilationSourceSetInclusion = DefaultKotlinCompilationSourceSetInclusion( compilationSourceSetInclusion = DefaultKotlinCompilationSourceSetInclusion(
DefaultKotlinCompilationSourceSetInclusion.NativeAddSourcesToCompileTask DefaultKotlinCompilationSourceSetInclusion.NativeAddSourcesToCompileTask
), ),
@@ -10,7 +10,7 @@ import org.jetbrains.kotlin.gradle.plugin.KotlinSourceSet
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.DefaultKotlinCompilationFriendPathsResolver import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.DefaultKotlinCompilationFriendPathsResolver
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.DefaultKotlinCompilationSourceSetInclusion import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.DefaultKotlinCompilationSourceSetInclusion
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.KotlinCompilationSourceSetsContainer import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.KotlinCompilationSourceSetsContainer
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.NativeKotlinCompilationAssociator import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.KotlinNativeCompilationAssociator
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.DefaultKotlinCompilationDependencyConfigurationsFactory import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.DefaultKotlinCompilationDependencyConfigurationsFactory
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinCompilationImplFactory import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinCompilationImplFactory
import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinNativeCompilerOptionsFactory import org.jetbrains.kotlin.gradle.plugin.mpp.compilationImpl.factory.KotlinNativeCompilerOptionsFactory
@@ -24,7 +24,7 @@ open class KotlinSharedNativeCompilationFactory internal constructor(
KotlinCompilationImplFactory( KotlinCompilationImplFactory(
compilationDependencyConfigurationsFactory = DefaultKotlinCompilationDependencyConfigurationsFactory.WithoutRuntime, compilationDependencyConfigurationsFactory = DefaultKotlinCompilationDependencyConfigurationsFactory.WithoutRuntime,
compilerOptionsFactory = KotlinNativeCompilerOptionsFactory, compilerOptionsFactory = KotlinNativeCompilerOptionsFactory,
compilationAssociator = NativeKotlinCompilationAssociator, compilationAssociator = KotlinNativeCompilationAssociator,
compilationSourceSetInclusion = DefaultKotlinCompilationSourceSetInclusion( compilationSourceSetInclusion = DefaultKotlinCompilationSourceSetInclusion(
DefaultKotlinCompilationSourceSetInclusion.NativeAddSourcesToCompileTask DefaultKotlinCompilationSourceSetInclusion.NativeAddSourcesToCompileTask